Re: [jclouds/jclouds-labs] Docker: getting container IPs of container with network(s) (#284)

Closed #284. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/284#event-690591652

Re: [jclouds/jclouds-labs] Docker: getting container IPs of container with network(s) (#284)

minor comment on the builders. thanks @aledsage --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225594885

Re: [jclouds/jclouds-labs] docker container ips: cherry-pick PR #284 (#285)

thanks @aledsage, merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/42d2352c) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] docker container ips: cherry-pick PR #284 (#285)

Closed #285. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/285#event-691544084

Re: [jclouds/jclouds-labs] Docker: getting container IPs of container with network(s) (#284)

> @@ -59,6 +59,77 @@ public static Details create(String endpointId, String > gateway, String ipAddress > return new AutoValue_NetworkSettings_Details(endpointId, gateway, > ipAddress, ipPrefixLen, ipv6Gateway, globalIPv6Address, globalIPv6PrefixLen, > macAddress); >

Re: [jclouds/jclouds-labs] Docker: getting container IPs of container with network(s) (#284)

Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6dcadf1f) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225614020

Re: [jclouds/jclouds-labs] Docker: getting container IPs of container with network(s) (#284)

thanks @aledsage, merging now! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225612094

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm compute service (#279)

> + public boolean apply(final String name) { > +runningNumber++; > + > +Deployment deployment = > api.getDeploymentApi(resourceGroupName).create(name, deploymentTemplate); > + > +if (deployment != null) { > + VMDeployment vmDeployment =

Re: [jclouds/jclouds-labs] Use container host ip not manager ip for populating node metadata. (#277)

Lgtm. I wonder how many differences/gaps there are between docker engine API and dovker swarm API. Should we consider a jclouds-docker-swarm provider based on the jclouds-docker(-engine) api or simply extend the jclouds-docker provider? @gkrvlt and @nacx, any thoughts on this? --- You are

Re: [jclouds/jclouds-labs] Add test to ensure new images available (d0ef558)

`unknown` instead of `unkown` ? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/commit/d0ef5587bc6a91143e93db897686812b10e4be91#commitcomment-17970439

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

> } > - }, null); > + }); > + if (image.isPresent()) return image.get(); > + > + // Image is not cached or getting image by name so try to pull it > + // > + > api.getImageApi().createImage(CreateImageOptions.Builder.fromImage(imageIdOrName)); what happens

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

> > - @Override > - public boolean apply(Image input) { > -return input.id().equals(imageId); > - } > - }, null); > + // Image is not cached or getting image by name so try to pull it > + >

Re: [jclouds/jclouds-labs] Clean up jclouds-labs POMs (#130)

I'll rebase this old PR asap --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/130#issuecomment-227524648

Re: [jclouds/jclouds-labs] JCLOUDS-104: Clean up jclouds-labs POMs (#130)

done, thx @andrewgaul for the review --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/130#issuecomment-227572119

Re: [jclouds/jclouds-labs] Clean up jclouds-labs POMs (#130)

I think I've rebased it, address @nacx comments; let's see if the builder is happy --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/130#issuecomment-227535642

Re: [jclouds/jclouds-labs] JCLOUDS-104: Clean up jclouds-labs POMs (#130)

rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/130#issuecomment-227580624

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm image capture userdata keyvault (#291)

> +if (nsg != null) { > + uri = > api.getNetworkSecurityGroupApi(group).delete(id + "nsg"); > + jobDone = resourceDeleted.apply(uri); > + if (jobDone) { > +

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

> @Override > public boolean apply(Image input) { > -return input.id().equals(imageId); > +for (String tag : input.repoTags()) { > + checkNotNull(imageIdOrName); I'd probably move this checkNotNull up to line 242 --- You are receiving

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

Thanks @duncangrant I've tested it and looks fine to me Please address my last comment, squash and push it again. Thanks! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

@nacx, @kwart do you like it as well? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/290#issuecomment-228007485

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

@nacx I think we can merge it as it is a good step ahead although it needs some more work for the LiveTests which we can tackle in a subsequent PR, wdyt? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-172486974

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

Reopened #197. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#event-517768511

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

@nacx I've squashed and rebased this. Good to merge? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-172493267

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

I think my best run with azurecompute was Failures: 5 Errors:0 Skipped: 0 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-172487960

Re: [jclouds-site] Added release notes for 1.9.2 (#176)

+1 thanks Ignasi --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/176#issuecomment-172240167

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

Closed #290. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/290#event-705975489

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

thanks @kwart! @duncangrant merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/5722ec22) - great work! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm compute service (#279)

Absolutely @nacx, +1 --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/279#issuecomment-226687047

Re: [jclouds-labs] [JCLOUDS-1002] provide access to Docker container Config object in the Node template options (#240)

I think it gives a better control on the container spec and it is a semplification of the options as well. I agree with @nacx - *TemplateOptions couple with low-level features offered by the specific cloud so they dont need to be portable. @gkrvlt any other thoughts? --- Reply to this email

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

Backported to [1.9.x](https://git1-us-west.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=a57446a1c4962f80d98e5b9728c66fea01a49c2f) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-173527890

Re: [jira] [Commented] (JCLOUDS-664) Azure compute support

[~ritazh] I've seen your message on ML, thanks for that. That's pretty good news! I don't think there is any ongoing effort to add ARM support so your help would be much appreciated. Feel free to ask questions/guidance on ML or IRC if you guys are keen to start the implementation! Il giorno ven

Re: [jclouds] Fix openstack nova when floating ips are not available (#860)

Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a4a255fa) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/860#issuecomment-173874399

Re: [jclouds] Fix openstack nova when floating ips are not available (#860)

Closed #860. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/860#event-522786139

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

Sorry not sure I'm following. Do I need to rebase this one? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-173359730

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

actually I did the same, waiting for the builder response now --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-173381554

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

Pushed to [master](https://git1-us-west.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=f9b393de) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-173386290

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

Closed #197. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#event-521028401

Re: [jclouds-labs] [JCLOUDS-981,JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#231)

Closed #231. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/231#event-521029543

Re: [jclouds-labs] [JCLOUDS-981,JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#231)

Thanks @kwart I've rebased and merged #197 which I think it is identical to yours now. Feel free to re-open in case I missed something, thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/231#issuecomment-173386550

Re: [jclouds-labs] [JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#197)

I will asap --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-173218137

Re: [jclouds] fix hpcloud compute adapter (#937)

Closed #937. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/937#event-589894680

Re: [jclouds] fix hpcloud compute adapter (#937)

Merged at [1.9.x](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=47251f0e) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/937#issuecomment-196707474

[jclouds] fix hpcloud compute adapter (#937)

this should fix 1.9.x branch given https://github.com/jclouds/jclouds/commit/b96c66dbceda360f8e75c95543d8940e3a540f7a#commitcomment-16676961 please @nacx can you review it? You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/937 -- Commit

Re: [jclouds] improve roll-back strategy when floating-ip are not available (b96c66d)

See https://github.com/jclouds/jclouds/pull/937 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/commit/b96c66dbceda360f8e75c95543d8940e3a540f7a#commitcomment-16691043

Re: [jclouds] improve roll-back strategy when floating-ip are not available (b96c66d)

Sure sorry I've not noticed that. Thanks for heads-up! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/commit/b96c66dbceda360f8e75c95543d8940e3a540f7a#commitcomment-16690072

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm LocationApi (#256)

great! merging now, thanks @ritazh --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/256#issuecomment-209278722

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm LocationApi (#256)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/559fdecf) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/256#issuecomment-209285813

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm LocationApi (#256)

> + */ > +package org.jclouds.azurecompute.arm.features; > + > +import org.jclouds.azurecompute.arm.domain.Location; > +import org.jclouds.azurecompute.arm.internal.BaseAzureComputeApiLiveTest; > +import org.testng.annotations.Test; > + > +import static org.testng.Assert.assertTrue; > + >

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm LocationApi (#256)

great job @ritazh only few minor comments from my side: please address them so we can merge this PR as well. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm LocationApi (#256)

> + * This Azure Resource Manager API provides all of the locations that are > available for resource providers > + * > + * > + * @see href="https://msdn.microsoft.com/en-US/library/azure/dn790540.aspx;>docs > + */ > +@Path("/locations") > +@RequestFilters(OAuthFilter.class) >

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> + logger.debug("Generating windows key for instance %s, by updating > metadata", instance.get().name()); > + final InstanceApi instanceApi = api.instancesInZone(zone); > + Metadata metadata = instance.get().metadata(); > + // If disableHtmlEscaping is not there,

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> +Throwables.propagate(e); > + } > + serialPortContents = > instanceApi.getSerialPortOutput(instance.get().name(), 4).contents(); > + String[] contentEntries = > serialPortContents.split("\n"); > +

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> + * In brief, the sequence is: > + * > + * Generate a temporary key for encrypting and decrypting the password > + * Send the RSA public key to the instance, by settings its metadata > + * Retrieve the result from the {@link SerialPortOutput} > + * Decode and decrypt the result. > + *

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> + userName = (String)params.get("userName"); > + email = (String)params.get("email"); > + > + // TODO Check whether VM is up > + try { > + // Generate the public/private key pair for encryption and > decryption. > + // TODO do we need to explicitly set 2048

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

Great start @ritazh! I plan to do a proper review shortly, but at a glance I'm really impressed by your contribution, in terms of code and documentation. Thanks! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + > FIXME_subscription-id > + > FIXME_tenant-id > + > + > https://management.azure.com/subscriptions/${test.jclouds.azurecomputearm.subscription-id} > + > 2014-04-01-preview > + > + > /path/to/cert.p12 > +password to > cert > + >

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> +See the License for the specific language governing permissions and > +limitations under the License. > + > +--> > +http://maven.apache.org/POM/4.0.0; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 >

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > +See the License for the specific language governing permissions and > +limitations under the License. > + > +--> > +http://maven.apache.org/POM/4.0.0; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + > + 4.0.0 > + > +org.apache.jclouds.labs > +jclouds-labs > +2.0.0-SNAPSHOT > + > + > + > + azurecomputearm > + jclouds azure compute arm API > + jclouds components to access an implementation of Azure's ARM > Compute Service > + bundle > + > + > + >

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

Thanks @ritazh Some minor comments and suggestions, but other than those, great start! I think we should just agree on the following: - [ ] package names: `azurecomputearm` or `azure.compute.resourcemanager` or else? --- You are receiving this because you are subscribed to this thread. Reply

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + * > + * @see href="https://msdn.microsoft.com/en-us/library/azure/dn790546.aspx;>docs > + */ > +@Path("/subscriptions/{subscriptionid}") > + > +@QueryParams(keys = "api-version", values = "2015-01-01") > +@RequestFilters(OAuthFilter.class) > +@Consumes(MediaType.APPLICATION_JSON) > +public

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + > + HashMap tags = new HashMap(); > + tags.put("tagname1", "tagvalue1"); > + > + ResourceGroup resourceGroup = > api.getResourceGroupApi(subscriptionid).create("jcloudstest", "West US", > tags); > + > + assertEquals(resourceGroup.name(),

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + } > + > + private void createResourceGroup(String name) { > + HashMap tags = new HashMap(); > + > + final ResourceGroup resourceGroup = > api.getResourceGroupApi(getSubscriptionId()).create( > + name, LOCATION, tags); > + } > + > +

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + properties.setProperty(OPERATION_TIMEOUT, "6"); > + properties.setProperty(OPERATION_POLL_INITIAL_PERIOD, "5"); > + properties.setProperty(OPERATION_POLL_MAX_PERIOD, "15"); > + properties.setProperty(TCP_RULE_FORMAT, "tcp_%s-%s"); > +

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.jclouds.azurecomputearm.internal; > +import static org.testng.Assert.assertNotNull; > + > +//import com.google.common.collect.ImmutableMap; > +import

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache License, Version

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + > +/** > + * The Azure Resource Manager API is a REST API for managing your services > and deployments. > + * > + * > + * @see href="https://msdn.microsoft.com/en-us/library/azure/dn790568.aspx; >doc > + */ > +public interface AzureComputeApi extends Closeable { > + > + /** > +* The

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + super(builder); > + } > + > + public static class Builder extends BaseProviderMetadata.Builder { > + > + protected Builder() { > + super(); > + > + id("azurecompute-arm") > + .name("Azure Resource Management ") > + .apiMetadata(new

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> + public abstract ResourceGroupProperties properties(); > + > + @SerializedNames({"id", "name", "location", "tags", "properties"}) > + public static ResourceGroup create(String id, String name, String > location, HashMap tags, ResourceGroupProperties properties) { > +

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> +import org.jclouds.rest.annotations.SelectJson; > +import org.jclouds.rest.annotations.Fallback; > +import org.jclouds.rest.annotations.MapBinder; > +import org.jclouds.rest.annotations.PayloadParam; > +import org.jclouds.rest.annotations.PATCH; > +import

Re: [jclouds-labs] JCLOUDS-664 Azurecompute-arm ResourceGroupApi (#250)

> +import org.jclouds.rest.binders.BindToJsonPayload; > + > +/** > + * The Azure Resource Manager API includes operations for managing resource > groups in your subscription. > + * > + * @see href="https://msdn.microsoft.com/en-us/library/azure/dn790546.aspx;>docs > + */ >

Re: [jclouds-labs] Use non-privileged mode for compute (#248)

> @@ -109,7 +109,7 @@ public DockerComputeServiceAdapter(DockerApi api) { > > HostConfig.Builder hostConfigBuilder = HostConfig.builder() > .publishAllPorts(true) > - .privileged(true); > + .privileged(false); probably better to add a

Re: [jclouds] fix for issue if SL machine has multiple credentials registered (#932)

merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/0248931c) thanks @ahgittin --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/932#issuecomment-193795850

Re: [jclouds] fix for issue if SL machine has multiple credentials registered (#931)

lgtm, test passing. Thanks @ahgittin ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/931#issuecomment-193794786

Re: [jclouds] fix for issue if SL machine has multiple credentials registered (#931)

Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d649c90d) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/931#issuecomment-193795526

Re: [jclouds] fix for issue if SL machine has multiple credentials registered (#931)

Closed #931. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/931#event-581757023

Re: [jclouds] fix for issue if SL machine has multiple credentials registered (#932)

Closed #932. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/932#event-581758335

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#253)

thanks @grkvlt, merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/dbea9c3e) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/253#issuecomment-205720340

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#253)

Closed #253. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/253#event-614859152

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#252)

thanks @grkvlt. Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/31381953) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/252#issuecomment-205718832

Re: [jclouds-labs] Use non-privileged mode for compute (05a5eee)

Lgtm --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/commit/05a5eee84a5361081942945ed9ba51ff91fe30d3#commitcomment-16863080

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#252)

same comments as #252 probably you don't need to create 2 PRs for master and 1.9.x but once master is merged you can certainly ask to backport it to 1.9.x. This way I think we reduce the number of PRs. Thoughts? --- You are receiving this because you are subscribed to this thread. Reply to

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#253)

thanks @grkvlt looks good, just a couple of minor comments --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/253#issuecomment-204708178

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#253)

> @@ -79,16 +78,16 @@ public Builder toBuilder() { > public static final class Builder { same here, see https://github.com/google/auto/tree/master/value#builders --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#253)

Sounds good to me. I'll take care of the builders later --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/253#issuecomment-205444612

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> @@ -173,6 +181,18 @@ >// Add lookup for InstanceToNodeMetadata >diskToSourceImage.put(instance.get().disks().get(0).source(), > template.getImage().getUri()); > > + boolean windows = options.autoCreateWindowsPassword() != null > + ?

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> @@ -0,0 +1 @@ > +org.jclouds.googlecomputeengine.GoogleComputeEngineApiMetadata do we need to commit this file? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm VNetApi and SubnetApi (#262)

Great work @nacx and @ritazh. @ritazh out of curiosity, do you have a rough idea on how many more PRs are needed to have a first usable azure-arm provider? Thanks --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm VNetApi and SubnetApi (#262)

Thx@ritazh --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/262#issuecomment-215310671

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

@nacx I think all of your comments have been addressed. good to merge it? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-215113790

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

Merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/02546dfe) Thanks @duncangrant --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

Closed #269. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#event-666947574

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + for (Deployment d : deployments){ > + VMDeployment vmDeployment = new VMDeployment(); > + vmDeployment.deployment = d; > + vmDeployment.vm = > api.getVirtualMachineApi(getGroupId()).getInstanceDetails(d.name()); > + List list = getIPAddresses(d); > +

Re: [jclouds/jclouds-labs] Support supplying key and certificate to Docker as data (#271)

merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c3cac012) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/271#issuecomment-221016468

Re: [jclouds/jclouds-labs] Support supplying key and certificate to Docker as data (#272)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c5d845d3) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/272#issuecomment-221016558

Re: [jclouds/jclouds-labs] Support supplying key and certificate to Docker as data (#271)

Closed #271. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/271#event-669105860

Re: [jclouds/jclouds-labs] Support supplying key and certificate to Docker as data (#271)

cool, thanks. lgtm. Merging now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/271#issuecomment-221016226

Re: [jclouds/jclouds-labs] Support supplying key and certificate to Docker as data (#272)

cool, thanks. lgtm. Merging now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/272#issuecomment-221016176

Re: [jclouds/jclouds-labs] Support supplying key and certificate to Docker as data (#272)

Closed #272. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/272#event-669105766

Re: [jclouds/jclouds-labs] Support supplying key and certificate to Docker as data (#272)

hi @grkvlt could you just comment on why is this needed? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/272#issuecomment-221007097

<    1   2   3   4   5   6   7   8   9   10   >