[jclouds/jclouds] update CloudstackTemplateOptions pattern (#956)

2016-05-19 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/956 -- Commit Summary -- * update CloudstackTemplateOptions pattern -- File Changes -- M

[jclouds/jclouds] update CloudstackTemplateOptions pattern (#957)

2016-05-19 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/957 -- Commit Summary -- * update CloudstackTemplateOptions pattern -- File Changes -- M

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

2016-05-19 Thread Andrea Turli
thanks @duncangrant --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220332124

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

2016-05-19 Thread Andrea Turli
ok build is happy, merging now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220331954

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

2016-05-19 Thread Andrea Turli
Closed #958. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#event-665833402

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

2016-05-19 Thread Andrea Turli
Merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7016b040) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220332030

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

2016-05-19 Thread Andrea Turli
Sorry @grkvlt I've been notified just now about this PR by github, looks like @nacx already reviewed it: thanks @nacx ! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

2016-05-19 Thread Andrea Turli
rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#issuecomment-220332247

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

2016-05-19 Thread Andrea Turli
rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#issuecomment-220373462

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

2016-05-19 Thread Andrea Turli
Lgtm --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#issuecomment-220382602

[jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-05-03 Thread Andrea Turli
This PR fixes https://issues.apache.org/jira/browse/JCLOUDS-1108 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/951 -- Commit Summary -- * [JCLOUDS-1108]: shorten hardwareId -- File Changes -- M

Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-05-02 Thread Andrea Turli
@nacx code looks sensible +1 I will keep this PR in mind if we need to revert/change the implementation later on, ok? Thanks! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-05-04 Thread Andrea Turli
I think it is a nice-to-have but hard to achieve. I think short hardwareId will be enough, don't you think @bostko ? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-05-05 Thread Andrea Turli
@aledsage good points. Thanks for your comments. Just a minor addition to what you said: if GCE CLI returns just simple names, I think we can return them and remove `uri` from `Hardware` so that `listHardwareProfiles` will be then consistent. Makese sense @nacx, @aledsage, @bostko ? --- You

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-05-06 Thread Andrea Turli
Thanks @nacx and @aledsage for your interesting inputs to the conversation. Let me step back for a moment, I think with this patch I'm trying to make the hardwareId independent of the `project` and `zone`, as GCE URI for MachineType looks like:

Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-14 Thread Andrea Turli
@andreaturli pushed 1 commit. fbe58c1 add unit tests --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/300/files/bbfa9982d1d1f2674fa45fd24ba89db1f39f0831..fbe58c1aad4aab0126a117154d3479cc9ff779f5

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-14 Thread Andrea Turli
@andreaturli pushed 1 commit. 1a2193f add unit test for storage account name generation --- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-07-25 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs-google/pull/172 -- Commit Summary -- * add firewalls conditionally -- File Changes -- M

Re: [jclouds/jclouds-examples] refactor maven structure (#88)

2016-07-29 Thread Andrea Turli
thx @demobox I didn't know about the original intention. Although I think it is a good idea, I think it doesn't work terribly well long term, most of the examples are referencing very old jclouds releases and they are not really helpful for new users. I think a half way solution can be to try

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-01 Thread Andrea Turli
>Network network = getOrCreateNetwork(templateOptions, > sharedResourceName); > - getOrCreateFirewalls(templateOptions, network, > firewallTagNamingConvention.get(group)); > + // add firewalls *only* if the template options don't contain explicit > network > + if

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-01 Thread Andrea Turli
>Network network = getOrCreateNetwork(templateOptions, > sharedResourceName); > - getOrCreateFirewalls(templateOptions, network, > firewallTagNamingConvention.get(group)); > + // add firewalls *only* if the template options don't contain explicit > network > + if

[jclouds/jclouds-examples] refactor maven structure (#88)

2016-07-26 Thread Andrea Turli
first stab at the maven structure You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-examples/pull/88 -- Commit Summary -- * refactor maven structure -- File Changes -- M blobstore-basics/pom.xml (18) M

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
@andreaturli pushed 1 commit. 03058e3 adress @nacx comments --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/985/files/4f26ab699a95a625f91b135bd7cd9eb3203417e3..03058e39d402d3fe692564a0cf9a1f071240ffe6

[jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
if ok, I'd like to backport it to 1.9.x You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/985 -- Commit Summary -- * add support for security groups -- File Changes -- M

Re: [jclouds/jclouds] update CloudstackTemplateOptions pattern (#957)

2016-08-02 Thread Andrea Turli
Closed #957. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/957#event-742493469

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
ah! it is not easy to backport it as in 1.9.x it was on jclouds-labs, so I need to open another PR referencing this review. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
the [error](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/2368/console) doesn't seem related to this PR --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-236935183

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
Merged *only* at [master](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=deeedd55) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-236936275

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
Closed #985. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#event-742543308

Re: [jclouds/jclouds-examples] refactor maven structure (#88)

2016-08-02 Thread Andrea Turli
Agreed @andrewgaul, jclouds-examples as-is is not useful. I'll try to open several subsequent PR to fix the project, maybe one maven module for each PR? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
Sorry I will asap --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-236976728

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-11 Thread Andrea Turli
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties > properties) { > properties.put("oauth.credential", "password"); > properties.put("oauth.endpoint", > "https://login.microsoftonline.com/oauth2/token;); > properties.put(CREDENTIAL_TYPE,

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @Inject > AzureComputeServiceAdapter(final AzureComputeApi api, final > AzureComputeConstants azureComputeConstants, > - CleanupResources cleanupResources) { > + CleanupResources cleanupResources, > ProviderMetadata

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @Inject > AzureComputeServiceAdapter(final AzureComputeApi api, final > AzureComputeConstants azureComputeConstants, > - CleanupResources cleanupResources) { > + CleanupResources cleanupResources, > ProviderMetadata

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @Inject > AzureComputeServiceAdapter(final AzureComputeApi api, final > AzureComputeConstants azureComputeConstants, > - CleanupResources cleanupResources) { > + CleanupResources cleanupResources, > ProviderMetadata

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties > properties) { > properties.put("oauth.credential", "password"); > properties.put("oauth.endpoint", > "https://login.microsoftonline.com/oauth2/token;); > properties.put(CREDENTIAL_TYPE,

[jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-11 Thread Andrea Turli
- change location scope to ZONE vs REGION - edit the README - fix Region.byName - add more Regions in Region class You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/308 -- Commit Summary -- * add support for whitelisting locations

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-11 Thread Andrea Turli
@andreaturli pushed 1 commit. 961db5c address initial comments from @nacx -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] Change line endings on files recursively (#981)

2016-07-13 Thread Andrea Turli
Closed #981. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/981#event-722264425

Re: [jclouds/jclouds] Change line endings on files recursively (#981)

2016-07-13 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a515ce2f) and backported at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c10d7a65) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds] Change line endings on files recursively (#980)

2016-07-12 Thread Andrea Turli
This should avoid to see changes right after cloning the project If ok, I'd like it backported to 1.9.x You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/980 -- Commit Summary -- * Change line endings on files recursively -- File

[jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-13 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/300 -- Commit Summary -- * [azure-arm] add supports to port ranges to addNetworkSecurityGroup -- File Changes -- M

Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-15 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/b975be5e) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/300#issuecomment-232909926

Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-15 Thread Andrea Turli
Closed #300. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/300#event-724149884

[jclouds/jclouds] Change line endings on files recursively (#981)

2016-07-12 Thread Andrea Turli
This should avoid to see changes right after cloning the project If ok, I'd like it backported to 1.9.x You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/981 -- Commit Summary -- * Change line endings on files recursively -- File

Re: [jclouds/jclouds] Change line endings on files recursively (#980)

2016-07-12 Thread Andrea Turli
Closed #980. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/980#event-720297988

Re: [jclouds/jclouds] Change line endings on files recursively (#981)

2016-07-12 Thread Andrea Turli
Thx @andrewgaul I think .gitattributes file handles `.cmd` files correctly --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/981#issuecomment-232138033

[jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-13 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/301 -- Commit Summary -- * [azure-arm] add controlled storage account name generation -- File Changes -- M

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
thx @ritazh merging it now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-238021534

Re: [jclouds/jclouds] Cleanup imports in google-compute-engine project. (#989)

2016-08-07 Thread Andrea Turli
Thx @nelsonjr could you please avoid to reorder the imports and remove only the unused? It's a bit hard to review this PR otherwise. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d0b07a66) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-238022091

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
Closed #301. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#event-747433245

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-08-06 Thread Andrea Turli
I'm gonna close it as it doesn't need to be really useful as-is. We'll come back to it later if needed --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/951#issuecomment-238022343

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-08-06 Thread Andrea Turli
Closed #951. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/951#event-747434271

Re: [jclouds/jclouds] [1.9.x] update CloudstackTemplateOptions pattern (#956)

2016-08-06 Thread Andrea Turli
I think this is a straightforward improvements to the CloudstackTemplateOptions to be in line with the other `*TemplateOptions` which we also tested in a real env. @nacx good to merge? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Fix InitScriptConfigurationForTasks.initScriptPattern on Windows hosts (#677)

2016-08-06 Thread Andrea Turli
@rdowner can you please address the 2 minor comments from @nacx so that we can merge it? Thanks! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/677#issuecomment-238022564

Re: [jclouds/jclouds] adding attache detach interface to nova api (#697)

2016-08-06 Thread Andrea Turli
hi @limorbortman, can you address the last comment from @limorbortman so that we can finally merge this one? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/697#issuecomment-238022635

[jclouds/jclouds] GCE: fix tags order (#987)

2016-08-02 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/987 -- Commit Summary -- * GCE: fix tags order -- File Changes -- M

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds.provider$google-compute-engine/3458/changes --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-237006693

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-02 Thread Andrea Turli
>Network network = getOrCreateNetwork(templateOptions, > sharedResourceName); > - getOrCreateFirewalls(templateOptions, network, > firewallTagNamingConvention.get(group)); > + // add firewalls *only* if the template options don't contain explicit > network > + if

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-02 Thread Andrea Turli
Closed #172. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/172#event-742064063

Re: [jclouds/jclouds-labs] ImageId can be image name or id and will pull from hub (#293)

2016-06-30 Thread Andrea Turli
thanks @duncangrant, merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/aa37c7f3) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] ImageId can be image name or id and will pull from hub (#293)

2016-06-30 Thread Andrea Turli
Closed #293. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/293#event-709023574

Re: [jclouds/jclouds-labs] Connect container to list of networks in options (#296)

2016-07-02 Thread Andrea Turli
> @@ -104,4 +104,27 @@ public static Network create(String name, String id, > String scope, String driver >return new AutoValue_Network(name, id, scope, driver, ipam, > copyOf(containers), copyOf(options)); I think you may want to change it to ``` return

Re: [jclouds/jclouds-labs] Connect container to list of networks in options (#296)

2016-07-03 Thread Andrea Turli
@gkrvlt I think that TemplateOptions.networks https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/options/TemplateOptions.java is the right mapping. No need for a new custom template option, in my opinion. Wdyt? --- You are receiving this because you are

Re: [jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

2017-02-03 Thread Andrea Turli
tested successfully `mvn clean install` with jclouds-labs, jclouds-labs-aws, jclouds-labs-google jclouds-labs-openstack seems to have building problems independent of that PR -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
@andreaturli pushed 1 commit. 1af6d96 remove overriden live test as it is now pushed up to jclouds/jclouds -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] change hostname command to get the short form (#1056)

2017-01-31 Thread Andrea Turli
thanks @nacx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1056#issuecomment-276313955

Re: [jclouds/jclouds] change hostname command to get the short form (#1056)

2017-01-31 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4c2151a3) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/10a585e5) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] change hostname command to get the short form (#1056)

2017-01-31 Thread Andrea Turli
Closed #1056. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1056#event-942719844

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
good question, @nacx! >From what I got, Packet has 2 types of SSH keys: Project and Personal Keys. Any new servers you deploy to projects you are a collaborator on will have your project and personal SSH keys, if defined. Now if no SSH keys are defined in your account, jclouds will [generate

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
@andreaturli pushed 1 commit. d55fffe improve comments on the adapter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -59,6 +48,14 @@ protected Module getSshModule() { return new SshjSshClientModule(); } + public void testMyListNodes() throws Exception { + for (ComputeMetadata node : client.listNodes()) { + assert node.getProviderId()

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
@andreaturli pushed 1 commit. 8b94bee remove useless test -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/354/files/d55fffe18221be7a559e513becc07ad0637d2f7b..8b94bee913ee5f14a8417b433a9c85ac9205afcc

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
Closed #354. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/354#event-943174558

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/99697600) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/354#issuecomment-276385182

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
squashing and merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/354#issuecomment-276384651

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

2017-01-31 Thread Andrea Turli
added the comment to adapter? good to merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/354#issuecomment-276357302

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

2017-02-06 Thread Andrea Turli
@andreaturli pushed 1 commit. 3896a3f fix karaf-maven-plugin -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92/files/425dd892d3efc7f67a7d7b30e43c8b0fae519adf..3896a3fac4e477d55636ad7a4998b9897c8c2b2b

Re: [jclouds/jclouds] update import packages for netty (#1058)

2017-02-06 Thread Andrea Turli
I'm creating a `feature`for netty driver in jclouds-karaf (`mvn:io.netty/netty/3.5.9.Final`) and it doesn't seem to export `org.jboss.netty*` - changing the import solves the problem -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] update import packages for netty (#1058)

2017-02-06 Thread Andrea Turli
I've re-tested with the current version and it seems to work. Closing the PR, though. Sorry for the noise, @nacx especially OSGi is interesting ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] update import packages for netty (#1058)

2017-02-06 Thread Andrea Turli
Closed #1058. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1058#event-950184068

Re: [jclouds/jclouds] update import packages for netty (#1058)

2017-02-06 Thread Andrea Turli
Reopened #1058. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1058#event-950310375

Re: [jclouds/jclouds-labs] Add Load Balancer APIs (#356)

2017-02-02 Thread Andrea Turli
andreaturli commented on this pull request. it's a pretty big PR! I've looked at the implementation and it looks sensible Few minor comments. Can you please share the mock and live tests results? > + private final AzureComputeApi api; + private final LoadingCache

Re: [jclouds/jclouds-labs] Add Load Balancer APIs (#356)

2017-02-02 Thread Andrea Turli
andreaturli commented on this pull request. > } - protected URI deleteResourceGroup(String resourceGroupName) { - return api.getResourceGroupApi().delete(resourceGroupName); + protected void deleteResourceGroup(final String resourceGroupName) { + URI uri =

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

2017-02-06 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -52,38 +52,56 @@ limitations under the License. mvn:org.apache.jclouds.api/atmos/${jclouds.version} @neykov you mean I can remove `resolver='(obr)'` for all the features? -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds] Fix O(n^2) response time for "list-security-groups" on openstack-nova. (#1059)

2017-02-06 Thread Andrea Turli
andreaturli commented on this pull request. Thanks @geomacy very useful! I've only some minor comments now but I've not run testa yet. I'll do ASAP and add my further comments. > @@ -135,8 +136,9 @@ public NovaSecurityGroupExtension(NovaApi api, } Set groupNames =

Re: [jclouds/jclouds] Fix O(n^2) response time for "list-security-groups" on openstack-nova. (#1059)

2017-02-06 Thread Andrea Turli
Exemplar PR description and jira tracking, btw -- impressive work @geomacy -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1059#issuecomment-277795103

Re: [jclouds/jclouds-labs] Cleanup orphaned availability sets (#358)

2017-02-06 Thread Andrea Turli
andreaturli approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/358#pullrequestreview-20360165

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

2017-02-05 Thread Andrea Turli
@andreaturli pushed 1 commit. 21b7fc7 bump karaf version in itests -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92/files/eaee0b4a3575f7761bd39d79b93927fdd7426334..21b7fc7e0444d914cce02907b75a2b01c7bd86ac

[jclouds/jclouds-karaf] fix netty dependency (#96)

2017-02-06 Thread Andrea Turli
/cc @nacx You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-karaf/pull/96 -- Commit Summary -- * fix netty dependency -- File Changes -- M pom.xml (2) -- Patch Links -- https://github.com/jclouds/jclouds-karaf/pull/96.patch

Re: [jclouds/jclouds-karaf] fix netty dependency (#96)

2017-02-06 Thread Andrea Turli
@nacx I think the build is fix now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/96#issuecomment-22437

Re: [jclouds/jclouds-karaf] fix netty dependency (#96)

2017-02-06 Thread Andrea Turli
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/96#issuecomment-277762744

Re: [jclouds/jclouds-karaf] fix netty dependency (#96)

2017-02-06 Thread Andrea Turli
Closed #96. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/96#event-950755593

Re: [jclouds/jclouds-karaf] fix netty dependency (#96)

2017-02-06 Thread Andrea Turli
Reopened #96. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/96#event-950755630

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

2017-02-05 Thread Andrea Turli
@andreaturli pushed 1 commit. eaee0b4 add providers -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92/files/0303badf39d88b82292ab27b9876b9d7c4c138ee..eaee0b4a3575f7761bd39d79b93927fdd7426334

Re: [jclouds/jclouds-karaf] [DO NOT MERGE YET] Improvements to feature (#92)

2017-02-06 Thread Andrea Turli
@andreaturli pushed 1 commit. 2da7683 re-add jclouds-guice used by jclouds-cli -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] update import packages for netty (#1058)

2017-02-06 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4ae2d208) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/663123a9) thanks @nacx for reviewing it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds] update import packages for netty (#1058)

2017-02-06 Thread Andrea Turli
Closed #1058. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1058#event-950558068

<    1   2   3   4   5   6   7   8   9   10   >