Re: [jclouds/jclouds] fix jclouds/apis/swift retryOnRenew (#1027)

2016-10-31 Thread Andrea Turli
Merged at [master](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=9b3e6d91bff99b39699a333eec798d1f2cd5cded) and [1.9.x](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=9b3e6d91bff99b39699a333eec798d1f2cd5cded) -- You are receiving this because you are

Re: [jclouds/jclouds] [aws-ec2] Add CRUD for VPC (#1032)

2016-10-31 Thread Andrea Turli
Closed #1032. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1032#event-841950796

Re: [jclouds/jclouds] [aws-ec2] Add CRUD for VPC (#1032)

2016-10-31 Thread Andrea Turli
Squashed and merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8649c3ff) backported at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7158b94b) thanks @nacx for the review! -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [jclouds/jclouds] fix jclouds/apis/swift retryOnRenew (#1027)

2016-10-31 Thread Andrea Turli
Closed #1027. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1027#event-841967206

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-10-11 Thread Andrea Turli
@andreaturli pushed 1 commit. 5b68d09 Fixed build -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/323/files/7bcf96291e93580e3979121e8c4771d9e2948088..5b68d091d61b69037c7563f79cdb5e627da88529

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-10-11 Thread Andrea Turli
@andreaturli pushed 5 commits. 8d0cd4d Make api versions configurable 5b832bf wip 716ab74 wip 4045789 AzureComputeServiceLiveTest passing 7bcf962 Cleanup code -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-10-11 Thread Andrea Turli
@nacx any suggestions to fix https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/1526/org.apache.jclouds.labs$azurecompute-arm/console ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-10-11 Thread Andrea Turli
@andreaturli pushed 1 commit. d9600c0 fix import -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/323/files/5b68d091d61b69037c7563f79cdb5e627da88529..d9600c00f8ff2ffdb925038ff3dd4cee371b2ab3

[jclouds/jclouds] reduce payload for GET VirtualGuests (#1020)

2016-10-13 Thread Andrea Turli
Using this objectMask instead of previous, json payload passes from 69.8 M ``` $ curl -uuser:api-key https://api.softlayer.com/rest/v3/SoftLayer_Account/VirtualGuests?objectMask=powerState%3BoperatingSystem.passwords%3Bdatacenter%3BbillingItem%3BblockDevices.diskImage%3BtagReferences % Total

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-10-13 Thread Andrea Turli
@andreaturli pushed 1 commit. 2266331 Fixed Azure ARM Image extension -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Added support for metadata and tags to Azure ARM (#327)

2016-10-17 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -177,10 +176,9 @@ public String apply(VirtualMachineStatus input) { builder.privateAddresses(getPrivateIpAddresses(virtualMachine.properties().networkProfile().networkInterfaces())); if (virtualMachine.tags() != null) { -

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#81)

2016-12-08 Thread Andrea Turli
not sure why, but it is not in `master` can you re-open this PR, please? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-265689847

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#91)

2016-12-08 Thread Andrea Turli
thx @neykov -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/91#issuecomment-265787422

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#91)

2016-12-08 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/acc3533d) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/91#issuecomment-265787376

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#91)

2016-12-08 Thread Andrea Turli
Closed #91. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/91#event-887126792

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#81)

2016-12-07 Thread Andrea Turli
@neykov why was that deleted? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-265585263

Re: [jclouds/jclouds-site] Javadoc index in reverse order and link to PonyMail (#192)

2016-12-12 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -8,6 +8,7 @@ title: Get in touch! We'd love to have your feedback, suggestions, and will be happy to help with anything you need. Just get in touch! + https://lists.apache.org/list.html?jclouds.apache.org;>Browse and

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
andreaturli commented on this pull request. > + @Override + protected void configure() { + install(new PacketComputeParserModule()); + super.configure(); + } + + @Override + protected void bindErrorHandlers() { +

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
andreaturli commented on this pull request. > + @Override + public Builder toBuilder() { + return new Builder().fromApiMetadata(this); + } + + public PacketApiMetadata() { + this(new Builder()); + } + + protected PacketApiMetadata(Builder builder) { + super(builder);

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
andreaturli commented on this pull request. > + super(builder); + } + + public static Properties defaultProperties() { + Properties properties = BaseHttpApiMetadata.defaultProperties(); + properties.put(TEMPLATE, "osFamily=UBUNTU,os64Bit=true,osVersionMatches=14.*"); +

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
andreaturli commented on this pull request. > + properties.put(TEMPLATE, > "osFamily=UBUNTU,os64Bit=true,osVersionMatches=14.*"); + properties.put(TIMEOUT_NODE_RUNNING, 30); // 5 mins + return properties; + } + + public static class Builder extends

Re: [jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)

2017-01-14 Thread Andrea Turli
@andreaturli pushed 1 commit. 9930d64 address @nacx comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/343/files/595ce8b6bb7319c99c9a3df1e7b3e2e4a70d69b4..9930d64ab6373162bd9c5d0ae01be001887d4d5e

Re: [jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)

2017-01-14 Thread Andrea Turli
andreaturli commented on this pull request. > +import static com.google.common.base.Preconditions.checkNotNull; + +@Singleton +public class AddApiVersionToRequest implements HttpRequestFilter { + +private final String apiVersion; + +@Inject +public AddApiVersionToRequest(@ApiVersion

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
@andreaturli pushed 1 commit. 2b4840b fix typo -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/340/files/a64d73b7b153ec3639450b5efc371a600eb09870..2b4840bf717719e31d448d60c315bb477bed50cd

Re: [jclouds/jclouds-karaf] Fixes hardcoded karaf etc path in `jclouds-services` feature (#93)

2017-01-11 Thread Andrea Turli
lgtm, thanks @m4rkmckenna, merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/93#issuecomment-271901247

Re: [jclouds/jclouds-karaf] Fixes hardcoded karaf etc path in `jclouds-services` feature (#93)

2017-01-11 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/a9cffdd8) Thanks @m4rkmckenna -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-karaf] Fixes hardcoded karaf etc path in `jclouds-services` feature (#93)

2017-01-11 Thread Andrea Turli
Closed #93. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/93#event-919297253

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-11 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/070fe653) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/340#issuecomment-271875353

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

2017-01-09 Thread Andrea Turli
I think you are right, @nacx, we need to bump karaf version as well modern-itests vs itests are just easier to read/write and they use the recent capabilities offered by pax exam etc I've seen also better error messages and less boilerplate code When modern-itests will have all of the tests

Re: [jclouds/jclouds-labs] [JCLOUDS-1219] initial commit for Packet.net API (#337)

2017-01-09 Thread Andrea Turli
thx @nacx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/337#issuecomment-271420887

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-11 Thread Andrea Turli
ok thanks, merging! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/340#issuecomment-271874692

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-11 Thread Andrea Turli
Closed #340. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/340#event-919140102

Re: [jclouds/jclouds-labs] Fix generateStorageAccountName (#342)

2017-01-11 Thread Andrea Turli
Sure @nacx see [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/784ee020) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/342#issuecomment-271992269

[jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)

2017-01-12 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/343 -- Commit Summary -- * add AddApiVersionToRequest filter -- File Changes -- M packet/src/main/java/org/jclouds/packet/PacketApiMetadata.java (1) M

Re: [jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)

2017-01-14 Thread Andrea Turli
andreaturli commented on this pull request. >assertEquals(request.getHeader("X-Auth-Token"), X_AUTHORIZATION_TOKEN); return request; } protected RecordedRequest assertSent(MockWebServer server, String method, String path, String json) throws

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
@andreaturli pushed 1 commit. a64d73b add pagination to Project API -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/340/files/4ce88bff4bb288d6d83351b28d941f4f8641d24e..a64d73b7b153ec3639450b5efc371a600eb09870

Re: [jclouds/jclouds-labs] Add tenant Id lookup command (#341)

2017-01-10 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a3a6ef29) Thanks @drigodwin! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Add tenant Id lookup command (#341)

2017-01-10 Thread Andrea Turli
Closed #341. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/341#event-917873067

Re: [jclouds/jclouds-labs] Add tenant Id lookup command (#341)

2017-01-10 Thread Andrea Turli
thanks @drigodwin, looks good to me, merging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/341#issuecomment-271640066

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
@nacx I'm adding pagination as well, agreed better sooner than later re PublicKey I think it was a typo from my first PR, this provider is not using them in the domain objects. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
andreaturli commented on this pull request. > +import org.jclouds.location.suppliers.implicit.FirstRegion; +import org.jclouds.packet.PacketApi; +import org.jclouds.packet.handlers.PacketErrorHandler; +import org.jclouds.rest.ConfiguresHttpApi; +import org.jclouds.rest.config.HttpApiModule; +

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
andreaturli commented on this pull request. > + +public static Properties defaultProperties() { +final Properties properties = PacketApiMetadata.defaultProperties(); +return properties; +} + +public static class Builder extends BaseProviderMetadata.Builder { + +

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-11 Thread Andrea Turli
@andreaturli pushed 1 commit. 0315649 test pagination -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/340/files/2b4840bf717719e31d448d60c315bb477bed50cd..031564949f567d96fdc7ac10d5c3b2d0c2a5c83c

Re: [jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-11 Thread Andrea Turli
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/340#issuecomment-271844332

Re: [jclouds/jclouds-labs] Fix generateStorageAccountName (#342)

2017-01-11 Thread Andrea Turli
Closed #342. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/342#event-919465570

Re: [jclouds/jclouds-labs] Fix generateStorageAccountName (#342)

2017-01-11 Thread Andrea Turli
thanks @drigodwin merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6103e810) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-karaf] Added motivation for the bundles module (522e245)

2017-01-05 Thread Andrea Turli
thanks for the reply, @nacx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/commit/522e245582acb3595144f4b02208909e3b935564#commitcomment-20373985

[jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

2017-01-05 Thread Andrea Turli
I'd like to push out this PR to have feedback from osgi/karaf experts, as I'm not This PR: - re-organize `feature.xml` to alphabetical order to simplify the review process - bump osgi and karaf version - add a new `modern-itests` maven module inspired by

Re: [jclouds/jclouds-labs] Vagrant provider (#160)

2016-12-30 Thread Andrea Turli
andreaturli commented on this pull request. > + * `git clone https://github.com/neykov/vagrant-java-bindings` + * `cd vagrant-java-bindings` + * `mvn clean install` + * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's classpath +2. Vagrant provider + * `git clone

Re: [jclouds/jclouds-labs] Vagrant provider (#160)

2016-12-30 Thread Andrea Turli
andreaturli commented on this pull request. > + @Override + protected void configure() { + super.configure(); + bind(new TypeLiteral>() { + }).to(VagrantComputeServiceAdapter.class); + bind(new

[jclouds/jclouds-labs] [JCLOUDS-1219] initial commit for Packet.net API (#337)

2017-01-03 Thread Andrea Turli
This is the first PR for Packet API, to simplify the review process, and it only adds the pom.xml and the domain objects, based on https://www.packet.net/developers/api/ Those are the minimum set needed to support the jclouds abstraction. You can view, comment on, or merge this pull request

Re: [jclouds/jclouds-labs] [JCLOUDS-1219] initial commit for Packet.net API (#337)

2017-01-05 Thread Andrea Turli
andreaturli commented on this pull request. > + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file

Re: [jclouds/jclouds] update Docker README (#1048)

2017-01-05 Thread Andrea Turli
Closed #1048. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1048#event-912317410

Re: [jclouds/jclouds] update Docker README (#1048)

2017-01-05 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c2cda931) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1d562d91) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1219] initial commit for Packet.net API (#337)

2017-01-05 Thread Andrea Turli
andreaturli commented on this pull request. > + +@AutoValue +public abstract class IpAddress { + +public abstract String id(); +public abstract Integer addressFamily(); +public abstract String netmask(); +public abstract Boolean publicAddress(); +public abstract Integer

Re: [jclouds/jclouds-karaf] Added motivation for the bundles module (522e245)

2017-01-05 Thread Andrea Turli
@nacx is the more recent version on [serviceMix](https://mvnrepository.com/artifact/org.apache.servicemix.bundles/org.apache.servicemix.bundles.jsch-agentproxy-jsch/0.0.9_1) still not good for jclouds? -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [jclouds/jclouds-labs] Vagrant provider (#160)

2016-12-29 Thread Andrea Turli
andreaturli commented on this pull request. > + * `git clone https://github.com/neykov/vagrant-java-bindings` + * `cd vagrant-java-bindings` + * `mvn clean install` + * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's classpath +2. Vagrant provider + * `git clone

Re: [jclouds/jclouds-labs] Vagrant provider (#160)

2016-12-29 Thread Andrea Turli
andreaturli commented on this pull request. > + +Building + + +1. Vagrant bindings + * `git clone https://github.com/neykov/vagrant-java-bindings` + * `cd vagrant-java-bindings` + * `mvn clean install` + * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's classpath

[jclouds/jclouds] update Docker README (#1048)

2017-01-04 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1048 -- Commit Summary -- * update Docker README -- File Changes -- M apis/docker/README.md (13) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1048.patch

Re: [jclouds/jclouds] update Docker README (#1048)

2017-01-04 Thread Andrea Turli
@andreaturli pushed 1 commit. ffc38da improve description for osx -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1048/files/ddb3b137a8188d0ddbc4678816fc4970d8b4b801..ffc38dad68844bf42d259e678191669c7920cc9a

[jclouds/jclouds-labs] Add skeleton for ApiMetadata and ProviderMetadata (#340)

2017-01-10 Thread Andrea Turli
- add ApiMetadata and ProviderMetadata - add skeleton for PacketApi with ProjectApi only - add XAuthTokenToRequest filter - add HttpApiModule and ParserModule - add ProjectApi feature with Mock and Live Tests You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds-labs] [JCLOUDS-1219] initial commit for Packet.net API (#337)

2017-01-09 Thread Andrea Turli
Closed #337. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/337#event-916645302

Re: [jclouds/jclouds-labs] [JCLOUDS-1219] initial commit for Packet.net API (#337)

2017-01-09 Thread Andrea Turli
ok I will open up the next PR with what you suggested. merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/337#issuecomment-271419271

Re: [jclouds/jclouds-labs] [JCLOUDS-1219] initial commit for Packet.net API (#337)

2017-01-09 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/cb3ab1ca) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/337#issuecomment-271420829

Re: [jclouds/jclouds-labs] Vagrant provider (#160)

2016-12-28 Thread Andrea Turli
thx @neykov, sorry for being late in this discussion. Just thinking aloud, would it be acceptable for you to donate the https://github.com/neykov/vagrant-java-bindings to jclouds as well? I'm seeing it as a maven submodule of jclouds-vagrant which is completely in sync with the jclouds-vagrant

[jclouds/jclouds-karaf] Update pom.xml to match xmlbuilder version (#90)

2016-12-07 Thread Andrea Turli
use same version used at https://github.com/jclouds/jclouds/blob/5a3cfe5dbe5398ee6c81a21a279363c3caa51728/project/pom.xml#L236 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-karaf/pull/90 -- Commit Summary -- * Update pom.xml to match

Re: [jclouds/jclouds-site] Support apache disclaimer (#196)

2017-03-28 Thread Andrea Turli
thanks @nacx - is it a temporary "banner" or else? Looks a bit "invasive" IMHO -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/196#issuecomment-289798754

Re: [jclouds/jclouds-cli] Reference super features in assembly module (#37)

2017-03-19 Thread Andrea Turli
lgtm -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287603210

Re: [jclouds/jclouds-cli] Reference super features in assembly module (#37)

2017-03-18 Thread Andrea Turli
@neykov I assume this will work once we merge jclouds-karaf#98 right? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287559924

Re: [jclouds/jclouds-karaf] Add back the cloudsigma-api feature for backwards compatibility (#99)

2017-03-18 Thread Andrea Turli
Out of curiosity, jclouds-cli requires it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/99#issuecomment-287560210

Re: [jclouds/jclouds-karaf] Group labs features in super features (#98)

2017-03-18 Thread Andrea Turli
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/98#issuecomment-287559863

[jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-03-18 Thread Andrea Turli
- add DiskApi + tests - add ImageApi + tests - add TemplateOptions.dataDisks - use dataDisks in adapter You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/372 -- Commit Summary -- * Initial support ManagedDataDisks -- File Changes

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-18 Thread Andrea Turli
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287523859

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-18 Thread Andrea Turli
the build failure looks related, see https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/org.apache.jclouds.labs$azurecompute/1710/testReport/junit/org.jclouds.azurecompute.features/DeploymentApiMockTest/testCreateWindows/ -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-18 Thread Andrea Turli
andreaturli commented on this pull request. a minor comment, but overall looks good > @@ -54,6 +54,7 @@ protected String networkSecurityGroupName; protected String reservedIPName; protected Boolean provisionGuestAgent; + protected Boolean winrmUseHttps; isn't `String

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-03-20 Thread Andrea Turli
Thanks @nacx for your review, the impl was a bit raw but I wanted to open the PR to start the discussion in the open, especially with @danielestevez As for the plan, yes it is exactly what I had in mind! -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-20 Thread Andrea Turli
+1 merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287791413

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-20 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/2fe3e0c1) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287792683

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-20 Thread Andrea Turli
does it need to be backport to 2.0.x, @bostko ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/371#issuecomment-287792337

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-20 Thread Andrea Turli
makes sense please remember to open a jira issue to track the improvements you want to make. merged at [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/69ef8765) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

2017-03-20 Thread Andrea Turli
Closed #371. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/371#event-1006888516

Re: [jclouds/jclouds-labs] JCLOUDS-1255 - initial commit of Dimension Data CloudControl jclouds (#369)

2017-03-17 Thread Andrea Turli
andreaturli commented on this pull request. > + + + + +com.google.auto.value +auto-value +provided + + +com.google.auto.service +auto-service +provided + +

Re: [jclouds/jclouds-labs] JCLOUDS-1255 - initial commit of Dimension Data CloudControl jclouds (#369)

2017-03-17 Thread Andrea Turli
andreaturli commented on this pull request. > + STANDARD(20), + + /** +* Dimension Data High-Performance speed CPU. +* +* May not be available in all datacenters. +*/ + HIGHPERFORMANCE(30); + + /** +* The value used to represent this CPU speed in JClouds. +* +

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

2017-03-17 Thread Andrea Turli
thanks @neykov I think this should be merged as it is there for too long :) @nacx are you ok as well? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287322399

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

2017-03-17 Thread Andrea Turli
cool. merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287333680

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

2017-03-17 Thread Andrea Turli
Closed #92. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#event-1004319668

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

2017-03-17 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/fa11dcfc) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287334268

Re: [jclouds/jclouds-labs] Adding Dimension Data ServerImageAPI (#380)

2017-04-07 Thread Andrea Turli
andreaturli commented on this pull request. > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jclouds.dimensiondata.cloudcontrol.domain; +

Re: [jclouds/jclouds-labs] Adding Dimension Data ServerImageAPI (#380)

2017-04-07 Thread Andrea Turli
andreaturli commented on this pull request. thanks @trevorflanagan some minor comments from me but overall looks good to me > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-07 Thread Andrea Turli
sorry @nacx and @danielestevez for long radio silence, I'm having another look at this. I've addressed most of the comments and rebased, let's see if the builder is happier. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-11 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -76,12 +83,50 @@ public AzureTemplateOptions availabilitySet(String > availabilitySetName) { return this; } + public AzureTemplateOptions dataDisks(List> dataDisksAsMap) { I think it'd simplify the

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-11 Thread Andrea Turli
andreaturli commented on this pull request. > - toString.add("availabilitySet", availabilitySet); - toString.add("availabilitySetName", availabilitySetName); - return toString; + public int hashCode() { + int result = super.hashCode(); + result = 31 * result +

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-11 Thread Andrea Turli
@andreaturli pushed 2 commits. 6c94353 comments addressed 89b947a fix VirtualMachineApiMockTest -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-11 Thread Andrea Turli
cool @nacx, merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#issuecomment-293206450

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-11 Thread Andrea Turli
pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/51ddc26f) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#issuecomment-293207723

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-11 Thread Andrea Turli
ported to [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f4771185) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#issuecomment-293214239

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-04-11 Thread Andrea Turli
Closed #372. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#event-1038008199

Re: [jclouds/jclouds-labs] Update README.md (#383)

2017-04-21 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -1 +1,6 @@ # Apache jclouds Packet (packet.net) provider + + +## Pre-requisites + +If you are using Oracle JDK you want to install JCE following the [official

Re: [jclouds/jclouds-labs] Update README.md (#383)

2017-04-21 Thread Andrea Turli
@andreaturli pushed 1 commit. 7eee4b1 improve packet readme -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/383/files/03c72cf1c9b0eb24117b66b781695ac93eb5a855..7eee4b1af2ec5c2f02ce7d1d96a27c2528125d08

Re: [jclouds/jclouds-labs] Update README.md (#383)

2017-04-21 Thread Andrea Turli
Closed #383. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/383#event-1052117689

<    4   5   6   7   8   9   10   11   12   13   >