Merged
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/8c4d97fb)
and back-ported at
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/9a22e808)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
thanks @drigodwin, this looks helpful. merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/384#issuecomment-296137615
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c45162c1)
and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/64bcdc07)
Thanks @drigodwin
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
Closed #384.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/384#event-1052127181
if our CI uses openjdk that shouldn't be required, I think
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/383#issuecomment-296235174
hi @nacx trying to run the live tests with maven but after 2 hours it is still
at
```
---
T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support
Thanks @nacx looks a very useful simplification: it's quite a big PR so I need
to allocate some time to review carefully. I'll report the results of live
tests asap, meanwhile
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/383
-- Commit Summary --
* Update README.md
-- File Changes --
M packet/README.md (5)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/383.patch
andreaturli commented on this pull request.
> - properties.put(CREDENTIAL_TYPE, CLIENT_CREDENTIALS_SECRET.toString());
- properties.put(PROPERTY_REGIONS, "westeurope");
- properties.put(IMAGE_PUBLISHERS, "Canonical");
- properties.put(RESOURCENAME_PREFIX, "jcloudstest");
my last run shows
```
Results :
Failed tests:
AzureComputeSecurityGroupExtensionLiveTest.testCreateNodeWithInboundPorts:134
expected [{ipProtocol=tcp, fromPort=22, toPort=24, tenantIdGroupNamePairs={},
groupIds=[], cidrBlocks=[0.0.0.0/0], exclusionCidrBlocks=[]}] but found
[{ipProtocol=tcp,
ok @nacx makes a lot of sense. I've a minor comment still pending, if you can
address it, the I think we can merge it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I've tested jclouds-labs#382 with this patch and it helps!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1089#issuecomment-296374932
lgtm
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/382#issuecomment-296401024
@nacx using your jclouds/jclouds#1089 seems to pass the jetty issue but the
test itself fails
```
Starting test
testCreateAndRunAService(org.jclouds.azurecompute.arm.compute.AzureComputeServiceLiveTest)
Apr 21, 2017 10:58:54 PM
org.jclouds.compute.internal.BaseComputeServiceLiveTest
@andreaturli pushed 1 commit.
a9f7814 add missing import
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/f1b152a8abf6ab1b0557724377aa49cf071203d9..a9f7814772cb0edd1f66bfad1ce6835f7870a0f6
@andreaturli pushed 1 commit.
f1b152a use default karaf-maven-plugin in feature and feature-labs
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@andreaturli pushed 1 commit.
f91b354 fix FeatureLabsInstallationTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@nacx any idea for this
https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/199/org.apache.jclouds.karaf$commands/console
?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
andreaturli commented on this pull request.
> @@ -27,7 +27,6 @@
import org.jclouds.compute.domain.OsFamily;
import org.jclouds.compute.domain.TemplateBuilder;
import org.jclouds.compute.options.TemplateOptions;
-import org.jclouds.ec2.compute.options.EC2TemplateOptions;
Right but not sure
@andreaturli pushed 1 commit.
e4e1560 fix
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/f91b3547c08076606386dc83086ebfa31eb99e5b..e4e156040f1785992c44ee74062ef03e268aab9e
@nacx @neykov I think it is finally mergeable, let me know
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-285647968
@andreaturli pushed 2 commits.
c9d68a4 split feature-labs into a separate module
dabeef1 remove resolver=(obr) from features as not used
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@iyovcheva do you think it is still needed? if yes, can you address the
remaining comments, please? Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli pushed 1 commit.
471b49b fix ServiceTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/dabeef16931f126001acaecc6a1eaafbab2aeb35..471b49bc095fe131b03d17e1c15f456903451e8a
cool, merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1060#issuecomment-284435569
Closed #1060.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1060#event-988011469
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/014f7a4f) and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8268a2db)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@nacx Renamed the package, sorry about that
Re the Parametrized tests, I think it is a nice-to-have rather than a must,
shall I use that feature in this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli pushed 3 commits.
ec4ee03 Update JSCH to version 0.1.54
0cf5d91 use netty.bundle.version
bf61829 rename itest package
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
andreaturli commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
addressed this, @neykov thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
andreaturli commented on this pull request.
> @@ -82,7 +82,8 @@ limitations under the License.
-
${project.build.directory}/dependency-reduced-pom.xml
+
tested with that line reverted and it works as well. Can't remember
@andreaturli pushed 1 commit.
24dfa04 revert jsch-agentproxy-jsch pom.xml
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
andreaturli commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+
andreaturli commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+
andreaturli commented on this pull request.
> +jclouds-cloudsigma2-hnl
+jclouds-cloudsigma2-lvs
+jclouds-cloudsigma2-sjc
+jclouds-cloudsigma2-wdc
+
thank you, @iyovcheva
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/367#issuecomment-284778404
andreaturli commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+
@andreaturli pushed 1 commit.
9a27228 remove leftover obr resolver
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/24dfa04f8de0ae596d2903f9b325beb383e49692..9a27228938eb5578d9949932cbe7e896ecab3ad0
I tested the ssh-agent and it seems fine, I think it is finally good to merge
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1060#issuecomment-284216766
andreaturli commented on this pull request.
> @@ -179,8 +180,15 @@ public String apply(Status input) {
Credentials credentials = credentialStore.get("node#" +
virtualMachine.name());
builder.credentials(LoginCredentials.fromCredentials(credentials));
-
andreaturli commented on this pull request.
> @@ -179,8 +180,15 @@ public String apply(Status input) {
Credentials credentials = credentialStore.get("node#" +
virtualMachine.name());
builder.credentials(LoginCredentials.fromCredentials(credentials));
-
- add live test for update vm
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/368
-- Commit Summary --
* edit VirtualMachineApi.create to createOrUpdate
-- File Changes --
M
@andreaturli pushed 1 commit.
e894888 fix VirtualMachineApiMockTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/368/files/d70faedaf91454ff4f3fa6d98543f00f8056ffd5..e8948889bd7ecacf83ee492c352ad56c328e0e97
@andreaturli pushed 1 commit.
428c399 address @aledsage comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/368/files/1b0a2ee6a3bdf27235206817b3a02136d058..428c399ac6f308c6a166d056f2a9906852f81837
andreaturli commented on this pull request.
> @@ -88,11 +88,11 @@
@Path("/{vmname}")
@QueryParams(keys = "validating", values = "false")
@Produces(MediaType.APPLICATION_JSON)
- VirtualMachine create(@PathParam("vmname") String vmname,
-
@andreaturli pushed 1 commit.
d70faed update virtual machine api docs
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
thanks @nacx I will merge it to master and backport to 2.0.x
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/368#issuecomment-283966304
Closed #368.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/368#event-985463928
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6d68b285)
and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/b151914f)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli pushed 1 commit.
b568383 enable FeatureInstallationTests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@andreaturli pushed 1 commit.
78bee45 fix CreateOptions enum usage
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/372/files/88e4ac2274bc1e1879587afdad4c0fb5b00cca01..78bee45d867e0cbc93aaf881b7e86016760255fd
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e153322e)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322691343
thanks @cpanato! Glad to know you guys are using (and fixing) packet.net
provider
Please keep up with the great work, merging now!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
merged at
[jclouds-labs/2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/e4e8da3a)
too
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322719383
good question @nacx I'll try to apply it to jclouds-labs 2.0.x as well
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322714368
Closed #1130.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#event-1207790833
I think you can build `jclouds-plugin` using that commit or you can use daily
builds as described at http://jclouds.apache.org/start/install/. HTH
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Same here it is very surprising. I agree with @neykov the default should
probably be an isolated credentials store, and give the user the ability to
override if they really know what they are doing!
--
You are receiving this because you are subscribed to this thread.
Reply to this email
thanks @nacx let's wait for the builder as extra-check.
Meanwhile I'm rebasing and squashing
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315695894
Closed #1117.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#event-1166125075
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315703226
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315703315
merging to master only
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315707761
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/aa11765b)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315709952
@andreaturli pushed 1 commit.
848125a rename cleanupServer to cleanupResources
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
- wait for server deletion, before deleting the security group
I'd like this to be backported to 2.0.x as well
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1117
-- Commit Summary --
* [JCLOUDS-1318] fix based on
@andreaturli pushed 1 commit.
1133ddc openstack nova re-adding support for existing keypair
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
andreaturli commented on this pull request.
>if (templateOptions.getKeyPairName() != null) {
options.keyPairName(templateOptions.getKeyPairName());
- KeyPair keyPair =
keyPairCache.getIfPresent(RegionAndName.fromRegionAndName(template.getLocation().getId(),
andreaturli commented on this pull request.
> - .sharedNameForGroup(group)));
- keyPairCache.asMap().put(RegionAndName.fromRegionAndName(region,
keyPair.getName()), keyPair);
- templateOptions.keyPairName(keyPair.getName());
-
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315525532
andreaturli commented on this pull request.
> @@ -95,6 +101,7 @@ public Boolean apply(String id) {
}
boolean serverDeleted =
novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
+ checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed
andreaturli commented on this pull request.
> @@ -95,6 +101,7 @@ public Boolean apply(String id) {
}
boolean serverDeleted =
novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
+ checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed
@nacx I think the build issue is related to the PR, need to understand why
*AdapterExpectTest is soo slow now, I guess it's because the refactoring
involves somehow the injector
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
andreaturli commented on this pull request.
> }
+ } else if (templateOptions.getKeyPairName() != null &&
templateOptions.getLoginPrivateKey() != null) {
I was a bit unsure as well, I'll remove the extra check
--
You are receiving this because you are subscribed to this
andreaturli commented on this pull request.
>
- boolean keyPairExtensionPresent =
novaApi.getKeyPairApi(region).isPresent();
+ List inboundPorts =
Ints.asList(templateOptions.getInboundPorts());
+ if (!templateOptions.getGroups().isEmpty() && !inboundPorts.isEmpty()) {
Ops,
@andreaturli pushed 1 commit.
7080237 fix unit tests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1117/files/861275890d57f1488b28984dea49cc57f4db872e..7080237a8a3c8b123e3910ea37b21bbc96a922c8
andreaturli commented on this pull request.
> @@ -383,39 +391,94 @@ private OSProfile createOsProfile(String computerName,
> Template template) {
return builder.build();
}
- private NetworkInterfaceCard createNetworkInterfaceCard(String subnetId,
String name, String
andreaturli commented on this pull request.
> + deleteJobs.add(deleteManagedDisk(osDisk.managedDiskParameters()));
+
+ for (DataDisk dataDisk :
virtualMachine.properties().storageProfile().dataDisks()) {
+ deleteJobs.add(deleteManagedDisk(dataDisk.managedDiskParameters()));
+
thanks @nacx I really like the kind of flexibility jclouds azurecompute-arm can
gain with that!
couple of minor inital comments:
1. don't we need to deprecate `subnetId` and `virtualNetworkName` before
removing them, maybe?
2. with the second option `options.networks(subnetId2, subnetId2,
minor comment, not tested, but looks good to me
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/387#issuecomment-297547130
as per the irc discussion I agree those failures are mostly due to operation
timeout (maybe azure was slower than usual today?) so I think it is a v good
improvement overall!
+1
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
cool +1
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/387#issuecomment-297831883
andreaturli commented on this pull request.
this is very useful, @nacx !
Thanks, some minor initial comments.
I'll post the result of tests asap as well
>
- getOrCreateVirtualNetworkWithSubnet(location, options, azureGroupName);
- configureSecurityGroupForOptions(group,
think you need to rebase and then it should be good to merge
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/386#issuecomment-297854424
andreaturli commented on this pull request.
> +import static org.testng.Assert.assertEquals;
+
+import org.jclouds.azurecompute.arm.AzureComputeApi;
+import org.jclouds.azurecompute.arm.compute.options.AzureTemplateOptions;
+import org.jclouds.azurecompute.arm.compute.options.IpOptions;
+import
thanks for taking time to address my comments and give your opinion on jclouds
network @nacx
thanks @geomacy for the great comment on the multi nics scenario.
I'm still slightly concerned about giving multiple options using the template
options (portable and custom) to do something similar.
andreaturli commented on this pull request.
>
- getOrCreateVirtualNetworkWithSubnet(location, options, azureGroupName);
- configureSecurityGroupForOptions(group, azureGroupName,
template.getLocation(), options);
+ createResourceGroupIfNeeded(group, location, options);
I think
ok thanks guys, I've fixed an expected test, good to merge now?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#issuecomment-321174304
thanks @neykov, merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#issuecomment-321200716
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7c58f9d7)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#issuecomment-321216723
Closed #1128.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#event-1198830638
andreaturli commented on this pull request.
> for (String securityGroupName : templateOptions.getGroups()) {
-
checkNotNull(novaApi.getSecurityGroupApi(region).get().get(securityGroupName),
"security group %s doesn't exist", securityGroupName);
+
@andreaturli pushed 1 commit.
9d7f729 fix NovaComputeServiceExpectTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1128/files/69ded18e0f13f1b77d04d8d83225930561b11330..9d7f729be91d0973352ccbf758ccc30a38612001
This patch is to validate the `templateOption.securityGroups` passed by the
user. It accepts `securityGroupNames` as it uses to be before
https://github.com/jclouds/jclouds/pull/1117 cc @neykov @nacx
You can view, comment on, or merge this pull request online at:
andreaturli commented on this pull request.
thanks @jawnclarke it is really good start, some minor comments from me.
I'd like to understand better if we could avoid a generic `Response` for the
`create*` operations although the DimensionDataCloudControlResponseUtils is
well tested and may be
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1d4cb6c3) and
backported to
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/04ff09e6)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
thanks @neykov
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1110#issuecomment-307350491
previous failure looks unrelated, let's run the builder again before merging.
@neykov do you want this to be backported to 2.0.x as well?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1110#issuecomment-307338832
andreaturli commented on this pull request.
> @@ -191,14 +191,20 @@ public boolean removeSecurityGroup(String id) {
return false;
}
- if (sgApi.get().get(groupId) == null) {
- return false;
+ // Would be nice to delete the group and invalidate the cache
901 - 1000 of 1591 matches
Mail list logo
