[GitHub] [libcloud] micafer closed issue #1629: Add Server Groups functions in OpenStack driver

2021-12-02 Thread GitBox
micafer closed issue #1629: URL: https://github.com/apache/libcloud/issues/1629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[libcloud] branch trunk updated (97a417d -> fd4c285)

2021-12-02 Thread micafer
This is an automated email from the ASF dual-hosted git repository. micafer pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/libcloud.git. from 97a417d Merge pull request #1631 from Kami/revert_1584 new c41e27f Merge pull request #4 from micafer/ost_di

[GitHub] [libcloud] micafer merged pull request #1630: Add Server Groups functions in OpenStack driver

2021-12-02 Thread GitBox
micafer merged pull request #1630: URL: https://github.com/apache/libcloud/pull/1630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1630: Add Server Groups functions in OpenStack driver

2021-12-02 Thread GitBox
codecov-commenter edited a comment on pull request #1630: URL: https://github.com/apache/libcloud/pull/1630#issuecomment-981419756 # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[libcloud] branch trunk updated (4608765 -> 97a417d)

2021-12-02 Thread tomaz
This is an automated email from the ASF dual-hosted git repository. tomaz pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/libcloud.git. from 4608765 Add some developer docs on how to update node sizing and pricing data. new f342db3 Add a test case fo

[GitHub] [libcloud] Kami merged pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
Kami merged pull request #1631: URL: https://github.com/apache/libcloud/pull/1631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
codecov-commenter edited a comment on pull request #1631: URL: https://github.com/apache/libcloud/pull/1631#issuecomment-983895329 # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1631?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [libcloud] Kami commented on pull request #1630: Add Server Groups functions in OpenStack driver

2021-12-02 Thread GitBox
Kami commented on pull request #1630: URL: https://github.com/apache/libcloud/pull/1630#issuecomment-984980712 @micafer Not sure why those tests are failing. Could be a temporary issue since it works fine in other PRs (so re-run may help). -- This is an automated message from the Apache

[GitHub] [libcloud] Kami commented on pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
Kami commented on pull request #1631: URL: https://github.com/apache/libcloud/pull/1631#issuecomment-984901457 @louis-van-der-stam I added a simple benchmark which measures how much overhead sorting adds to that method - 230a094ab72ec0a6f8da76c5f31259240c034ae5. ![Screenshot from 202

[GitHub] [libcloud] Kami commented on pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
Kami commented on pull request #1631: URL: https://github.com/apache/libcloud/pull/1631#issuecomment-984859910 OK, I had a look and the approach I suggested above won't work so we are stuck with the current implementation and there isn't tons we can do to improve it. -- This is an autom

[GitHub] [libcloud] Kami edited a comment on pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
Kami edited a comment on pull request #1631: URL: https://github.com/apache/libcloud/pull/1631#issuecomment-984684135 @louis-van-der-stam Thanks for the info. I will add some micro-benchmarks when I get a chance, just to get some idea on the sorting overhead. But yeah, local storage

[GitHub] [libcloud] Kami commented on pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
Kami commented on pull request #1631: URL: https://github.com/apache/libcloud/pull/1631#issuecomment-984684135 @louis-van-der-stam Thanks for the info. I will add some micro-benchmarks when I get a chance, just to get some idea on the sorting overhead. But yeah, local storage driver

[GitHub] [libcloud] louis-van-der-stam commented on pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
louis-van-der-stam commented on pull request #1631: URL: https://github.com/apache/libcloud/pull/1631#issuecomment-984471805 > @louis-van-der-stam How many objects we are talking about? Should be pretty straight forward to write a micro-benchmark to see how much overhead it adds and if tha

[GitHub] [libcloud] Kami commented on pull request #1631: Fix object name prefix based filtering in the local storage driver

2021-12-02 Thread GitBox
Kami commented on pull request #1631: URL: https://github.com/apache/libcloud/pull/1631#issuecomment-984460273 @louis-van-der-stam How many objects we are talking about? Should be pretty straight forward to write a micro-benchmark to see how much overhead it adds and if that overhead is ne

[GitHub] [libcloud] micafer commented on pull request #1630: Add Server Groups functions in OpenStack driver

2021-12-02 Thread GitBox
micafer commented on pull request #1630: URL: https://github.com/apache/libcloud/pull/1630#issuecomment-984433508 Hi @Kami, Integration Tests are failing and the error seems that is not related with this PR. Any ideas? -- This is an automated message from the Apache Git Service. To