[jira] [Commented] (LOG4J2-3242) Limit JNDI to the java protocol only

2021-12-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465141#comment-17465141 ] ASF subversion and git services commented on LOG4J2-3242: - Commi

[GitHub] [logging-log4j2] remkop edited a comment on pull request #657: Api separation documentation

2021-12-24 Thread GitBox
remkop edited a comment on pull request #657: URL: https://github.com/apache/logging-log4j2/pull/657#issuecomment-1000967131 Would it make sense to include some of the images used in the FAQ on this page as well? For example: https://github.com/apache/logging-log4j2/blob/master/src/site

[GitHub] [logging-log4j2] remkop edited a comment on pull request #657: Api separation documentation

2021-12-24 Thread GitBox
remkop edited a comment on pull request #657: URL: https://github.com/apache/logging-log4j2/pull/657#issuecomment-1000967131 Would it make sense to include some of the images used in the FAQ on this page as well? For example: https://github.com/apache/logging-log4j2/blob/master/src/site

[GitHub] [logging-log4j2] remkop commented on pull request #657: Api separation documentation

2021-12-24 Thread GitBox
remkop commented on pull request #657: URL: https://github.com/apache/logging-log4j2/pull/657#issuecomment-1000967131 Would it make sense to include some of the images used in the FAQ on this page as well? For example: https://github.com/apache/logging-log4j2/blob/master/src/site/resour

[GitHub] [logging-log4j2] Gamebuster19901 commented on a change in pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
Gamebuster19901 commented on a change in pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775102137 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java ## @@ -168,6 +168,11 @@ private stati

[GitHub] [logging-log4j2] Gamebuster19901 commented on a change in pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
Gamebuster19901 commented on a change in pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775102029 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java ## @@ -168,6 +168,11 @@ private stati

[GitHub] [logging-log4j2] Gamebuster19901 commented on a change in pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
Gamebuster19901 commented on a change in pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775102029 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java ## @@ -168,6 +168,11 @@ private stati

[GitHub] [logging-log4j2] Marcono1234 commented on pull request #658: Fix tests not restoring system properties

2021-12-24 Thread GitBox
Marcono1234 commented on pull request #658: URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1000960051 The test failures seem to be unrelated to these changes; they are also occurring for `master`, e.g. [here](https://github.com/apache/logging-log4j2/runs/4628017826).

[GitHub] [logging-log4j2] Marcono1234 commented on a change in pull request #658: Fix tests not restoring system properties

2021-12-24 Thread GitBox
Marcono1234 commented on a change in pull request #658: URL: https://github.com/apache/logging-log4j2/pull/658#discussion_r775094711 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/Log4j1222Test.java ## @@ -34,8 +34,13 @@ @Test public void

[GitHub] [logging-log4j2] Marcono1234 opened a new pull request #658: Fix tests not restoring system properties

2021-12-24 Thread GitBox
Marcono1234 opened a new pull request #658: URL: https://github.com/apache/logging-log4j2/pull/658 Some tests were changing system properties, but were not reverting their changes. This pull request tries to address this issue. In some cases there were `System.setProperty(Constants.

[jira] [Commented] (LOG4J2-3288) Interpolator non-plugin codepath doesn't include all log4j-core lookups

2021-12-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465111#comment-17465111 ] Carter Kozak commented on LOG4J2-3288: -- There are several other places which use th

[jira] [Reopened] (LOG4J2-3288) Interpolator non-plugin codepath doesn't include all log4j-core lookups

2021-12-24 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers reopened LOG4J2-3288: - > Interpolator non-plugin codepath doesn't include all log4j-core lookups >

[jira] [Commented] (LOG4J2-3288) Interpolator non-plugin codepath doesn't include all log4j-core lookups

2021-12-24 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465110#comment-17465110 ] Ralph Goers commented on LOG4J2-3288: - Carter, I haven't yet looked at the patch but

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #653: (DRAFT, WIP - DO NOT MERGE YET, BUT INITIAL REVIEW WELCOME) Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

2021-12-24 Thread GitBox
garydgregory commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775084582 ## File path: pom.xml ## @@ -964,6 +964,19 @@ 0.8.1 test + +com.google.guava + +guava-te

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #653: (DRAFT, WIP - DO NOT MERGE YET, BUT INITIAL REVIEW WELCOME) Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

2021-12-24 Thread GitBox
carterkozak commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775083886 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Softw

[CI][UNSTABLE] Logging/log4j/release-2.x#545 has test failures

2021-12-24 Thread Mr. Jenkins
BUILD UNSTABLE Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/545/ Project: release-2.x Date of build: Fri, 24 Dec 2021 21:07:31 + Build duration: 1 hr 3 min and counting JUnit Tests Name: (root) Failed: 0 test(s), P

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #653: (DRAFT, WIP - DO NOT MERGE YET, BUT INITIAL REVIEW WELCOME) Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

2021-12-24 Thread GitBox
carterkozak commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775081486 ## File path: pom.xml ## @@ -964,6 +964,19 @@ 0.8.1 test + +com.google.guava + +guava-tes

[jira] [Commented] (LOGCXX-546) Multi threaded applications run at single threaded speed

2021-12-24 Thread Dr Stephen L S Webb (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465083#comment-17465083 ] Dr Stephen L S Webb commented on LOGCXX-546: The benchmark https://github.com

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #657: Api separation documentation

2021-12-24 Thread GitBox
carterkozak commented on a change in pull request #657: URL: https://github.com/apache/logging-log4j2/pull/657#discussion_r775080805 ## File path: src/site/markdown/api-separation.md ## @@ -0,0 +1,241 @@ + + + +# API Separation + +When selecting a logging library, some care mus

[GitHub] [logging-log4j2] rm5248 opened a new pull request #657: Api separation documentation

2021-12-24 Thread GitBox
rm5248 opened a new pull request #657: URL: https://github.com/apache/logging-log4j2/pull/657 Document the API separation of log4j2 and how to use it with other logging frameworks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] carterkozak opened a new pull request #656: [WIP] Interpolator always loads StrLookup plugins

2021-12-24 Thread GitBox
carterkozak opened a new pull request #656: URL: https://github.com/apache/logging-log4j2/pull/656 Previously a list of lookups was defined in code in parallel to those available from the PluginManager. The constuctor described these as lookups which don't require a LogEvent, howeve

[GitHub] [logging-log4j2] carterkozak commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
carterkozak commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000927711 When the recursion limit is hit, it's not clear whether we should return the original string, or avoid recursing further. Consider `java version: ${java:version}

[GitHub] [logging-log4j2] jvz commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
jvz commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000927476 FWIW, I think making a specific finite limit on recursion is easier to configure than relying on the stack size at runtime to run out of space. -- This is an automated messa

[GitHub] [logging-log4j2] garydgregory commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
garydgregory commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000926102 > I tend to agree with @carterkozak. According to my experience, these kind of measures have the potential to shadow the underlying problem. If the configuration has

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
garydgregory commented on a change in pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775075046 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java ## @@ -168,6 +168,11 @@ private static f

[GitHub] [logging-log4j2] Gamebuster19901 commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
Gamebuster19901 commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000924743 > I tend to agree with @carterkozak. According to my experience, these kind of measures have the potential to shadow the underlying problem. If the configuration h

[jira] [Commented] (LOG4J2-3271) When compiling 2.17.0 java8 error

2021-12-24 Thread slava (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465066#comment-17465066 ] slava commented on LOG4J2-3271: --- Thank you > When compiling 2.17.0 java8 error >

[GitHub] [logging-parent] jvz commented on pull request #3: define outputTimestamp for release to update

2021-12-24 Thread GitBox
jvz commented on pull request #3: URL: https://github.com/apache/logging-parent/pull/3#issuecomment-1000914945 Thanks for catching this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [logging-parent] jvz merged pull request #3: define outputTimestamp for release to update

2021-12-24 Thread GitBox
jvz merged pull request #3: URL: https://github.com/apache/logging-parent/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[jira] [Closed] (LOG4J2-3288) Interpolator non-plugin codepath doesn't include all log4j-core lookups

2021-12-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak closed LOG4J2-3288. > Interpolator non-plugin codepath doesn't include all log4j-core lookups > --

[jira] [Resolved] (LOG4J2-3288) Interpolator non-plugin codepath doesn't include all log4j-core lookups

2021-12-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak resolved LOG4J2-3288. -- Resolution: Fixed > Interpolator non-plugin codepath doesn't include all log4j-core lookups >

[jira] [Commented] (LOG4J2-3288) Interpolator non-plugin codepath doesn't include all log4j-core lookups

2021-12-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465063#comment-17465063 ] ASF subversion and git services commented on LOG4J2-3288: - Commi

[GitHub] [logging-log4j2] carterkozak merged pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups

2021-12-24 Thread GitBox
carterkozak merged pull request #655: URL: https://github.com/apache/logging-log4j2/pull/655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] garydgregory commented on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups

2021-12-24 Thread GitBox
garydgregory commented on pull request #655: URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000907893 Double woa ;-) thank you for the clarification :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [logging-log4j2] carterkozak edited a comment on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups

2021-12-24 Thread GitBox
carterkozak edited a comment on pull request #655: URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000906261 > Woa, aren't we missing unit tests that exercise those lookups? I think the issue is abundance of branches. The non-plugin constructor is used init

[GitHub] [logging-log4j2] carterkozak commented on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups

2021-12-24 Thread GitBox
carterkozak commented on pull request #655: URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000906261 > Woa, aren't we missing unit tests that exercise those lookups? I think the issue is abundance of branches. The non-plugin constructor is used initially w

[GitHub] [logging-log4j2] garydgregory commented on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups

2021-12-24 Thread GitBox
garydgregory commented on pull request #655: URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000905659 Woa, aren't we missing unit tests that exercise those lookups? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4j2] carterkozak opened a new pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups

2021-12-24 Thread GitBox
carterkozak opened a new pull request #655: URL: https://github.com/apache/logging-log4j2/pull/655 This adds missing lookups: `bundle`, `event`, and `sd` There's a comment suggesting that the PluginManager could be used, however that will require additional validation before I'm co

[jira] [Created] (LOG4J2-3288) Interpolator non-plugin codepath doesn't include all log4j-core lookups

2021-12-24 Thread Carter Kozak (Jira)
Carter Kozak created LOG4J2-3288: Summary: Interpolator non-plugin codepath doesn't include all log4j-core lookups Key: LOG4J2-3288 URL: https://issues.apache.org/jira/browse/LOG4J2-3288 Project: Log4

[jira] [Commented] (LOG4J2-3266) ${CTX :ThreadName} does not work

2021-12-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465056#comment-17465056 ] Carter Kozak commented on LOG4J2-3266: -- Not directly related to the reported proble

[jira] [Comment Edited] (LOG4J2-3278) SpringLookup log4j2 2.17.0 version Invalidation

2021-12-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465052#comment-17465052 ] Carter Kozak edited comment on LOG4J2-3278 at 12/24/21, 4:34 PM: -

[jira] [Commented] (LOG4J2-3278) SpringLookup log4j2 2.17.0 version Invalidation

2021-12-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465052#comment-17465052 ] Carter Kozak commented on LOG4J2-3278: -- I think this may actually be the same issue

[jira] [Comment Edited] (LOG4J2-3105) not able to deploy log4j-core-2.14.1 in weblogic12c

2021-12-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465051#comment-17465051 ] Gary D. Gregory edited comment on LOG4J2-3105 at 12/24/21, 4:31 PM: --

[jira] [Commented] (LOG4J2-3105) not able to deploy log4j-core-2.14.1 in weblogic12c

2021-12-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465051#comment-17465051 ] Gary D. Gregory commented on LOG4J2-3105: - [~vy] , [~esteve.blanch]  wrote/edite

[jira] [Commented] (LOG4J2-3286) 2.17 has reverted LOG4J-2972 fix in AppenderControl but change not in history

2021-12-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465049#comment-17465049 ] Carter Kozak commented on LOG4J2-3286: -- > _Isn't catching Throwable considered a ba

[GitHub] [logging-log4j2] garydgregory commented on pull request #654: define current build outputTimestamp

2021-12-24 Thread GitBox
garydgregory commented on pull request #654: URL: https://github.com/apache/logging-log4j2/pull/654#issuecomment-1000890828 I'll apply the same to release-2.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [logging-log4j2] garydgregory merged pull request #654: define current build outputTimestamp

2021-12-24 Thread GitBox
garydgregory merged pull request #654: URL: https://github.com/apache/logging-log4j2/pull/654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4cxx] swebb2066 edited a comment on pull request #87: Imported and slightly cleaned up throughput tests

2021-12-24 Thread GitBox
swebb2066 edited a comment on pull request #87: URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000882788 Your data shows the rate of disabled log calls for multithread case which should be near the single thread rate for each thread. I checked version 11 and the

[GitHub] [logging-log4j2] vy commented on pull request #642: Add Link to Release History

2021-12-24 Thread GitBox
vy commented on pull request #642: URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000890111 Hrm... I will do it myself. :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy closed pull request #642: Add Link to Release History

2021-12-24 Thread GitBox
vy closed pull request #642: URL: https://github.com/apache/logging-log4j2/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #642: Add Link to Release History

2021-12-24 Thread GitBox
vy commented on pull request #642: URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-100088 @KristjanESPERANTO, thanks for the contribution! This update needs to go into `announcement.vm` in `release-2.x` branch. -- This is an automated message from the Apache Git S

[jira] [Commented] (LOG4J2-3263) Incorrect documentation about Gradle

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465048#comment-17465048 ] Volkan Yazici commented on LOG4J2-3263: --- [~melix], thanks so much for the heads up

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #87: Imported and slightly cleaned up throughput tests

2021-12-24 Thread GitBox
swebb2066 commented on pull request #87: URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000882788 Your data shows the rate of disabled log calls for multithread case which should be near the single thread rate for each thread. On Dec 25, 2021 1:38 AM, Robert Mid

[jira] [Commented] (LOG4J2-3286) 2.17 has reverted LOG4J-2972 fix in AppenderControl but change not in history

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465046#comment-17465046 ] Volkan Yazici commented on LOG4J2-3286: --- _"Isn't catching Throwable considered a b

[jira] [Commented] (LOG4J2-3283) Add error-prone to build

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465044#comment-17465044 ] Volkan Yazici commented on LOG4J2-3283: --- Yes! I even have a ticket for that: LOG4J

[jira] [Resolved] (LOG4J2-3271) When compiling 2.17.0 java8 error

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3271. --- Resolution: Information Provided > When compiling 2.17.0 java8 error > -

[jira] [Updated] (LOG4J2-3268) do we have any work arround for issue LOG4J2-3230 for existing library.

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3268: -- Issue Type: Question (was: Bug) > do we have any work arround for issue LOG4J2-3230 for exist

[jira] [Resolved] (LOG4J2-3268) do we have any work arround for issue LOG4J2-3230 for existing library.

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3268. --- Resolution: Information Provided > do we have any work arround for issue LOG4J2-3230 for exi

[GitHub] [logging-log4j2] hboutemy opened a new pull request #654: define current build outputTimestamp

2021-12-24 Thread GitBox
hboutemy opened a new pull request #654: URL: https://github.com/apache/logging-log4j2/pull/654 see https://maven.apache.org/guides/mini/guide-reproducible-builds.html having a value defined here make it follow your releases, instead of having a value fixed by inheritance from parent -

[jira] [Updated] (LOG4J2-3266) ${CTX :ThreadName} does not work

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3266: -- Issue Type: Question (was: Bug) > ${CTX :ThreadName} does not work > --

[jira] [Commented] (LOG4J2-3266) ${CTX :ThreadName} does not work

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465043#comment-17465043 ] Volkan Yazici commented on LOG4J2-3266: --- I guess you need to inline {{fileName="$\

[jira] [Updated] (LOG4J2-3266) ${CTX :ThreadName} does not work

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3266: -- Priority: Minor (was: Critical) > ${CTX :ThreadName} does not work > --

[GitHub] [logging-parent] hboutemy opened a new pull request #3: define outputTimestamp for release to update

2021-12-24 Thread GitBox
hboutemy opened a new pull request #3: URL: https://github.com/apache/logging-parent/pull/3 see https://issues.apache.org/jira/browse/MRELEASE-1071 bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (LOG4J2-3265) CVE-2021-45105 fix for Java 7

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3265. --- Resolution: Fixed > CVE-2021-45105 fix for Java 7 > - > >

[jira] [Updated] (LOG4J2-3265) CVE-2021-45105 fix for Java 7

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3265: -- Fix Version/s: 2.12.3 > CVE-2021-45105 fix for Java 7 > - > >

[jira] [Closed] (LOG4J2-3265) CVE-2021-45105 fix for Java 7

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3265. - > CVE-2021-45105 fix for Java 7 > - > > Key: LOG4J2-3265

[jira] [Updated] (LOG4J2-3260) Missing branch protection settings on log4j2 repo

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3260: -- Attachment: 20211224-scorecard-report.txt > Missing branch protection settings on log4j2 r

[jira] [Updated] (LOG4J2-3260) Missing branch protection settings on log4j2 repo

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3260: -- Issue Type: Improvement (was: Bug) > Missing branch protection settings on log4j2 repo >

[jira] [Updated] (LOG4J2-3260) Missing branch protection settings on log4j2 repo

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3260: -- Priority: Trivial (was: Major) > Missing branch protection settings on log4j2 repo >

[GitHub] [logging-log4cxx] rm5248 commented on pull request #87: Imported and slightly cleaned up throughput tests

2021-12-24 Thread GitBox
rm5248 commented on pull request #87: URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000862347 I'll have to take a look at that; I would be surprised if that was a significant source of performance issues, but some testing would confirm that. FWIW, using the `LO

[jira] [Resolved] (LOG4J2-3262) Log4j 2.x mitigations for CVE-45046 is insufficient

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3262. --- Resolution: Fixed > Log4j 2.x mitigations for CVE-45046 is insufficient > --

[jira] [Commented] (LOG4J2-3262) Log4j 2.x mitigations for CVE-45046 is insufficient

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465041#comment-17465041 ] Volkan Yazici commented on LOG4J2-3262: --- Thanks so much for the heads up [~sivakum

[jira] [Commented] (LOG4J2-3105) not able to deploy log4j-core-2.14.1 in weblogic12c

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465038#comment-17465038 ] Volkan Yazici commented on LOG4J2-3105: --- [~imSiddharth], which Java version are yo

[GitHub] [logging-log4j2] vy commented on pull request #607: LOG4J2-3198: Log4j2 no longer formats lookups in messages by default

2021-12-24 Thread GitBox
vy commented on pull request #607: URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-1000859937 @SR-G, no, your use case is actually pretty common: feeding Log4j to ELK. Actually, we even have a layout to ease this process: `JsonTemplateLayout`. In a nutshell, it was only

[jira] [Commented] (LOG4J2-3261) Improve Configuration manual page

2021-12-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465037#comment-17465037 ] Gary D. Gregory commented on LOG4J2-3261: - I voted +1 in Jira :) > Improve Conf

[jira] [Commented] (LOG4J2-3261) Improve Configuration manual page

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465035#comment-17465035 ] Volkan Yazici commented on LOG4J2-3261: --- Great initiative [~rpopma]! Count me in f

[jira] [Assigned] (LOG4J2-3204) SpringLookup not found while Interpolator initializing

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici reassigned LOG4J2-3204: - Assignee: Volkan Yazici > SpringLookup not found while Interpolator initializing >

[jira] [Resolved] (LOG4J2-3204) SpringLookup not found while Interpolator initializing

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3204. --- Resolution: Fixed > SpringLookup not found while Interpolator initializing > ---

[jira] [Commented] (LOG4J2-3204) SpringLookup not found while Interpolator initializing

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465030#comment-17465030 ] Volkan Yazici commented on LOG4J2-3204: --- [~Francis_FY], I took the liberty of clos

[jira] [Closed] (LOG4J2-3204) SpringLookup not found while Interpolator initializing

2021-12-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3204. - > SpringLookup not found while Interpolator initializing > -

[GitHub] [logging-log4j2] vy commented on pull request #617: LOG4J2-3204 Correct SpringLookup package name in Interpolator.

2021-12-24 Thread GitBox
vy commented on pull request #617: URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-1000847776 Cherry-picked to `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (LOG4J2-3204) SpringLookup not found while Interpolator initializing

2021-12-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465028#comment-17465028 ] ASF subversion and git services commented on LOG4J2-3204: - Commi

[jira] [Commented] (LOG4J2-3204) SpringLookup not found while Interpolator initializing

2021-12-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465027#comment-17465027 ] ASF subversion and git services commented on LOG4J2-3204: - Commi

[jira] [Commented] (LOG4J2-3204) SpringLookup not found while Interpolator initializing

2021-12-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465024#comment-17465024 ] ASF subversion and git services commented on LOG4J2-3204: - Commi

[GitHub] [logging-log4j2] vy merged pull request #617: LOG4J2-3204 Correct SpringLookup package name in Interpolator.

2021-12-24 Thread GitBox
vy merged pull request #617: URL: https://github.com/apache/logging-log4j2/pull/617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #617: LOG4J2-3204 - Correct SpringLookup package name in Interpolator

2021-12-24 Thread GitBox
vy commented on pull request #617: URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-1000845984 LGTM. Thanks so much for the contribution @Francis-FY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] vy commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
vy commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000844140 I tend to agree with @carterkozak. According to my experience, these kind of measures have the potential to shadow the underlying problem. If the configuration has something du

[GitHub] [logging-log4j2] vy commented on a change in pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-24 Thread GitBox
vy commented on a change in pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775016870 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java ## @@ -168,6 +168,11 @@ private static final int B

[GitHub] [logging-log4j2] vy commented on a change in pull request #637: feat: lock feature by properties(PropertiesPropertySource order in properties)

2021-12-24 Thread GitBox
vy commented on a change in pull request #637: URL: https://github.com/apache/logging-log4j2/pull/637#discussion_r775014358 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesPropertySource.java ## @@ -29,15 +29,21 @@ private static final Stri

[CI][UNSTABLE] Logging/log4j/release-2.x#539 has test failures

2021-12-24 Thread Mr. Jenkins
BUILD UNSTABLE Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/539/ Project: release-2.x Date of build: Fri, 24 Dec 2021 10:15:50 + Build duration: 1 hr 29 min and counting JUnit Tests Name: (root) Failed: 0 test(s),

[jira] [Commented] (LOG4J2-3286) 2.17 has reverted LOG4J-2972 fix in AppenderControl but change not in history

2021-12-24 Thread Ben Thurley (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464998#comment-17464998 ] Ben Thurley commented on LOG4J2-3286: - [~ckozak] Thanks for looking at this, I can