atulpendse commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1006322842
I believe the failure in PropertiesConfigurationTest is unrelated to this
change, and being fixed with #685
Once that is fixed, how do I get this PR to build and run
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469683#comment-17469683
]
Remko Popma commented on LOG4J2-3297:
-
I would not disable this since it is the user
[
https://issues.apache.org/jira/browse/LOG4J2-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469676#comment-17469676
]
Ralph Goers commented on LOG4J2-3320:
-
All of our recommendations are listed at
[ht
[
https://issues.apache.org/jira/browse/LOG4J2-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469675#comment-17469675
]
Ralph Goers commented on LOG4J2-1540:
-
Not all classes in log4j-core are public, eve
[
https://issues.apache.org/jira/browse/LOG4J2-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers closed LOG4J2-3315.
---
Closing at user's request
> %X[key] is not working with bridge api ( Log4j 1.x bridge 2.15.0)
> ---
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469670#comment-17469670
]
Ralph Goers edited comment on LOG4J2-3297 at 1/6/22, 4:50 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469670#comment-17469670
]
Ralph Goers commented on LOG4J2-3297:
-
The action I am planning on taking with this
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469668#comment-17469668
]
Ralph Goers edited comment on LOG4J2-3297 at 1/6/22, 4:38 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469668#comment-17469668
]
Ralph Goers edited comment on LOG4J2-3297 at 1/6/22, 4:37 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469668#comment-17469668
]
Ralph Goers edited comment on LOG4J2-3297 at 1/6/22, 4:35 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469668#comment-17469668
]
Ralph Goers edited comment on LOG4J2-3297 at 1/6/22, 4:32 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469668#comment-17469668
]
Ralph Goers edited comment on LOG4J2-3297 at 1/6/22, 4:32 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469668#comment-17469668
]
Ralph Goers edited comment on LOG4J2-3297 at 1/6/22, 4:23 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469668#comment-17469668
]
Ralph Goers commented on LOG4J2-3297:
-
By default, Log4j looks for one of log42-test
swebb2066 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1006239373
It occurred to me that RVO is only relevent for functions that create the
returned object. getEffectiveLevel() returns the LevelPtr held by theLogger.
--
This is an aut
encryptomator created LOG4J2-3320:
-
Summary: log4j vulnerability / Mitigations
Key: LOG4J2-3320
URL: https://issues.apache.org/jira/browse/LOG4J2-3320
Project: Log4j 2
Issue Type: Bug
BUILD UNSTABLE
Build URL
https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/632/
Project:
release-2.x
Date of build:
Wed, 05 Jan 2022 23:38:55 +
Build duration:
1 hr 36 min and counting
JUnit Tests
Name: (root) Failed: 1 test(s),
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r779192252
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -45,21 +58,28 @@ class LOG4CXX_EXPORT LocationInfo
static co
[
https://issues.apache.org/jira/browse/LOG4J2-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469584#comment-17469584
]
Matt Sicker commented on LOG4J2-3310:
-
I think it probably is worth updating first.
garydgregory edited a comment on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006132805
Hi @vorburger
I'm not sure we need this: When I run `mvn apache-rat:check` in the root for
the project for release-2.x, it passes, and I have Eclipse dot fi
garydgregory commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006132805
I'm not sure we need this: When I run `mvn apache-rat:check` in the root for
the project for release-2.x, it passes, and I have Eclipse dot files all over
the place.
[
https://issues.apache.org/jira/browse/LOG4J2-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LOG4J2-3312.
-
Fix Version/s: 2.17.2
Resolution: Fixed
> Bridge does not convert properties
> --
garydgregory commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006128671
Hi @vorburger
I fixed the test differently in branches `release-2.x` and `master`.
--
This is an automated message from the Apache Git Service.
To respond to the
vorburger commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1006052585
This PR will fail to pass the CI build until the current known test failure
is fixed, see #685.
--
This is an automated message from the Apache Git Service.
To respond
vorburger edited a comment on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006050959
Indeed, now the CI failed on Mac (only) due to this.
To me this actually seems more like a bug in
`org.apache.commons.lang3.SystemUtils#getJavaIoTmpDir()` -
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006051522
> Not yet.
This PR is (only) about "Exclude Eclipse project file from RAT in root POM"
(and #685 is about the test failure).
--
This is an automated message fro
vorburger commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006050959
Indeed, now the CI failed on Mac (only) due to this.
To me this actually seems more like a bug in
`org.apache.commons.lang3.SystemUtils#getJavaIoTmpDir()` - it rea
[
https://issues.apache.org/jira/browse/LOG4J2-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469537#comment-17469537
]
Ryan Schmitt commented on LOG4J2-1540:
--
Why was a breaking change made to the const
vorburger opened a new pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686
See https://issues.apache.org/jira/browse/RAT-294,
and https://github.com/apache/logging-log4j2/pull/653.
--
This is an automated message from the Apache Git Service.
To respond to the
garydgregory commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006040596
> @garydgregory would you consider merging this PR, because the build test
failure is obviously not related to the small change made to the POM here?
Not yet.
vorburger commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1006040324
> @carterkozak the RAT failure is back again, and I'm not sure I understand
why, given I've only added 3 commits without
Please ignore, I'm tired and somehow mixe
garydgregory commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006030286
Note the config file has a / in it so you end up with two /
What is in the sys temp dir prop has a / at the end too IIRC in macOS at
least. AFK for a few hours.
BUILD UNSTABLE
Build URL
https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/627/
Project:
release-2.x
Date of build:
Wed, 05 Jan 2022 18:11:45 +
Build duration:
1 hr 39 min and counting
JUnit Tests
Name: (root) Failed: 0 test(s),
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006029579
@garydgregory would you consider merging this PR, because the build test
failure is obviously not related to the small change made to the POM here?
--
This is an autom
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006029158
> Hi, Rebase on master and it should work. I initially wrote the test on
macOS and later found it failed when I ran it on Windows.
But this is failing on the `rele
vorburger commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006028325
@garydgregory do you want to merge this when it passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vorburger opened a new pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685
This fixes the problem seen e.g. on #684.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
garydgregory commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006027274
> The [test failures
here](https://github.com/vorburger/logging-log4j2/runs/4718590938?check_suite_focus=true)
appears to be unrelated to this PR, looks like someone
vorburger commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1006005856
> make the Maven RAT plugin actually print out the offending files, instead
of pointing to a file where these are listed
As far as I can tell this isn't something
[
https://issues.apache.org/jira/browse/LOG4J2-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamlesh Silag resolved LOG4J2-3315.
---
Resolution: Not A Problem
> %X[key] is not working with bridge api ( Log4j 1.x bridge 2.15.0
[
https://issues.apache.org/jira/browse/LOG4J2-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469480#comment-17469480
]
Kamlesh Silag commented on LOG4J2-3315:
---
[~ggregory]. I found the solution to my p
vorburger commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1005988157
> It looks like our pom.xml has exclusions for `META-INF/services` in some
modules `src/main/resources/META-INF/services/**/*`, but I
think your solution is cleaner.
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1005987340
The [test failures
here](https://github.com/vorburger/logging-log4j2/runs/4718590938?check_suite_focus=true)
appears to be unrelated to this PR, looks like someone broke
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r779049362
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softwar
MouettE-SC edited a comment on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005973657
> Thanks for this. I should be able to create the unit tests for it.
Great ! I've added the tests I wrote, based on the current system property
ones with s
MouettE-SC commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005973657
> Thanks for this. I should be able to create the unit tests for it.
Great ! I've added the tests I wrote, based on the current system property
ones with system-r
[
https://issues.apache.org/jira/browse/LOG4J2-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469458#comment-17469458
]
Atul Pendse commented on LOG4J2-3280:
-
Pull request [LOG4J2-3280 - Add support for m
atulpendse opened a new pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683
This pull request is to imlement RFE LOG4J2-3280
The change
- Adds new attribute timestampPrecision to Rfc5424Layout and
SyslogAppender.
- Replaces existing logic to append timest
rgoers commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005915855
Thanks for this. I should be able to create the unit tests for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
BUILD UNSTABLE
Build URL
https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/626/
Project:
release-2.x
Date of build:
Wed, 05 Jan 2022 16:07:45 +
Build duration:
1 hr 2 min and counting
JUnit Tests
Name: (root) Failed: 0 test(s), P
[
https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469438#comment-17469438
]
Brian Martin commented on LOG4J2-3297:
--
To be clear, does Log4j load a remote confi
[
https://issues.apache.org/jira/browse/LOG4J2-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469418#comment-17469418
]
Ralph Goers commented on LOG4J2-3295:
-
I have a few ideas on how this could be addre
MouettE-SC opened a new pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682
This is a simple arbiter using environment variables functionnally based on
the existing system property arbiter (on which I corrected some typos).
I tried to write unit tests for it but
[
https://issues.apache.org/jira/browse/LOG4J2-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469414#comment-17469414
]
Gary D. Gregory commented on LOG4J2-3319:
-
Does Eclipse 4.22 fix this?
Do we ha
[
https://issues.apache.org/jira/browse/LOG4J2-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469413#comment-17469413
]
Benjamin Röhl commented on LOG4J2-3319:
---
Hi, it is version: 2021-09 (4.21.0)
> Ad
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r778937770
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softw
[
https://issues.apache.org/jira/browse/LOG4J2-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468423#comment-17468423
]
Mike Li edited comment on LOG4J2-3295 at 1/5/22, 1:08 PM:
--
Ralp
[
https://issues.apache.org/jira/browse/LOG4J2-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Röhl updated LOG4J2-3319:
--
Description:
h2. Status Quo
The "log4j core" and "log4j 1.2 api" library (and others as well)
[
https://issues.apache.org/jira/browse/LOG4J2-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469270#comment-17469270
]
Gary D. Gregory commented on LOG4J2-3319:
-
What version of Eclipse are you using
[
https://issues.apache.org/jira/browse/LOG4J2-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srinivasa Babu updated LOG4J2-3317:
---
Description:
Hello Sir,
Before upgrade my Route appenders with context pattern checks for d
Benjamin Röhl created LOG4J2-3319:
-
Summary: Add minimal support for log4j 1.2 API bundle usage in
Eclipse IDE
Key: LOG4J2-3319
URL: https://issues.apache.org/jira/browse/LOG4J2-3319
Project: Log4j 2
[
https://issues.apache.org/jira/browse/LOG4J2-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Freller closed LOG4J2-3318.
--
> SHA265 Checksum on Download Page not correct
>
>
>
[
https://issues.apache.org/jira/browse/LOG4J2-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Freller resolved LOG4J2-3318.
Resolution: Works for Me
> SHA265 Checksum on Download Page not correct
>
[
https://issues.apache.org/jira/browse/LOG4J2-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469142#comment-17469142
]
Thomas Freller commented on LOG4J2-3318:
Sorry my fault. I see it is a sha512 ha
Thomas Freller created LOG4J2-3318:
--
Summary: SHA265 Checksum on Download Page not correct
Key: LOG4J2-3318
URL: https://issues.apache.org/jira/browse/LOG4J2-3318
Project: Log4j 2
Issue Type
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r778642762
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -45,21 +58,28 @@ class LOG4CXX_EXPORT LocationInfo
s
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r778637752
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -45,21 +58,28 @@ class LOG4CXX_EXPORT LocationInfo
s
67 matches
Mail list logo
