[GitHub] [logging-log4j2] rgoers commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

2022-01-12 Thread GitBox
rgoers commented on pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1011817999 This scares the heck out of me. 1,995 files modified means no human could review this. Gary used to (still does?) use tools to do formatting and invariably would change a p

[GitHub] [logging-log4j2] garydgregory commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

2022-01-12 Thread GitBox
garydgregory commented on pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1011749927 FWIW, in Eclipse at least you can use a customizable comment to disable the formatted for specific areas like this: ... // @formatter:off ... // this

[jira] [Updated] (LOG4J2-3333) Classloader deadlock in ThreadContextDataInjector

2022-01-12 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Schmitt updated LOG4J2-: - Description: I ran into a deadlock involving {{ThreadContextDataInjector}} and the "Thread Cont

[jira] [Updated] (LOG4J2-3333) Classloader deadlock in ThreadContextDataInjector

2022-01-12 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Schmitt updated LOG4J2-: - Description: I ran into a deadlock involving {{ThreadContextDataInjector}} and the "Thread Cont

[jira] [Commented] (LOG4J2-3323) Breaking change in AbstractManager

2022-01-12 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475079#comment-17475079 ] Ryan Schmitt commented on LOG4J2-3323: -- We are now, I don't remember if it was out

[jira] [Created] (LOG4J2-3333) Classloader deadlock in ThreadContextDataInjector

2022-01-12 Thread Ryan Schmitt (Jira)
Ryan Schmitt created LOG4J2-: Summary: Classloader deadlock in ThreadContextDataInjector Key: LOG4J2- URL: https://issues.apache.org/jira/browse/LOG4J2- Project: Log4j 2 Issue Typ

[GitHub] [logging-log4j2] carterkozak opened a new pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

2022-01-12 Thread GitBox
carterkozak opened a new pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697 _This pr is meant only as an example for discussion_ What do you think about using a code formatter? In my experience, it makes reviews easier, avoids unnecessary style commits later on

[jira] [Commented] (LOG4J2-3323) Breaking change in AbstractManager

2022-01-12 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475022#comment-17475022 ] Gary D. Gregory commented on LOG4J2-3323: - Hi [~rschmitt]  Make sure guys are o

[jira] [Commented] (LOG4J2-3323) Breaking change in AbstractManager

2022-01-12 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474990#comment-17474990 ] Ryan Schmitt commented on LOG4J2-3323: -- I found this upgrade while mass-upgrading m

[jira] [Comment Edited] (LOG4J2-3323) Breaking change in AbstractManager

2022-01-12 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474990#comment-17474990 ] Ryan Schmitt edited comment on LOG4J2-3323 at 1/12/22, 10:16 PM: -

[jira] [Updated] (LOG4J2-3332) SmtpAppender: add capability to send buffered messages as an email attachment (text, zip, gzip)

2022-01-12 Thread Ron Grabowski (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Grabowski updated LOG4J2-3332: -- Description: Sending hundreds of buffered messages in an email body makes it difficult to vie

[jira] [Created] (LOG4J2-3332) SmtpAppender: add capability to send buffered messages as an email attachment (text, zip, gzip)

2022-01-12 Thread Ron Grabowski (Jira)
Ron Grabowski created LOG4J2-3332: - Summary: SmtpAppender: add capability to send buffered messages as an email attachment (text, zip, gzip) Key: LOG4J2-3332 URL: https://issues.apache.org/jira/browse/LOG4J2-3332

[jira] [Commented] (LOG4J2-1192) Dynamic Subject for SMTP Appender

2022-01-12 Thread Ron Grabowski (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474979#comment-17474979 ] Ron Grabowski commented on LOG4J2-1192: --- Support for dynamic subject was added wit

[GitHub] [logging-log4j2] MouettE-SC commented on pull request #682: Add environment variable arbiter

2022-01-12 Thread GitBox
MouettE-SC commented on pull request #682: URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1011391582 Let me know if there is anything I can do to help, like opening an issue on Jira, writing the documentation part or anything, I'll be happy to ! -- This is an automat

[GitHub] [logging-log4j2] MouettE-SC commented on pull request #682: Add environment variable arbiter

2022-01-12 Thread GitBox
MouettE-SC commented on pull request #682: URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1011384397 Sorry, forgot to comment that I was able to create working tests for the environment arbiter using system-lambda. Hope you'll find them satisfying ! -- This is an aut

[CI][SUCCESS] Logging/log4j/release-2.x#697 back to normal

2022-01-12 Thread Mr. Jenkins
BUILD SUCCESS Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/697/ Project: release-2.x Date of build: Wed, 12 Jan 2022 18:22:12 + Build duration: 1 hr 3 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Pa

[GitHub] [logging-log4j2] avandeursen opened a new pull request #696: Strengthen test coverage of StrSubstitutor class

2022-01-12 Thread GitBox
avandeursen opened a new pull request #696: URL: https://github.com/apache/logging-log4j2/pull/696 I noticed that the central `substitute` method in the `StrSubstitutor` class that was involved in a recent CVE had some code not covered by (unit) tests. This untested logic related to cases

[CI][UNSTABLE] Logging/log4j/release-2.x#696 has test failures

2022-01-12 Thread Mr. Jenkins
BUILD UNSTABLE Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/696/ Project: release-2.x Date of build: Wed, 12 Jan 2022 17:01:26 + Build duration: 1 hr 2 min and counting JUnit Tests Name: (root) Failed: 0 test(s), P

[jira] [Commented] (LOG4J2-3331) After upgrading version 2.13, the className and lineNumber cannot be obtained

2022-01-12 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474641#comment-17474641 ] Carter Kozak commented on LOG4J2-3331: -- Does your layout implement {{LocationAware}

[jira] [Created] (LOG4J2-3331) After upgrading version 2.13, the className and lineNumber cannot be obtained

2022-01-12 Thread Ning Ning Han (Jira)
Ning Ning Han created LOG4J2-3331: - Summary: After upgrading version 2.13, the className and lineNumber cannot be obtained Key: LOG4J2-3331 URL: https://issues.apache.org/jira/browse/LOG4J2-3331 Proje

[CI][UNSTABLE] Logging/log4j/release-2.x#695 has test failures

2022-01-12 Thread Mr. Jenkins
BUILD UNSTABLE Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/695/ Project: release-2.x Date of build: Wed, 12 Jan 2022 14:03:51 + Build duration: 1 hr 16 min and counting JUnit Tests Name: (root) Failed: 0 test(s),

[jira] [Commented] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474552#comment-17474552 ] ASF subversion and git services commented on LOG4J2-3330: - Commi

[jira] [Commented] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474551#comment-17474551 ] ASF subversion and git services commented on LOG4J2-3330: - Commi

[jira] [Resolved] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LOG4J2-3330. - Fix Version/s: 2.17.2 Resolution: Fixed > Configurator.setLevel not fetching the

[jira] [Commented] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474547#comment-17474547 ] ASF subversion and git services commented on LOG4J2-3330: - Commi

[jira] [Commented] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474546#comment-17474546 ] Gary D. Gregory commented on LOG4J2-3330: - [~mlemnaru]  Please try the git bran

[jira] [Comment Edited] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474497#comment-17474497 ] Gary D. Gregory edited comment on LOG4J2-3330 at 1/12/22, 1:34 PM: ---

[jira] [Commented] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474509#comment-17474509 ] ASF subversion and git services commented on LOG4J2-3330: - Commi

[jira] [Commented] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474510#comment-17474510 ] ASF subversion and git services commented on LOG4J2-3330: - Commi

[jira] [Commented] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474497#comment-17474497 ] Gary D. Gregory commented on LOG4J2-3330: - The problems applies to the following

[jira] [Work started] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LOG4J2-3330 started by Gary D. Gregory. --- > Configurator.setLevel not fetching the correct LoggerContext >

[jira] [Assigned] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory reassigned LOG4J2-3330: --- Assignee: Gary D. Gregory > Configurator.setLevel not fetching the correct LoggerCo

[jira] [Updated] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Mircea Lemnaru (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mircea Lemnaru updated LOG4J2-3330: --- Description: I needed to set the log level for a certain logger in the application and for

[jira] [Created] (LOG4J2-3330) Configurator.setLevel not fetching the correct LoggerContext

2022-01-12 Thread Mircea Lemnaru (Jira)
Mircea Lemnaru created LOG4J2-3330: -- Summary: Configurator.setLevel not fetching the correct LoggerContext Key: LOG4J2-3330 URL: https://issues.apache.org/jira/browse/LOG4J2-3330 Project: Log4j 2