[GitHub] [logging-log4j2] jnjanardhannaidu closed pull request #758: LOG4J2-3388 custom levels configured using log4j2.properies is giving number format exception.

2022-02-16 Thread GitBox
jnjanardhannaidu closed pull request #758: URL: https://github.com/apache/logging-log4j2/pull/758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Janardhan Naidu (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493676#comment-17493676 ] Janardhan Naidu edited comment on LOG4J2-3388 at 2/17/22, 6:45 AM: ---

[jira] [Commented] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Janardhan Naidu (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493676#comment-17493676 ] Janardhan Naidu commented on LOG4J2-3388: - Just changed the title with ticket number.  >

[GitHub] [logging-log4j2] jnjanardhannaidu commented on pull request #758: Update PropertiesConfigurationBuilder.java

2022-02-16 Thread GitBox
jnjanardhannaidu commented on pull request #758: URL: https://github.com/apache/logging-log4j2/pull/758#issuecomment-1042607739 LOG4J2-3388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Piotr P. Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493671#comment-17493671 ] Piotr P. Karwasz edited comment on LOG4J2-3388 at 2/17/22, 6:08 AM:

[jira] [Commented] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Piotr P. Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493671#comment-17493671 ] Piotr P. Karwasz commented on LOG4J2-3388: -- [~janardhan.naidu]: if you add {{[LOG4J2-3388]}} to

[jira] [Comment Edited] (LOG4J2-3297) Disable remote loading of log4j configuration to prevent MiTM Attacks

2022-02-16 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493662#comment-17493662 ] Ralph Goers edited comment on LOG4J2-3297 at 2/17/22, 5:43 AM: --- Loading

[jira] [Resolved] (LOG4J2-3297) Disable remote loading of log4j configuration to prevent MiTM Attacks

2022-02-16 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-3297. - Fix Version/s: 2.17.2 Resolution: Fixed Loading via a url is now restricted to https by

[jira] [Commented] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Janardhan Naidu (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493661#comment-17493661 ] Janardhan Naidu commented on LOG4J2-3388: - HI Team,  for the custom log level issue which I

[jira] [Commented] (LOG4J2-3297) Disable remote loading of log4j configuration to prevent MiTM Attacks

2022-02-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493659#comment-17493659 ] ASF subversion and git services commented on LOG4J2-3297: - Commit

[GitHub] [logging-log4j2] jnjanardhannaidu opened a new pull request #758: Update PropertiesConfigurationBuilder.java

2022-02-16 Thread GitBox
jnjanardhannaidu opened a new pull request #758: URL: https://github.com/apache/logging-log4j2/pull/758 if we have below properties configured in log4j2.properies files, when we will hit NumberFormatException or there will be no logs for custom level. This issue is happening because we

[jira] [Commented] (LOG4J2-3297) Disable remote loading of log4j configuration to prevent MiTM Attacks

2022-02-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493650#comment-17493650 ] ASF subversion and git services commented on LOG4J2-3297: - Commit

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #757: Bump maven-site-plugin from 3.8.2 to 3.11.0

2022-02-16 Thread GitBox
dependabot[bot] opened a new pull request #757: URL: https://github.com/apache/logging-log4j2/pull/757 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.8.2 to 3.11.0. Commits

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #755: trim MaxBackupIndex if last char is blank

2022-02-16 Thread GitBox
ppkarwasz commented on pull request #755: URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1042361172 @vy: shouldn't `max` be of type `Integer`, so that the injection framework takes care of the conversion? This would break the API, so can probably only be done in

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #756: [LOG4J2-3404] Creates default layouts using the available Configuration

2022-02-16 Thread GitBox
ppkarwasz commented on pull request #756: URL: https://github.com/apache/logging-log4j2/pull/756#issuecomment-1041943565 @carterkozak: that should do it. As far as I can see, no NPEs will result from providing `null` as configuration in the `PatternLayout`. I added a null check for

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #756: [LOG4J2-3404] Creates default layouts using the available Configuration

2022-02-16 Thread GitBox
ppkarwasz commented on a change in pull request #756: URL: https://github.com/apache/logging-log4j2/pull/756#discussion_r808247913 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java ## @@ -763,10 +762,7 @@ public Builder

[jira] [Commented] (LOG4J2-3393) JSON template layout performance regression

2022-02-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493319#comment-17493319 ] ASF subversion and git services commented on LOG4J2-3393: - Commit

[jira] [Commented] (LOG4J2-3404) Leak of DefaultConfiguration instances

2022-02-16 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493314#comment-17493314 ] Ralph Goers commented on LOG4J2-3404: - Yes, please provide a PR that demonstrates the problem and,

[jira] [Commented] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493313#comment-17493313 ] Ralph Goers commented on LOG4J2-3405: - Does the documentation need some help here? > LookupSupport

[GitHub] [logging-log4j2] vy commented on pull request #755: trim MaxBackupIndex if last char is blank

2022-02-16 Thread GitBox
vy commented on pull request #755: URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1041787442 @garydgregory I have indeed addressed this everywhere in `DefaultRolloverStrategy`. For practicing this throughout the entire code base, be my guest. :wink: -- This is an

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #756: [LOG4J2-3404] Creates default layouts using the available Configuration

2022-02-16 Thread GitBox
ppkarwasz commented on pull request #756: URL: https://github.com/apache/logging-log4j2/pull/756#issuecomment-1041594559 @carterkozak: I'll check if we can leave the `Configuration` as `null` and update the PR. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread Piotr P. Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493277#comment-17493277 ] Piotr P. Karwasz commented on LOG4J2-3405: -- The Spring lookup is actually already split into

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #756: [LOG4J2-3404] Creates default layouts using the available Configuration

2022-02-16 Thread GitBox
carterkozak commented on a change in pull request #756: URL: https://github.com/apache/logging-log4j2/pull/756#discussion_r808076590 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AbstractManager.java ## @@ -204,6 +204,13 @@ protected static

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #756: [LOG4J2-3404] Creates default layouts using the available Configuration

2022-02-16 Thread GitBox
ppkarwasz opened a new pull request #756: URL: https://github.com/apache/logging-log4j2/pull/756 When a default `PatternLayout` is created without a `Configuration` a new `DefaultConfiguration` is created and abandoned. This causes a leak of `ConsoleManager`s. This PR provides a

[jira] [Updated] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread member sound (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] member sound updated LOG4J2-3405: - Description: It would be great if Support Spring Boot

[jira] [Updated] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread member sound (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] member sound updated LOG4J2-3405: - Description: It would be great if Support Spring Boot

[jira] [Updated] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread member sound (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] member sound updated LOG4J2-3405: - Description: It would be great if Support Spring Boot

[jira] [Updated] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread member sound (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] member sound updated LOG4J2-3405: - Description: It would be great if Support Spring Boot

[jira] [Updated] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread member sound (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] member sound updated LOG4J2-3405: - Description: It would be great if Support Spring Boot

[jira] [Created] (LOG4J2-3405) LookupSupport Spring Boot without Cloud BusBridge

2022-02-16 Thread member sound (Jira)
member sound created LOG4J2-3405: Summary: LookupSupport Spring Boot without Cloud BusBridge Key: LOG4J2-3405 URL: https://issues.apache.org/jira/browse/LOG4J2-3405 Project: Log4j 2 Issue

[jira] [Commented] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Janardhan Naidu (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493212#comment-17493212 ] Janardhan Naidu commented on LOG4J2-3388: - I am using log4j 2.17.1 version.  > Migration from

[jira] [Commented] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Janardhan Naidu (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493211#comment-17493211 ] Janardhan Naidu commented on LOG4J2-3388: - [~ggregory] , No. there is no whitespaces after 525

[jira] [Commented] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493208#comment-17493208 ] Gary D. Gregory commented on LOG4J2-3388: - Do you have whitespace at the end of the lines in the

[jira] [Comment Edited] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Janardhan Naidu (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493196#comment-17493196 ] Janardhan Naidu edited comment on LOG4J2-3388 at 2/16/22, 12:08 PM:

[jira] [Commented] (LOG4J2-3388) Migration from log4j1.x to log4j2.x

2022-02-16 Thread Janardhan Naidu (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493196#comment-17493196 ] Janardhan Naidu commented on LOG4J2-3388: - HI,    I am now migrating to log4j2.x, now facing

[jira] [Updated] (LOG4J2-3404) Leak of DefaultConfiguration instances

2022-02-16 Thread Piotr P. Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr P. Karwasz updated LOG4J2-3404: - Description: If an appender does not specify a layout a default {{PatternLayout}} is

[jira] [Created] (LOG4J2-3404) Leak of DefaultConfiguration instances

2022-02-16 Thread Piotr P. Karwasz (Jira)
Piotr P. Karwasz created LOG4J2-3404: Summary: Leak of DefaultConfiguration instances Key: LOG4J2-3404 URL: https://issues.apache.org/jira/browse/LOG4J2-3404 Project: Log4j 2 Issue Type:

[GitHub] [logging-log4j2] garydgregory commented on pull request #755: trim MaxBackupIndex if last char is blank

2022-02-16 Thread GitBox
garydgregory commented on pull request #755: URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1041405005 Just a second... would it not be better to look for all call sites and refactor this kind of convertion into an internal utility? -- This is an automated message

[jira] [Commented] (LOG4J2-3403) java.lang.ClassNotFoundException: org.slf4j.bridge.SLF4JBridgeHandler

2022-02-16 Thread Jitin Dominic (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493148#comment-17493148 ] Jitin Dominic commented on LOG4J2-3403: --- [~ppkarwasz] Thank you for confirmation. >

[jira] [Resolved] (LOG4J2-3403) java.lang.ClassNotFoundException: org.slf4j.bridge.SLF4JBridgeHandler

2022-02-16 Thread Jitin Dominic (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jitin Dominic resolved LOG4J2-3403. --- Resolution: Fixed > java.lang.ClassNotFoundException: org.slf4j.bridge.SLF4JBridgeHandler >

[GitHub] [logging-log4j2] vy merged pull request #755: trim MaxBackupIndex if last char is blank

2022-02-16 Thread GitBox
vy merged pull request #755: URL: https://github.com/apache/logging-log4j2/pull/755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: