[GitHub] [logging-log4j2] dfa1 commented on pull request #770: Initial support for detached markers in SLF4J binding

2022-02-21 Thread GitBox
dfa1 commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1047476853 @garydgregory thank you for the review... please have a look now, I wrote few unit tests -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (LOG4J2-3410) Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String keys

2022-02-21 Thread Barry Sham (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495819#comment-17495819 ] Barry Sham edited comment on LOG4J2-3410 at 2/22/22, 1:58 AM: -- Dear

[jira] [Commented] (LOG4J2-3410) Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String keys

2022-02-21 Thread Barry Sham (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495819#comment-17495819 ] Barry Sham commented on LOG4J2-3410: Dear [~ggregory] and [~ppkarwasz], We updated our testing repo

[GitHub] [logging-log4cxx] LeeGDavis commented on pull request #105: Prevent static initialization order faults by using local statics

2022-02-21 Thread GitBox
LeeGDavis commented on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1047317100 Thanks @rm5248. I'll give that a try. I'll see what I can do about a test case too. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [logging-log4cxx] rm5248 commented on pull request #105: Prevent static initialization order faults by using local statics

2022-02-21 Thread GitBox
rm5248 commented on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1047304623 You could try using a vcpkg overlay to build a custom version of log4cxx. See the [vcpkg

[GitHub] [logging-log4cxx] LeeGDavis commented on pull request #105: Prevent static initialization order faults by using local statics

2022-02-21 Thread GitBox
LeeGDavis commented on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1047299349 I think we're running into this issue after and upgrade to 0.12.1 from 0.11.0. Is there any way to tests this or what is currently in

[GitHub] [logging-chainsaw] rm5248 opened a new pull request #11: Remove log4j1

2022-02-21 Thread GitBox
rm5248 opened a new pull request #11: URL: https://github.com/apache/logging-chainsaw/pull/11 Remove the hard dependency on log4j1. General changes: - Removed database stuff for the time being - Created a new `ChainsawLoggingEvent` to be independent of log4j1 - Changed

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #769: Slf4j binding minor cleanups

2022-02-21 Thread GitBox
garydgregory commented on a change in pull request #769: URL: https://github.com/apache/logging-log4j2/pull/769#discussion_r811446174 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMDCAdapter.java ## @@ -52,8 +52,7 @@ public void clear() { }

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #769: Slf4j binding minor cleanups

2022-02-21 Thread GitBox
dfa1 commented on a change in pull request #769: URL: https://github.com/apache/logging-log4j2/pull/769#discussion_r811438451 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMDCAdapter.java ## @@ -52,8 +52,7 @@ public void clear() { }

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #769: Slf4j binding minor cleanups

2022-02-21 Thread GitBox
dfa1 commented on a change in pull request #769: URL: https://github.com/apache/logging-log4j2/pull/769#discussion_r811438451 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMDCAdapter.java ## @@ -52,8 +52,7 @@ public void clear() { }

[GitHub] [logging-log4j2] garydgregory commented on pull request #770: Initial support for detached markers in SLF4J binding

2022-02-21 Thread GitBox
garydgregory commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1047241499 Hi @dfa1 Thank you for the PR. You will need to add tests to this PR to prove the code does what you say it does. -- This is an automated message from the

[GitHub] [logging-log4j2] dfa1 opened a new pull request #770: Initial support for detached markers in SLF4J binding

2022-02-21 Thread GitBox
dfa1 opened a new pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770 Hello all, please accept this small patch from a long time user of log4j: it will enable using log4j 2.x in several applications here at @six-group! This proposal allows creating

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #769: Slf4j binding minor cleanups

2022-02-21 Thread GitBox
garydgregory commented on a change in pull request #769: URL: https://github.com/apache/logging-log4j2/pull/769#discussion_r811434361 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMDCAdapter.java ## @@ -52,8 +52,7 @@ public void clear() { }

[jira] [Commented] (LOG4J2-3393) JSON template layout performance regression

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495763#comment-17495763 ] ASF subversion and git services commented on LOG4J2-3393: - Commit

[jira] [Commented] (LOG4J2-3393) JSON template layout performance regression

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495764#comment-17495764 ] ASF subversion and git services commented on LOG4J2-3393: - Commit

[GitHub] [logging-log4j2] dfa1 opened a new pull request #769: Slf4j binding minor cleanups

2022-02-21 Thread GitBox
dfa1 opened a new pull request #769: URL: https://github.com/apache/logging-log4j2/pull/769 Minor cleanups in SLF4J bindings Including removal of [SLF4JLoggingException](https://github.com/apache/logging-log4j2/commit/d993a4faf17c1e5380e0eb87c02ee9d69318eb68) -- This is an

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #768: Improves behavior of failing Log4j 1.x builders

2022-02-21 Thread GitBox
ppkarwasz opened a new pull request #768: URL: https://github.com/apache/logging-log4j2/pull/768 If a Builder fails due to a missing property, it return `null`. This activates the fallback _"instantiate by class name"_ mechanism that will fail with `NoClassDefFoundException` in the best

[GitHub] [logging-log4j2] garydgregory commented on pull request #764: Log4j 1.2 bridge supports global threshold

2022-02-21 Thread GitBox
garydgregory commented on pull request #764: URL: https://github.com/apache/logging-log4j2/pull/764#issuecomment-1047183989 @ppkarwasz Thank you for your PR. If you are looking for more fixes to investigate, please have a look at the disabled tests in

[GitHub] [logging-log4j2] garydgregory merged pull request #764: Adds Log4j 1.x global threshold

2022-02-21 Thread GitBox
garydgregory merged pull request #764: URL: https://github.com/apache/logging-log4j2/pull/764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LOG4J2-3407) PropertiesConfiguration.parseAppender NPE when logger refers to non-existent appender

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495733#comment-17495733 ] ASF subversion and git services commented on LOG4J2-3407: - Commit

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #767: Provide a uniform Log4j 1.x message factory

2022-02-21 Thread GitBox
ppkarwasz commented on a change in pull request #767: URL: https://github.com/apache/logging-log4j2/pull/767#discussion_r811369316 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/SortedArrayStringMap.java ## @@ -128,6 +128,21 @@ private boolean

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #767: [LOG4J2-3410] Fix ClassCastException when key is not a string

2022-02-21 Thread GitBox
garydgregory commented on a change in pull request #767: URL: https://github.com/apache/logging-log4j2/pull/767#discussion_r811358091 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/SortedArrayStringMap.java ## @@ -128,6 +128,21 @@ private boolean

[jira] [Resolved] (LOG4J2-3407) PropertiesConfiguration.parseAppender NPE when logger refers to non-existent appender

2022-02-21 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LOG4J2-3407. - Fix Version/s: 2.17.2 Resolution: Fixed [~kennymacleod.atl]  In git branch

[GitHub] [logging-log4j2] garydgregory merged pull request #761: LOG4J2-3407 Log4j 1.2 bridge Check for non-existent appender when parsing properties

2022-02-21 Thread GitBox
garydgregory merged pull request #761: URL: https://github.com/apache/logging-log4j2/pull/761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LOG4J2-3407) PropertiesConfiguration.parseAppender NPE when logger refers to non-existent appender

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495621#comment-17495621 ] ASF subversion and git services commented on LOG4J2-3407: - Commit

[jira] [Resolved] (LOG4J2-3410) Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String keys

2022-02-21 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LOG4J2-3410. - Fix Version/s: 2.17.2 Resolution: Fixed Hi [~bcfsham] , Thank you for reporting

[jira] [Commented] (LOG4J2-3410) Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String keys

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495617#comment-17495617 ] ASF subversion and git services commented on LOG4J2-3410: - Commit

[jira] [Work started] (LOG4J2-3410) Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String keys

2022-02-21 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LOG4J2-3410 started by Gary D. Gregory. --- > Log4j 1.2 bridge throws a ClassCastException when logging a Map with

[jira] [Assigned] (LOG4J2-3410) Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String keys

2022-02-21 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory reassigned LOG4J2-3410: --- Assignee: Gary D. Gregory > Log4j 1.2 bridge throws a ClassCastException when

[jira] [Updated] (LOG4J2-3410) Log4j 1.x Compatibility API - ClassCastException when logging a Map with non-String keys

2022-02-21 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LOG4J2-3410: Summary: Log4j 1.x Compatibility API - ClassCastException when logging a Map with

[jira] [Updated] (LOG4J2-3410) Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String keys

2022-02-21 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LOG4J2-3410: Summary: Log4j 1.2 bridge throws a ClassCastException when logging a Map with non-String

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #767: [LOG4J2-3410] Fix ClassCastException when key is not a string

2022-02-21 Thread GitBox
ppkarwasz commented on a change in pull request #767: URL: https://github.com/apache/logging-log4j2/pull/767#discussion_r811231397 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/Category.java ## @@ -309,15 +309,10 @@ private void fireRemoveAppenderEvent(final

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #767: [LOG4J2-3410] Fix ClassCastException when key is not a string

2022-02-21 Thread GitBox
ppkarwasz opened a new pull request #767: URL: https://github.com/apache/logging-log4j2/pull/767 This PR provides a `MessageFactory` that decides the type of message based on the runtime type of the logged object (cf. [LOG4J2-3080](https://issues.apache.org/jira/browse/LOG4J2-3080)).

[jira] [Commented] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng

2022-02-21 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495574#comment-17495574 ] Ralph Goers commented on LOG4J2-3409: - I had hoped it would have been out weeks ago, but after so

[jira] [Commented] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng

2022-02-21 Thread alexander kravchik (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495563#comment-17495563 ] alexander kravchik commented on LOG4J2-3409: ok great news - do you have estimation when it

[jira] [Commented] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng

2022-02-21 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495528#comment-17495528 ] Ralph Goers commented on LOG4J2-3409: - The thing is, once Flume 1.10.0 is released Log4J will

[GitHub] [logging-log4j2] ruhulmus edited a comment on pull request #763: Added java logging with Asynchronous logger

2022-02-21 Thread GitBox
ruhulmus edited a comment on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046775984 > @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-02-21 Thread GitBox
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046775984 > @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the

[jira] [Commented] (LOG4J2-3389) Log42j: Provide the capability to Rollover all appenders in an application on Shutdown

2022-02-21 Thread Brian Antao (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495446#comment-17495446 ] Brian Antao commented on LOG4J2-3389: - It would be nice to have OnShutdownTriggeringPolicy be

[jira] [Commented] (LOG4J2-3410) Log4j 1.x Compatibility API - ClassCastException when logging MultiKeyMap

2022-02-21 Thread Piotr P. Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495444#comment-17495444 ] Piotr P. Karwasz commented on LOG4J2-3410: -- To me it also seems like a bug in

[GitHub] [logging-parent] dependabot[bot] closed pull request #2: Bump apache from 23 to 24

2022-02-21 Thread GitBox
dependabot[bot] closed pull request #2: URL: https://github.com/apache/logging-parent/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-parent] dependabot[bot] commented on pull request #2: Bump apache from 23 to 24

2022-02-21 Thread GitBox
dependabot[bot] commented on pull request #2: URL: https://github.com/apache/logging-parent/pull/2#issuecomment-1046688982 Superseded by #4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-parent] dependabot[bot] opened a new pull request #4: Bump apache from 24 to 25

2022-02-21 Thread GitBox
dependabot[bot] opened a new pull request #4: URL: https://github.com/apache/logging-parent/pull/4 Bumps [apache](https://github.com/apache/maven-apache-parent) from 24 to 25. Commits See full diff in https://github.com/apache/maven-apache-parent/commits;>compare view

[jira] [Commented] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng

2022-02-21 Thread alexander kravchik (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495413#comment-17495413 ] alexander kravchik commented on LOG4J2-3409: Hi Matt & Ralph, I opened the issue on log4j

[jira] [Created] (LOG4J2-3410) Log4j 1.x Compatibility API - ClassCastException when logging MultiKeyMap

2022-02-21 Thread Barry Sham (Jira)
Barry Sham created LOG4J2-3410: -- Summary: Log4j 1.x Compatibility API - ClassCastException when logging MultiKeyMap Key: LOG4J2-3410 URL: https://issues.apache.org/jira/browse/LOG4J2-3410 Project: Log4j

[GitHub] [logging-log4j2] vy merged pull request #766: Bump kubernetes-client from 4.6.1 to 5.12.1

2022-02-21 Thread GitBox
vy merged pull request #766: URL: https://github.com/apache/logging-log4j2/pull/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4j2] vy commented on pull request #750: Bump liquibase-core from 3.5.5 to 3.10.3

2022-02-21 Thread GitBox
vy commented on pull request #750: URL: https://github.com/apache/logging-log4j2/pull/750#issuecomment-1046619861 @garydgregory see #503 for some more context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL