[GitHub] [logging-log4j2] jochenw commented on pull request #787: [LOG4J2-3427] Add a ServiceLoader tool

2022-03-06 Thread GitBox
jochenw commented on pull request #787: URL: https://github.com/apache/logging-log4j2/pull/787#issuecomment-1060283020 Shouldn't the dependency junit-pioneer have test scope? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (LOG4J2-3416) Line Number Not getting printeed

2022-03-06 Thread Sagar Salal (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502114#comment-17502114 ] Sagar Salal commented on LOG4J2-3416: - [~rgoers] Did you get time to see this? > Line Number Not

[GitHub] [logging-log4j2] pooja-achievement commented on pull request #786: [LOG4J2-3426] Refactors wrapping code

2022-03-06 Thread GitBox
pooja-achievement commented on pull request #786: URL: https://github.com/apache/logging-log4j2/pull/786#issuecomment-1060245397 @ppkarwasz, Hi Piotr, I am not building log4j2 1.x bridge jars but downloading the jar. I wanted to test with this Pull Request changes, is it

[jira] [Commented] (LOG4J2-3419) Unable to create custom logging level using log4j 2 Bridge API

2022-03-06 Thread Ragini Gawande (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502083#comment-17502083 ] Ragini Gawande commented on LOG4J2-3419: [~ggregory] / [~rgoers]  Following is the GitHub link

[GitHub] [logging-log4j2] jvz commented on a change in pull request #744: [LOG4J2-2803] Create standardized dependency injection API

2022-03-06 Thread GitBox
jvz commented on a change in pull request #744: URL: https://github.com/apache/logging-log4j2/pull/744#discussion_r820151542 ## File path: log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/di/ReflectiveCallerContext.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the

[GitHub] [logging-log4j2] andrei-ivanov commented on a change in pull request #745: [LOG4J2-3362] Adds a SmtpManager compatible with Jakarta EE 9

2022-03-06 Thread GitBox
andrei-ivanov commented on a change in pull request #745: URL: https://github.com/apache/logging-log4j2/pull/745#discussion_r820284822 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java ## @@ -39,14 +39,15 @@ public class

[jira] [Commented] (LOG4J2-3425) Syslog appender lacks the SocketOptions setting

2022-03-06 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502006#comment-17502006 ] Gary D. Gregory commented on LOG4J2-3425: - I think we should close this ticket and open a new

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #787: [LOG4J2-3427] Add a ServiceLoader tool

2022-03-06 Thread GitBox
ppkarwasz opened a new pull request #787: URL: https://github.com/apache/logging-log4j2/pull/787 This adds a `ServiceLoader` which: * automatically discards service classes, which can not be instantiated (e.g. classes in the server's classloader of a servlet container), from the

[jira] [Created] (LOG4J2-3427) ServiceLoader usage in a servlet environment

2022-03-06 Thread Piotr Karwasz (Jira)
Piotr Karwasz created LOG4J2-3427: - Summary: ServiceLoader usage in a servlet environment Key: LOG4J2-3427 URL: https://issues.apache.org/jira/browse/LOG4J2-3427 Project: Log4j 2 Issue Type:

[jira] [Commented] (LOG4J2-3426) Log4j 1.x bridge Logger.getAppender returns a wrapped AppenderAdapter

2022-03-06 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501924#comment-17501924 ] Piotr Karwasz commented on LOG4J2-3426: --- [~PoojaTheCoder], are you using any filters on your

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #786: [LOG4J2-3426] Refactors wrapping code

2022-03-06 Thread GitBox
ppkarwasz commented on a change in pull request #786: URL: https://github.com/apache/logging-log4j2/pull/786#discussion_r820202030 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/Category.java ## @@ -376,7 +376,7 @@ public Appender getAppender(final String name) {

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #786: [LOG4J2-3426] Refactors wrapping code

2022-03-06 Thread GitBox
ppkarwasz commented on a change in pull request #786: URL: https://github.com/apache/logging-log4j2/pull/786#discussion_r820201779 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/FileAppenderBuilder.java ## @@ -125,21 +125,16 @@ public Appender

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #786: [LOG4J2-3426] Refactors wrapping code

2022-03-06 Thread GitBox
ppkarwasz opened a new pull request #786: URL: https://github.com/apache/logging-log4j2/pull/786 Refactors the wrapping logic into single `wrap` or `adapt` methods to be sure we always perform the correct logic. -- This is an automated message from the Apache Git Service. To respond to