rgoers edited a comment on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073168934
@dfa1 I do understand your dilemma. You already have existing code that has
implemented this in the only way possible using SLF4J, which is a hack,
However, I have
rgoers commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073168934
@dfa1 I do understand your dilemma. You already have existing code that has
implemented this in the only way possible using SLF4J, which is a hack,
However, I have a real
[
https://issues.apache.org/jira/browse/LOG4J2-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509340#comment-17509340
]
Matt Sicker commented on LOG4J2-3439:
-
A safe default could be TLSv1.2, though TLSv1.3 is the _true_
dfa1 edited a comment on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073049642
@rgoers @carterkozak @garydgregory
*Current state*
- this PR is implementing the SLF4J's contract in a reasonable way (my
humble opinion)
- test
dfa1 commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073049642
@rgoers @carterkozak @garydgregory
*Current state*
- this PR is implementing the SLF4J's contract is a reasonable way (my
humble opinion)
- test coverage
dfa1 commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073047035
@rgoers @garydgregory thank you for the feedback ;)
Actually we already have a lot of internal libraries and frameworks written
against `slf4j-api`, and we do the
rgoers commented on a change in pull request #804:
URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830502914
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java
##
@@ -110,28 +139,64 @@ private ServiceLoaderUtil() {
rgoers commented on a change in pull request #804:
URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830502914
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java
##
@@ -110,28 +139,64 @@ private ServiceLoaderUtil() {
[
https://issues.apache.org/jira/browse/LOGCXX-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton updated LOGCXX-550:
Fix Version/s: 0.13.0
> Add ability to get thread name not just ID
>
[
https://issues.apache.org/jira/browse/LOGCXX-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on LOGCXX-550 started by Robert Middleton.
---
> Add ability to get thread name not just ID
>
[
https://issues.apache.org/jira/browse/LOGCXX-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton resolved LOGCXX-525.
-
Resolution: Fixed
> Compressing log files does not create directories
>
[
https://issues.apache.org/jira/browse/LOGCXX-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton resolved LOGCXX-529.
-
Resolution: Fixed
> Support color and highlight conversion patterns
>
[
https://issues.apache.org/jira/browse/LOGCXX-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509284#comment-17509284
]
Robert Middleton commented on LOGCXX-551:
-
So at least part of the reason for this is that the
[
https://issues.apache.org/jira/browse/LOGCXX-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton updated LOGCXX-551:
Fix Version/s: 0.13.0
> CMake documented build option for Boost vs C++17 Implementation
[
https://issues.apache.org/jira/browse/LOGCXX-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton reassigned LOGCXX-551:
---
Assignee: Robert Middleton
> CMake documented build option for Boost vs C++17
garydgregory commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072998257
I have a product at work that does almost exactly what @rgoers describes, it
works great, it's clean, and easy enough to understand. I encourage you as well
to move
rgoers edited a comment on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072974525
Ok. So your big mistake here is trying to do this with the SLF4J API. It
wasn't designed to support structured event logging. I fought for that years
ago and gave
ppkarwasz commented on a change in pull request #804:
URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830463798
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java
##
@@ -110,28 +139,64 @@ private ServiceLoaderUtil() {
rgoers edited a comment on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072974525
Ok. So your big mistake here is trying to do this with the SLF4J API. It
wasn't designed to support structured event logging. I fought for that years
ago and gave
[
https://issues.apache.org/jira/browse/LOG4J2-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509201#comment-17509201
]
Piotr Karwasz commented on LOG4J2-3439:
---
[~rgoers],
I never checked on old Java versions, but on
rgoers commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072974525
Ok. So your big mistake here is trying to do this with the SLF4J API. It
wasn't designed to support structured event logging. I fought for that years
ago and gave up and
dfa1 commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830457264
##
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##
@@ -113,26 +125,18 @@ public boolean exists(final
dfa1 commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830456338
##
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##
@@ -113,26 +125,18 @@ public boolean exists(final
dfa1 commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830456338
##
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##
@@ -113,26 +125,18 @@ public boolean exists(final
dfa1 edited a comment on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072958711
@rgoers yes, of course :-) Let me try to explain clearly: in
https://www.six-group.com/ there is an internal requirement to use a structured
logging format (called
dfa1 commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072958711
@rgoers yes, of course :-) Let me try to explain clearly: at @SIX-Group we
have an internal requirement to use a structured logging format (called unified
log event) for
dfa1 edited a comment on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072958711
@rgoers yes, of course :-) Let me try to explain clearly: in
https://www.six-group.com/ there is an internal requirement to use a structured
logging format (called
dfa1 commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830449257
##
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##
@@ -113,26 +125,18 @@ public boolean exists(final
rgoers commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072954499
@dfa1 In your comment above you said you do have a use case (one would hope
so for you to be implementing this) but you didn't explain your use case. All
you really said
rgoers closed pull request #799:
URL: https://github.com/apache/logging-log4j2/pull/799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rgoers commented on pull request #799:
URL: https://github.com/apache/logging-log4j2/pull/799#issuecomment-1072953796
This change would cause our RAT check to fail, would not match ASF
guidelines documented at https://www.apache.org/legal/src-headers.html, and as
Gary noted the URL is
rgoers commented on a change in pull request #804:
URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java
##
@@ -110,28 +139,64 @@ private ServiceLoaderUtil() {
rgoers commented on a change in pull request #804:
URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java
##
@@ -110,28 +139,64 @@ private ServiceLoaderUtil() {
rgoers commented on a change in pull request #804:
URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java
##
@@ -110,28 +139,64 @@ private ServiceLoaderUtil() {
rgoers commented on a change in pull request #804:
URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java
##
@@ -110,28 +139,64 @@ private ServiceLoaderUtil() {
35 matches
Mail list logo
