atulpendse commented on a change in pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r837103493
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java
##
@@ -393,7 +408,8 @@ protected SyslogAppender
[
https://issues.apache.org/jira/browse/LOG4J2-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513586#comment-17513586
]
Piotr Karwasz commented on LOG4J2-3450:
---
[~rgoers],
That is exactly my point: one
garydgregory commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1081036428
Hello @atulpendse
In general, you want to avoid breaking binary compatibility, so that means
not editing public and protected type names and method signatures. Th
garydgregory commented on a change in pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836762447
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java
##
@@ -627,7 +608,8 @@ public static Rfc5424Layo
garydgregory commented on a change in pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836761436
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java
##
@@ -393,7 +408,8 @@ protected SyslogAppend
[
https://issues.apache.org/jira/browse/LOG4J2-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513460#comment-17513460
]
Ralph Goers commented on LOG4J2-3450:
-
Not that it makes much of a difference, but I
atulpendse commented on a change in pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836438381
##
File path: log4j-core/revapi.json
##
@@ -128,6 +128,25 @@
"annotation":
"@org.apache.logging.log4j.core.config.plugins.PluginFactory"
atulpendse commented on a change in pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836438381
##
File path: log4j-core/revapi.json
##
@@ -128,6 +128,25 @@
"annotation":
"@org.apache.logging.log4j.core.config.plugins.PluginFactory"
garydgregory commented on a change in pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836407990
##
File path: log4j-core/revapi.json
##
@@ -128,6 +128,25 @@
"annotation":
"@org.apache.logging.log4j.core.config.plugins.PluginFactor
[
https://issues.apache.org/jira/browse/LOG4J2-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Karwasz reassigned LOG4J2-3450:
-
Assignee: Piotr Karwasz
> Add mechanism to disable Log4j2 automatic configuration
> ---
Piotr Karwasz created LOG4J2-3450:
-
Summary: Add mechanism to disable Log4j2 automatic configuration
Key: LOG4J2-3450
URL: https://issues.apache.org/jira/browse/LOG4J2-3450
Project: Log4j 2
I
vy commented on a change in pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#discussion_r836108757
##
File path:
log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/JsonReaderTest.java
##
@@ -375,6 +376,11 @@ public void test_nesting() {
12 matches
Mail list logo