[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-03-28 Thread GitBox
atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r837103493 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -393,7 +408,8 @@ protected SyslogAppender

[jira] [Commented] (LOG4J2-3450) Add mechanism to disable Log4j2 automatic configuration

2022-03-28 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513586#comment-17513586 ] Piotr Karwasz commented on LOG4J2-3450: --- [~rgoers], That is exactly my point: one

[GitHub] [logging-log4j2] garydgregory commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-03-28 Thread GitBox
garydgregory commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1081036428 Hello @atulpendse In general, you want to avoid breaking binary compatibility, so that means not editing public and protected type names and method signatures. Th

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-03-28 Thread GitBox
garydgregory commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836762447 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java ## @@ -627,7 +608,8 @@ public static Rfc5424Layo

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-03-28 Thread GitBox
garydgregory commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836761436 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -393,7 +408,8 @@ protected SyslogAppend

[jira] [Commented] (LOG4J2-3450) Add mechanism to disable Log4j2 automatic configuration

2022-03-28 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513460#comment-17513460 ] Ralph Goers commented on LOG4J2-3450: - Not that it makes much of a difference, but I

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-03-28 Thread GitBox
atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836438381 ## File path: log4j-core/revapi.json ## @@ -128,6 +128,25 @@ "annotation": "@org.apache.logging.log4j.core.config.plugins.PluginFactory"

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-03-28 Thread GitBox
atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836438381 ## File path: log4j-core/revapi.json ## @@ -128,6 +128,25 @@ "annotation": "@org.apache.logging.log4j.core.config.plugins.PluginFactory"

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-03-28 Thread GitBox
garydgregory commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836407990 ## File path: log4j-core/revapi.json ## @@ -128,6 +128,25 @@ "annotation": "@org.apache.logging.log4j.core.config.plugins.PluginFactor

[jira] [Assigned] (LOG4J2-3450) Add mechanism to disable Log4j2 automatic configuration

2022-03-28 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz reassigned LOG4J2-3450: - Assignee: Piotr Karwasz > Add mechanism to disable Log4j2 automatic configuration > ---

[jira] [Created] (LOG4J2-3450) Add mechanism to disable Log4j2 automatic configuration

2022-03-28 Thread Piotr Karwasz (Jira)
Piotr Karwasz created LOG4J2-3450: - Summary: Add mechanism to disable Log4j2 automatic configuration Key: LOG4J2-3450 URL: https://issues.apache.org/jira/browse/LOG4J2-3450 Project: Log4j 2 I

[GitHub] [logging-log4j2] vy commented on a change in pull request #775: [LOG4J2-3415] Support JSON configuration using embedded JSON parser

2022-03-28 Thread GitBox
vy commented on a change in pull request #775: URL: https://github.com/apache/logging-log4j2/pull/775#discussion_r836108757 ## File path: log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/JsonReaderTest.java ## @@ -375,6 +376,11 @@ public void test_nesting() {