[GitHub] [logging-log4j2] jvz commented on a diff in pull request #745: [LOG4J2-3362] Adds a SmtpManager compatible with Jakarta EE 9

2022-04-10 Thread GitBox
jvz commented on code in PR #745: URL: https://github.com/apache/logging-log4j2/pull/745#discussion_r846847955 ## log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SmtpAppender.java: ## @@ -261,9 +277,21 @@ public SmtpAppender build() { if

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-04-10 Thread GitBox
jvz commented on code in PR #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r846847224 ## log4j-api-java9/src/test/java/org/apache/logging/log4j/util/java9/ServiceLoaderUtilTest.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Comment Edited] (LOG4J2-3467) Update from Log4J 2.17.1 to 2.17.2 breaks application

2022-04-10 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520169#comment-17520169 ] Ralph Goers edited comment on LOG4J2-3467 at 4/10/22 1:34 PM: -- Yes, I would

[jira] [Commented] (LOG4J2-3467) Update from Log4J 2.17.1 to 2.17.2 breaks application

2022-04-10 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520169#comment-17520169 ] Ralph Goers commented on LOG4J2-3467: - Yes, I would agree with that. > Update from Log4J 2.17.1 to

[jira] [Comment Edited] (LOG4J2-3467) Update from Log4J 2.17.1 to 2.17.2 breaks application

2022-04-10 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520157#comment-17520157 ] Piotr Karwasz edited comment on LOG4J2-3467 at 4/10/22 12:05 PM: -

[jira] [Commented] (LOG4J2-3467) Update from Log4J 2.17.1 to 2.17.2 breaks application

2022-04-10 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520157#comment-17520157 ] Piotr Karwasz commented on LOG4J2-3467: --- [~rgoers], I have still my doubts. If

[jira] [Commented] (LOG4J2-3467) Update from Log4J 2.17.1 to 2.17.2 breaks application

2022-04-10 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520155#comment-17520155 ] Ralph Goers commented on LOG4J2-3467: - [~ggregory] I was called log4j-1.2-api because originally ALL