[jira] [Commented] (LOG4J2-3323) Breaking change in AbstractManager

2022-05-12 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536463#comment-17536463 ] Ralph Goers commented on LOG4J2-3323: - I started looking at this and while it could

[jira] [Closed] (LOG4J2-3323) Breaking change in AbstractManager

2022-05-12 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers closed LOG4J2-3323. --- Resolution: Won't Fix > Breaking change in AbstractManager > -- > >

[jira] [Commented] (LOG4J2-3361) SizeBasedTriggeringPolicy does not work properly

2022-05-12 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536459#comment-17536459 ] Ralph Goers commented on LOG4J2-3361: - This is still waiting for feedback from the u

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request, #843: Bump jeromq from 0.4.3 to 0.5.2

2022-05-12 Thread GitBox
dependabot[bot] opened a new pull request, #843: URL: https://github.com/apache/logging-log4j2/pull/843 Bumps [jeromq](https://github.com/zeromq/jeromq) from 0.4.3 to 0.5.2. Changelog Sourced from https://github.com/zeromq/jeromq/blob/master/CHANGELOG.md";>jeromq's changelog.

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #836: [LOG4J2-1376] Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
ppkarwasz commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871689461 ## log4j-core/src/test/java/org/apache/logging/log4j/core/layout/Rfc5424LayoutTest.java: ## @@ -527,4 +532,61 @@ public void testParameterizedMessage() {

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #836: [LOG4J2-1376] Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
ppkarwasz commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871689461 ## log4j-core/src/test/java/org/apache/logging/log4j/core/layout/Rfc5424LayoutTest.java: ## @@ -527,4 +532,61 @@ public void testParameterizedMessage() {

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
ppkarwasz commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871631509 ## log4j-core/src/test/java/org/apache/logging/log4j/core/appender/TlsSyslogAppenderTest.java: ## @@ -94,7 +94,7 @@ private SyslogAppender createAppender() {

[GitHub] [logging-log4j2] rgoers commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
rgoers commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871587464 ## log4j-core/src/test/java/org/apache/logging/log4j/core/appender/TlsSyslogAppenderTest.java: ## @@ -94,7 +94,7 @@ private SyslogAppender createAppender() {

[GitHub] [logging-log4j2] rgoers commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
rgoers commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871586697 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java: ## @@ -610,8 +610,8 @@ public static Rfc5424Layout createLayout( //

[jira] [Commented] (LOGCXX-554) Child thread does not inherit a copy of the mapped diagnostic context of its parent

2022-05-12 Thread Robert Middleton (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536098#comment-17536098 ] Robert Middleton commented on LOGCXX-554: - Where does the documentation state tha

[jira] [Resolved] (LOGCXX-553) log4cxx::spi::LocationInfo constructor backward compatibility

2022-05-12 Thread Robert Middleton (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Middleton resolved LOGCXX-553. - Resolution: Workaround > log4cxx::spi::LocationInfo constructor backward compatibility >

[jira] [Commented] (LOGCXX-553) log4cxx::spi::LocationInfo constructor backward compatibility

2022-05-12 Thread Robert Middleton (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536094#comment-17536094 ] Robert Middleton commented on LOGCXX-553: - If you use the location_info.getClassN

[GitHub] [logging-log4j2] sander-adhese commented on pull request #842: Fix a typo in SLF4JServiceProvider

2022-05-12 Thread GitBox
sander-adhese commented on PR #842: URL: https://github.com/apache/logging-log4j2/pull/842#issuecomment-1124849730 > It's not a typo, it is the correct method name in SLF4J 1.8 (cf. [Javadoc](https://www.javadoc.io/doc/org.slf4j/slf4j-api/1.8.0-beta4/org/slf4j/spi/SLF4JServiceProvider.html))

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #842: Fix a typo in SLF4JServiceProvider

2022-05-12 Thread GitBox
ppkarwasz commented on PR #842: URL: https://github.com/apache/logging-log4j2/pull/842#issuecomment-1124837910 It's not a typo, it is the correct method name in SLF4J 1.8 (cf. [Javadoc](https://www.javadoc.io/doc/org.slf4j/slf4j-api/1.8.0-beta4/org/slf4j/spi/SLF4JServiceProvider.html)).

[GitHub] [logging-log4j2] ppkarwasz closed pull request #842: Fix a typo in SLF4JServiceProvider

2022-05-12 Thread GitBox
ppkarwasz closed pull request #842: Fix a typo in SLF4JServiceProvider URL: https://github.com/apache/logging-log4j2/pull/842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (LOGCXX-554) Child thread does not inherit a copy of the mapped diagnostic context of its parent

2022-05-12 Thread Stefan Jipa (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Jipa updated LOGCXX-554: --- Description: Hi,   The API documentation for MDC says "The MDC is managed on a per thread basis. A

[GitHub] [logging-log4j2] mneundorfer commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
mneundorfer commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871163586 ## log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataId.java: ## @@ -139,11 +139,30 @@ public StructuredDataId(final String name, final Str

[GitHub] [logging-log4j2] Samsung72 commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
Samsung72 commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871121018 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java: ## @@ -634,11 +640,142 @@ public static Rfc5424Layout createLayout(

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
ppkarwasz commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871109379 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java: ## @@ -634,11 +640,142 @@ public static Rfc5424Layout createLayout(

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
ppkarwasz commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871107175 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java: ## @@ -634,11 +640,142 @@ public static Rfc5424Layout createLayout(

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
ppkarwasz commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871106575 ## log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java: ## @@ -226,6 +242,11 @@ public B setEnterpriseNumber(final String enterpr

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #836: Define eid as String instead of int to allow for Oid according to RFC5424

2022-05-12 Thread GitBox
ppkarwasz commented on code in PR #836: URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871104793 ## log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataId.java: ## @@ -139,11 +139,30 @@ public StructuredDataId(final String name, final Strin