[GitHub] [logging-log4net] fluffynuts merged pull request #95: Defer creation of locking model to ActivateOptions()

2022-10-24 Thread GitBox
fluffynuts merged PR #95: URL: https://github.com/apache/logging-log4net/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[jira] [Commented] (LOG4J2-3619) Log4j stops logging when the log message contains a java.lang.StackOverflowError

2022-10-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623213#comment-17623213 ] Carter Kozak commented on LOG4J2-3619: -- That would be ideal, if you could reproduce

[jira] [Commented] (LOG4J2-3619) Log4j stops logging when the log message contains a java.lang.StackOverflowError

2022-10-24 Thread Gary ,Verwers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623204#comment-17623204 ] Gary ,Verwers commented on LOG4J2-3619: --- I have tried to create an example applica

[GitHub] [logging-log4net] FreeAndNil commented on pull request #95: Defer creation of locking model to ActivateOptions()

2022-10-24 Thread GitBox
FreeAndNil commented on PR #95: URL: https://github.com/apache/logging-log4net/pull/95#issuecomment-1289001648 Hi @fluffynuts, i've reverted all the spacing changes. Regards -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (LOG4J2-3622) Support for virtual threads

2022-10-24 Thread liuxichen (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623152#comment-17623152 ] liuxichen commented on LOG4J2-3622: --- I noticed almost every Java log framework has use

[GitHub] [logging-log4net] fluffynuts commented on pull request #95: Defer creation of locking model to ActivateOptions()

2022-10-24 Thread GitBox
fluffynuts commented on PR #95: URL: https://github.com/apache/logging-log4net/pull/95#issuecomment-1288858922 @FreeAndNil most of the changes here are whitespace, except: 1. not setting `m_lockingModel` at line 1660 2. working around pdb files not being in the nuget package I'm

[GitHub] [logging-log4net] FreeAndNil opened a new pull request, #95: Defer creation of locking model to ActivateOptions()

2022-10-24 Thread GitBox
FreeAndNil opened a new pull request, #95: URL: https://github.com/apache/logging-log4net/pull/95 The creation of the locking model instance is now deferred to ActivateOptions() so that defaultLockingModelType has an effect. + Tabify all appender code files (were inconsistent) + includ