[GitHub] [logging-log4cxx] timcoleman opened a new issue, #179: Extra semicolons in include/log4cxx/pattern/patternconverter.h

2023-01-16 Thread GitBox
timcoleman opened a new issue, #179: URL: https://github.com/apache/logging-log4cxx/issues/179 When compiled with -Wpedantic, g++ complains of extra semicolons in include/log4cxx/pattern/patternconverter.h in this section: ```

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

2023-01-16 Thread GitBox
jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1071590544 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java: ## @@ -690,22 +726,17 @@ static CharSequence formatTimestamp(final long

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

2023-01-16 Thread GitBox
jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1071590262 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java: ## @@ -598,12 +636,22 @@ private StringBuilder toText(final LogEvent event, final

[GitHub] [logging-log4j2] jvz commented on pull request #1194: Migrate Recycler API to log4j-api

2023-01-16 Thread GitBox
jvz commented on PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#issuecomment-1384566193 @vy care to have a look at my changes to the `Recycler` API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] jvz commented on pull request #1194: Migrate Recycler API to log4j-api

2023-01-16 Thread GitBox
jvz commented on PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#issuecomment-1384562741 Alright, I think I've figured out one key update to `RecyclerFactory` to make this API natural to use as a replacement for ad hoc `ThreadLocal`-style object reuse. This is to allow

[jira] [Resolved] (LOG4J2-3628) Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2023-01-16 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3628. --- Resolution: Fixed > Migrate from maven-changes-plugin to a merge-conflict-free

[jira] [Closed] (LOG4J2-3628) Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2023-01-16 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3628. - Assignee: Volkan Yazici > Migrate from maven-changes-plugin to a merge-conflict-free

[GitHub] [logging-log4j2] vy merged pull request #1146: LOG4J2-3628 Replace maven-changes-plugin with a custom changelog implementation.

2023-01-16 Thread GitBox
vy merged PR #1146: URL: https://github.com/apache/logging-log4j2/pull/1146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4j-tools] vy opened a new issue, #17: Unreleased directories are sorted incorrectly in `ChangelogExporter`

2023-01-16 Thread GitBox
vy opened a new issue, #17: URL: https://github.com/apache/logging-log4j-tools/issues/17 Read `.2.x.x` and `.3.x.x` directories are passed to the changelog template in `ChangelogExporter` in incorrect order, that is, `.2.x.x` first and then `.3.x.x`, whereas it should have been the other

[GitHub] [logging-log4j2] vy closed issue #1207: Enforce signed commits

2023-01-16 Thread GitBox
vy closed issue #1207: Enforce signed commits URL: https://github.com/apache/logging-log4j2/issues/1207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4j2] vy commented on issue #1207: Enforce signed commits

2023-01-16 Thread GitBox
vy commented on issue #1207: URL: https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384476018 Fixed in c6019c979ac07c1e664d066d01302561b47d2c72 and b61fd7b7fb5e9036b915992d5fa5522e72e424ae. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4j2] ppkarwasz commented on issue #1207: Enforce signed commits

2023-01-16 Thread GitBox
ppkarwasz commented on issue #1207: URL: https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384455056 @vy, `spotless:check` is part of the build. We should document `spotless:apply` there so that contributors don't have to wonder why the build failed. -- This is

[GitHub] [logging-log4j2] vy commented on issue #1207: Enforce signed commits

2023-01-16 Thread GitBox
vy commented on issue #1207: URL: https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384447513 > * running `spotless:apply` Is this really necessary given it is part of the build? It sounds like _"building the sources"_ or am I exaggerating? -- This is an

[GitHub] [logging-log4j2] vy merged pull request #1172: Switch from JIRA to GitHub issues

2023-01-16 Thread GitBox
vy merged PR #1172: URL: https://github.com/apache/logging-log4j2/pull/1172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #1161: Bump maven-dependency-plugin from 3.3.0 to 3.4.0

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #1161: Bump maven-dependency-plugin from 3.3.0 to 3.4.0 URL: https://github.com/apache/logging-log4j2/pull/1161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #1161: Bump maven-dependency-plugin from 3.3.0 to 3.4.0

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #1161: URL: https://github.com/apache/logging-log4j2/pull/1161#issuecomment-1384430985 Superseded by #1212. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #1153: Bump spotless-maven-plugin from 2.27.2 to 2.28.0

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #1153: URL: https://github.com/apache/logging-log4j2/pull/1153#issuecomment-1384430982 Superseded by #1213. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request, #1213: Bump spotless-maven-plugin from 2.27.2 to 2.30.0

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #1213: URL: https://github.com/apache/logging-log4j2/pull/1213 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.27.2 to 2.30.0. Changelog Sourced from

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #1153: Bump spotless-maven-plugin from 2.27.2 to 2.28.0

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #1153: Bump spotless-maven-plugin from 2.27.2 to 2.28.0 URL: https://github.com/apache/logging-log4j2/pull/1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request, #1212: Bump maven-dependency-plugin from 3.3.0 to 3.5.0

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #1212: URL: https://github.com/apache/logging-log4j2/pull/1212 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.3.0 to 3.5.0. Commits

[GitHub] [logging-log4j2] vy merged pull request #1166: Simplify site generation

2023-01-16 Thread GitBox
vy merged PR #1166: URL: https://github.com/apache/logging-log4j2/pull/1166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LOG4J2-3647) Equivalence of `LogBuilder` and `Logger` calls

2023-01-16 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677416#comment-17677416 ] Ralph Goers commented on LOG4J2-3647: - Yes, I see the problem now. > Equivalence of `LogBuilder`

[GitHub] [logging-log4cxx] rm5248 commented on issue #177: LOG4CXX_INSTANTIATE_EXPORTED_PTR issue on MSYS2 / GCC

2023-01-16 Thread GitBox
rm5248 commented on issue #177: URL: https://github.com/apache/logging-log4cxx/issues/177#issuecomment-1384126363 > Hence I guess the C++ standard really prohibits this type of template instantiations, and the issue could resurface later in e.g. future MSVC versions implementing the

[GitHub] [logging-log4j2] StevenMassaro commented on pull request #1193: remove liquibase-log4j2 module

2023-01-16 Thread GitBox
StevenMassaro commented on PR #1193: URL: https://github.com/apache/logging-log4j2/pull/1193#issuecomment-1384068628 > Rebase/merge from current please? :) Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1210: fix: Restore previous behavior ignoring exceptions when translating a…

2023-01-16 Thread GitBox
ppkarwasz commented on PR #1210: URL: https://github.com/apache/logging-log4j2/pull/1210#issuecomment-1384065955 @wleese, Sorry, I forgot to comment on your issue report. Anyway, thank you for your issue report and PR. It is nice to see that someone **does** pay attention to Log4j2

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1128: [LOG4J2-3581] Provide a JCL to Log4j2 API binary weaver

2023-01-16 Thread GitBox
ppkarwasz commented on PR #1128: URL: https://github.com/apache/logging-log4j2/pull/1128#issuecomment-1384004494 Will be resubmitted to `logging-log4j-transform`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [logging-log4j2] ppkarwasz closed pull request #1128: [LOG4J2-3581] Provide a JCL to Log4j2 API binary weaver

2023-01-16 Thread GitBox
ppkarwasz closed pull request #1128: [LOG4J2-3581] Provide a JCL to Log4j2 API binary weaver URL: https://github.com/apache/logging-log4j2/pull/1128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] Deceptio opened a new issue, #1211: Hybrid example uses wrong class

2023-01-16 Thread GitBox
Deceptio opened a new issue, #1211: URL: https://github.com/apache/logging-log4j2/issues/1211 It seems that this example is not quite correct? [Hybrid Example](https://logging.apache.org/log4j/2.x/manual/customconfig.html#Hybrid) There is no XMLConfiguration class but only an

[GitHub] [logging-log4j2] wleese commented on pull request #1210: fix: Restore previous behavior ignoring exceptions when translating a…

2023-01-16 Thread GitBox
wleese commented on PR #1210: URL: https://github.com/apache/logging-log4j2/pull/1210#issuecomment-1383873097 I see a proper fix was provided in https://github.com/ppkarwasz/logging-log4j2/commit/5ddac7cd8a1e7ffe944f28086e1726d4818922bd -- This is an automated message from the Apache Git

[GitHub] [logging-log4j2] wleese closed pull request #1210: fix: Restore previous behavior ignoring exceptions when translating a…

2023-01-16 Thread GitBox
wleese closed pull request #1210: fix: Restore previous behavior ignoring exceptions when translating a… URL: https://github.com/apache/logging-log4j2/pull/1210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [logging-log4j2] wleese opened a new pull request, #1210: fix: Restore previous behavior ignoring exceptions when translating a…

2023-01-16 Thread GitBox
wleese opened a new pull request, #1210: URL: https://github.com/apache/logging-log4j2/pull/1210 … conversion parameter to an AnsiEscape enum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1148: Bump junit-pioneer from 1.6.2 to 1.9.1

2023-01-16 Thread GitBox
ppkarwasz commented on PR #1148: URL: https://github.com/apache/logging-log4j2/pull/1148#issuecomment-1383795952 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific