[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1064: [LOG4J2-3601] log4j-slf4j2-impl: depend on log4j-core scope=runtime

2023-02-05 Thread via GitHub
ppkarwasz commented on PR #1064: URL: https://github.com/apache/logging-log4j2/pull/1064#issuecomment-1418639838 @ctubbsii, The release date mostly depends on how much time we have outside our dayjobs. You can follow [Ralph's thread on

[jira] [Updated] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2023-02-05 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz updated LOG4J2-3601: -- Fix Version/s: 2.20.0 > log4j-slf4j2: change of dependency scope for log4j-core >

[jira] [Resolved] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2023-02-05 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-3601. --- Resolution: Fixed > log4j-slf4j2: change of dependency scope for log4j-core >

[GitHub] [logging-log4j-tools] github-actions[bot] merged pull request #26: Bump spotless-maven-plugin from 2.31.0 to 2.32.0

2023-02-05 Thread via GitHub
github-actions[bot] merged PR #26: URL: https://github.com/apache/logging-log4j-tools/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4j-tools] dependabot[bot] opened a new pull request, #26: Bump spotless-maven-plugin from 2.31.0 to 2.32.0

2023-02-05 Thread via GitHub
dependabot[bot] opened a new pull request, #26: URL: https://github.com/apache/logging-log4j-tools/pull/26 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.31.0 to 2.32.0. Changelog Sourced from

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #190: Prevent priority inversions when logging from multiple threads

2023-02-05 Thread via GitHub
swebb2066 commented on PR #190: URL: https://github.com/apache/logging-log4cxx/pull/190#issuecomment-1418443566 Having looked deeper at the [Linux futex docs](https://man7.org/linux/man-pages/man2/futex.2.html) and [the glibc pthread

[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #190: Prevent priority inversions when logging from multiple threads

2023-02-05 Thread via GitHub
rm5248 commented on code in PR #190: URL: https://github.com/apache/logging-log4cxx/pull/190#discussion_r1096900141 ## src/main/include/log4cxx/private/mutex.h: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [logging-log4cxx] swebb2066 commented on a diff in pull request #190: Prevent priority inversions when logging from multiple threads

2023-02-05 Thread via GitHub
swebb2066 commented on code in PR #190: URL: https://github.com/apache/logging-log4cxx/pull/190#discussion_r1096855676 ## src/main/include/log4cxx/private/mutex.h: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [logging-log4cxx] swebb2066 commented on a diff in pull request #190: Prevent priority inversions when logging from multiple threads

2023-02-05 Thread via GitHub
swebb2066 commented on code in PR #190: URL: https://github.com/apache/logging-log4cxx/pull/190#discussion_r1096855676 ## src/main/include/log4cxx/private/mutex.h: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [logging-log4cxx] swebb2066 commented on a diff in pull request #190: Prevent priority inversions when logging from multiple threads

2023-02-05 Thread via GitHub
swebb2066 commented on code in PR #190: URL: https://github.com/apache/logging-log4cxx/pull/190#discussion_r1096855676 ## src/main/include/log4cxx/private/mutex.h: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [logging-log4cxx] swebb2066 commented on a diff in pull request #190: Prevent priority inversions when logging from multiple threads

2023-02-05 Thread via GitHub
swebb2066 commented on code in PR #190: URL: https://github.com/apache/logging-log4cxx/pull/190#discussion_r1096855676 ## src/main/include/log4cxx/private/mutex.h: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1064: [LOG4J2-3601] log4j-slf4j2-impl: depend on log4j-core scope=runtime

2023-02-05 Thread via GitHub
ppkarwasz commented on PR #1064: URL: https://github.com/apache/logging-log4j2/pull/1064#issuecomment-1418251597 @afs, I merged it into `release-2.x` and `master`. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] ppkarwasz merged pull request #1064: [LOG4J2-3601] log4j-slf4j2-impl: depend on log4j-core scope=runtime

2023-02-05 Thread via GitHub
ppkarwasz merged PR #1064: URL: https://github.com/apache/logging-log4j2/pull/1064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LOG4J2-3621) Log4J 2.19 breaks contract of order of loading of System Properties

2023-02-05 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684343#comment-17684343 ] Piotr Karwasz commented on LOG4J2-3621: --- [~adwsingh], The loop in {{Environment#get}} uses the

[GitHub] [logging-log4cxx] rm5248 merged pull request #192: Update vcpkg version for windows

2023-02-05 Thread via GitHub
rm5248 merged PR #192: URL: https://github.com/apache/logging-log4cxx/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #190: Prevent priority inversions when logging from multiple threads

2023-02-05 Thread via GitHub
rm5248 commented on code in PR #190: URL: https://github.com/apache/logging-log4cxx/pull/190#discussion_r1096697212 ## src/main/include/log4cxx/private/mutex.h: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Comment Edited] (LOG4J2-3621) Log4J 2.19 breaks contract of order of loading of System Properties

2023-02-05 Thread Adwait Kumar Singh (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684303#comment-17684303 ] Adwait Kumar Singh edited comment on LOG4J2-3621 at 2/5/23 1:39 PM:

[jira] [Commented] (LOG4J2-3621) Log4J 2.19 breaks contract of order of loading of System Properties

2023-02-05 Thread Adwait Kumar Singh (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684303#comment-17684303 ] Adwait Kumar Singh commented on LOG4J2-3621: [~pkarwasz] Can I use a simpler approach of

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1266: Improves changelog template

2023-02-05 Thread via GitHub
ppkarwasz commented on PR #1266: URL: https://github.com/apache/logging-log4j2/pull/1266#issuecomment-1417406532 @rgoers, What do you think about this template? The old one always credited committers in the by-line. I think this is too verbose since: * we are already credited

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request, #1266: Improves changelog template

2023-02-05 Thread via GitHub
ppkarwasz opened a new pull request, #1266: URL: https://github.com/apache/logging-log4j2/pull/1266 This changes the changelog template to: * add issue links at the beginning, * strip Log4j2 committers from the credit line, * add a discrete "()" at the end of the description

[GitHub] [logging-log4j2] adwsingh commented on pull request #1165: [LOG4J2-3642] Consider Osgi versions older than 1.5 as not available.

2023-02-05 Thread via GitHub
adwsingh commented on PR #1165: URL: https://github.com/apache/logging-log4j2/pull/1165#issuecomment-1417334162 You can use Adwait Kumar Singh as the name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1218: Use changelog plugin

2023-02-05 Thread via GitHub
ppkarwasz commented on PR #1218: URL: https://github.com/apache/logging-log4j2/pull/1218#issuecomment-1417124081 @rgoers, The template is in this repo as a hidden file: https://github.com/apache/logging-log4j2/blob/release-2.x/src/changelog/.changelog-entries.adoc.ftl -- This is