[GitHub] [logging-log4cxx] swebb2066 commented on pull request #205: Add support for using SQLPrepare and bound parameters to the ODBC appender

2023-04-22 Thread via GitHub
swebb2066 commented on PR #205: URL: https://github.com/apache/logging-log4cxx/pull/205#issuecomment-1518960457 The SQLBindParam now works on Windows bu executing the prepared statement results in the error `[Microsoft][ODBC SQL Server Driver]String data, right truncation`. I will ne

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #205: Add support for using SQLPrepare and bound parameters to the ODBC appender

2023-04-22 Thread via GitHub
swebb2066 commented on PR #205: URL: https://github.com/apache/logging-log4cxx/pull/205#issuecomment-1518943053 It seem the way to determine the parameter type is [SQLDescribeParam](https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqldescribeparam-function) However, accordi

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #205: Add support for using SQLPrepare and bound parameters to the ODBC appender

2023-04-22 Thread via GitHub
swebb2066 commented on PR #205: URL: https://github.com/apache/logging-log4cxx/pull/205#issuecomment-1518919270 On Windows 10 (SQLExpress database) it now fails with - SQLGetDiagRecW reports `[Microsoft][ODBC SQL Server Driver]Invalid precision value` -- This is an automated m

[GitHub] [logging-log4cxx] rm5248 commented on pull request #205: Add support for using SQLPrepare and bound parameters to the ODBC appender

2023-04-22 Thread via GitHub
rm5248 commented on PR #205: URL: https://github.com/apache/logging-log4cxx/pull/205#issuecomment-1518895234 I have the binding _somewhat_ working correctly, but not completely. I think there's some mismatch between what I'm trying to do in C++ and what the C API will accept, e.g. the para

Re: [PR] Recycler API (logging-log4j2)

2023-04-22 Thread via GitHub
ppkarwasz commented on code in PR #1401: URL: https://github.com/apache/logging-log4j2/pull/1401#discussion_r1174461445 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java: ## @@ -2762,12 +2746,8 @@ public LogBuilder atLevel(final Level level) { * @

Re: [PR] Recycler API (logging-log4j2)

2023-04-22 Thread via GitHub
ppkarwasz commented on code in PR #1401: URL: https://github.com/apache/logging-log4j2/pull/1401#discussion_r1174447095 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java: ## @@ -2762,12 +2746,8 @@ public LogBuilder atLevel(final Level level) { * @

[GitHub] [logging-log4cxx] rm5248 commented on pull request #205: Add support for using SQLPrepare and bound parameters to the ODBC appender

2023-04-22 Thread via GitHub
rm5248 commented on PR #205: URL: https://github.com/apache/logging-log4cxx/pull/205#issuecomment-1518624399 I have an idea of how to make it work, I will try it out later today or tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #205: Add support for using SQLPrepare and bond parameters to the ODBC appender

2023-04-22 Thread via GitHub
swebb2066 commented on PR #205: URL: https://github.com/apache/logging-log4cxx/pull/205#issuecomment-1518544905 The initial implementation does not even work on Windows - The ParameterType argument of SQLBindParameter does not accept the value SQL_DEFAULT. Not sure had to resolve thes