[jira] [Work logged] (LOG4J2-3040) ShutdownCallbackRegistry should be part of log4j-api, not log4j-core

2023-08-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3040?focusedWorklogId=874168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874168 ] ASF GitHub Bot logged work on LOG4J2-3040: -- Author: ASF GitHub Bot

Re: [PR] [LOG4J2-3040] Avoid ClassCastException in JeroMqManager with custom LoggerContextFactory (logging-log4j2)

2023-08-01 Thread via GitHub
grgrzybek commented on PR #1313: URL: https://github.com/apache/logging-log4j2/pull/1313#issuecomment-1661516906 no problem - thanks ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Work logged] (LOG4J2-3040) ShutdownCallbackRegistry should be part of log4j-api, not log4j-core

2023-08-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3040?focusedWorklogId=874167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874167 ] ASF GitHub Bot logged work on LOG4J2-3040: -- Author: ASF GitHub Bot

Re: [PR] [LOG4J2-3040] Avoid ClassCastException in JeroMqManager with custom LoggerContextFactory (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz commented on PR #1313: URL: https://github.com/apache/logging-log4j2/pull/1313#issuecomment-1661469084 Apparently this was already included into 2.18.0 (cf. [changelog](https://logging.apache.org/log4j/2.x/release-notes/2.18.0.html#fixed)), but the attribution might have been copy

[jira] [Work logged] (LOG4J2-3040) ShutdownCallbackRegistry should be part of log4j-api, not log4j-core

2023-08-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3040?focusedWorklogId=874166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874166 ] ASF GitHub Bot logged work on LOG4J2-3040: -- Author: ASF GitHub Bot

Re: [PR] [LOG4J2-3040] Avoid ClassCastException in JeroMqManager with custom LoggerContextFactory (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz closed pull request #1313: [LOG4J2-3040] Avoid ClassCastException in JeroMqManager with custom LoggerContextFactory URL: https://github.com/apache/logging-log4j2/pull/1313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #244: Allow CFString code testing on non-Apple systems

2023-08-01 Thread via GitHub
swebb2066 opened a new pull request, #244: URL: https://github.com/apache/logging-log4cxx/pull/244 It is too difficult to get macos code developed without access to a Mac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [logging-log4cxx] swebb2066 merged pull request #243: Use CFString in OSX integration builds

2023-08-01 Thread via GitHub
swebb2066 merged PR #243: URL: https://github.com/apache/logging-log4cxx/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Add environment variable arbiter (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz closed pull request #1312: Add environment variable arbiter URL: https://github.com/apache/logging-log4j2/pull/1312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add environment variable arbiter (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz commented on PR #1312: URL: https://github.com/apache/logging-log4j2/pull/1312#issuecomment-1661030857 This was squashed into e0fd5cc245e3fd8325fcbd73cca83022aec84add and merged. Thank you very much @MouettE-SC. -- This is an automated message from the Apache Git Service.

Re: [PR] (doc) Update log4j-spring-boot spring-boot min version (logging-log4j2)

2023-08-01 Thread via GitHub
SebHeuze closed pull request #1652: (doc) Update log4j-spring-boot spring-boot min version URL: https://github.com/apache/logging-log4j2/pull/1652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] (doc) Update log4j-spring-boot spring-boot min version (logging-log4j2)

2023-08-01 Thread via GitHub
SebHeuze commented on PR #1652: URL: https://github.com/apache/logging-log4j2/pull/1652#issuecomment-166125 Yes you are right, my mistake was because the project that had the issue forced the log4j version so I had the compatibility issue with 2.3.9 -- This is an automated message

[I] `Appender#stop` is not idempotent (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz opened a new issue, #1653: URL: https://github.com/apache/logging-log4j2/issues/1653 ## Description In Log4j 2 managers are reference counted: if you have two `FileAppender`s writing to the same file, there will be a single `FileManager` with a reference count of 2.

Re: [PR] (doc) Update log4j-spring-boot spring-boot min version (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz commented on PR #1652: URL: https://github.com/apache/logging-log4j2/pull/1652#issuecomment-1660870439 Hi @SebHeuze, The story is a little bit more complicated than that. Before Spring Boot 2.4.0 the only way to select a Spring Boot [`LoggingSystem`](https://docs.spri

[PR] (doc) Update log4j-spring-boot spring-boot min version (logging-log4j2)

2023-08-01 Thread via GitHub
SebHeuze opened a new pull request, #1652: URL: https://github.com/apache/logging-log4j2/pull/1652 Since log4j-spring-boot 2.18.0 the required Spring Boot version is now 2.4.0 since it use `LoggingSystemFactory` which is a spring boot 2.4.0 class [https://docs.spring.io/spring-boot/docs

Re: [PR] Fix `MemoryMappedFileAppender` buffer unmapping on JRE 9+ (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz commented on PR #1647: URL: https://github.com/apache/logging-log4j2/pull/1647#issuecomment-1660531793 This time the JDK 9+ solution does exactly the same as the JDK 8 solution: [`Unsafe#invokeCleaner()`](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/jdk/in

Re: [I] Inverted rollover strategy in `log4j-1.2-api` (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz commented on issue #1650: URL: https://github.com/apache/logging-log4j2/issues/1650#issuecomment-1660502164 @krzyk, Sure, go ahead. Just remember to add a unity test, so we prevent future regressions. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Fix `MemoryMappedFileAppender` buffer unmapping on JRE 9+ (logging-log4j2)

2023-08-01 Thread via GitHub
vy commented on PR #1647: URL: https://github.com/apache/logging-log4j2/pull/1647#issuecomment-1660472890 I still need to wrap my mind around how this _do-this-for-pre-9-and-that-for-post-9_ magic works, but from a quick glance, it all looks good to me. -- This is an automated message fr

Re: [PR] `ParameterFormatter` rewrite with corrected escape handling (logging-log4j2)

2023-08-01 Thread via GitHub
vy commented on code in PR #1639: URL: https://github.com/apache/logging-log4j2/pull/1639#discussion_r1280739791 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java: ## @@ -119,30 +119,28 @@ public Message memento() { return new

Re: [I] Inverted rollover strategy in `log4j-1.2-api` (logging-log4j2)

2023-08-01 Thread via GitHub
krzyk commented on issue #1650: URL: https://github.com/apache/logging-log4j2/issues/1650#issuecomment-1660444219 Hi, could I work on fix for this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump guava.version from 32.1.1-jre to 32.1.2-jre (logging-log4j2)

2023-08-01 Thread via GitHub
github-actions[bot] merged PR #1651: URL: https://github.com/apache/logging-log4j2/pull/1651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.mockito:mockito-bom from 5.2.0 to 5.4.0 (logging-log4j2)

2023-08-01 Thread via GitHub
github-actions[bot] merged PR #1625: URL: https://github.com/apache/logging-log4j2/pull/1625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.50.v20221201 to 9.4.51.v20230217 (logging-log4j2)

2023-08-01 Thread via GitHub
github-actions[bot] merged PR #1648: URL: https://github.com/apache/logging-log4j2/pull/1648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump io.netty:netty-bom from 4.1.86.Final to 4.1.96.Final (logging-log4j2)

2023-08-01 Thread via GitHub
github-actions[bot] merged PR #1649: URL: https://github.com/apache/logging-log4j2/pull/1649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[I] Inverted rollover strategy in `log4j-1.2-api` (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz opened a new issue, #1650: URL: https://github.com/apache/logging-log4j2/issues/1650 ## Description The default rollover strategy in Log4j 1.x archived the current log file `File` **always** to `File.1`: > If `MaxBackupIndex` is positive, then files `{File.1, ..., Fi

[PR] Fix `MemoryMappedFileAppender` buffer unmapping on JRE 9+ (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz opened a new pull request, #1647: URL: https://github.com/apache/logging-log4j2/pull/1647 This moves the direct buffer unmapping logic into a new class `UnsafeUtil` for which a Java 9 version is also provided. Closes #1646. -- This is an automated message from the

[I] MappedByteBuffer unmapping on JDK 9+ (logging-log4j2)

2023-08-01 Thread via GitHub
ppkarwasz opened a new issue, #1646: URL: https://github.com/apache/logging-log4j2/issues/1646 ## Description The `MemoryMappedFileAppender` fails to unmap its buffers on JRE 9+: the unmapping code (cf. [`MemoryMappedFileAppender#unsafeUnmap()`](https://github.com/apache/logging-log4

Re: [I] Springboot - not replace spring propreties in log4j.xml (logging-log4j2)

2023-08-01 Thread via GitHub
SebHeuze commented on issue #1267: URL: https://github.com/apache/logging-log4j2/issues/1267#issuecomment-1659859627 @ppkarwasz I have the same problem since I upgraded from 2.17.2 to 2.19 (Spring boot 2.3.9) I don't need two log4j files or arbiters to make it work in 2.17.2 But