Re: [PR] Upgrade CI dependencies [logging-log4cxx]

2024-01-21 Thread via GitHub
swebb2066 merged PR #334: URL: https://github.com/apache/logging-log4cxx/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Upgrade CI dependencies [logging-log4cxx]

2024-01-21 Thread via GitHub
swebb2066 opened a new pull request, #334: URL: https://github.com/apache/logging-log4cxx/pull/334 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Reduce logging overhead [logging-log4cxx]

2024-01-21 Thread via GitHub
swebb2066 commented on PR #333: URL: https://github.com/apache/logging-log4cxx/pull/333#issuecomment-1903011007 On Ubuntu gcc 9, benchmarks improve from: | Benchmark | Time | CPU | Iterations | | | - | -- | --- | | Testing disabled logging request | 0.474

[PR] Reduce logging overhead [logging-log4cxx]

2024-01-21 Thread via GitHub
swebb2066 opened a new pull request, #333: URL: https://github.com/apache/logging-log4cxx/pull/333 Ths PR improves benchmarks (on Windows) from: | Benchmark | Time | CPU | Iterations | | --- | -- | -- | -- | | Testing disabled logging request | 2.70 ns | 0.391

Re: [I] Question: using AsyncAppender [logging-log4cxx]

2024-01-21 Thread via GitHub
rm5248 commented on issue #332: URL: https://github.com/apache/logging-log4cxx/issues/332#issuecomment-1902818118 > > possible to call the DOMConfigurator::configure function multiple times in my program > > Yes. `DOMConfigurator::configure` is most usefully automatically called

Re: [I] Question: using AsyncAppender [logging-log4cxx]

2024-01-21 Thread via GitHub
swebb2066 commented on issue #332: URL: https://github.com/apache/logging-log4cxx/issues/332#issuecomment-1902814172 > possible to call the DOMConfigurator::configure function multiple times in my program Yes. `DOMConfigurator::configure` is most usefully automatically called when

Re: [I] Question: using AsyncAppender [logging-log4cxx]

2024-01-21 Thread via GitHub
swebb2066 commented on issue #332: URL: https://github.com/apache/logging-log4cxx/issues/332#issuecomment-1902810015 > FileAppender works just fine. I was thinking how could I optimize it more. The default value of `BufferedIO` is false [documented

[I] Question: using AsyncAppender [logging-log4cxx]

2024-01-21 Thread via GitHub
atari83 opened a new issue, #332: URL: https://github.com/apache/logging-log4cxx/issues/332 Hello! So, I'm working on a program that produce about 100K rows of data per minute and approximately each row is about 2K. While using simple and straightforward `FileAppender` works just

Re: [PR] Adds lighter v3 `Logger` interface (PoC) (logging-log4j2)

2024-01-21 Thread via GitHub
ppkarwasz commented on PR #2215: URL: https://github.com/apache/logging-log4j2/pull/2215#issuecomment-1902786893 No, it might be relevant in the future, but right now I am closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Adds lighter v3 `Logger` interface (PoC) (logging-log4j2)

2024-01-21 Thread via GitHub
ppkarwasz closed pull request #2215: Adds lighter v3 `Logger` interface (PoC) URL: https://github.com/apache/logging-log4j2/pull/2215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Adds lighter v3 `Logger` interface (PoC) (logging-log4j2)

2024-01-21 Thread via GitHub
vy commented on PR #2215: URL: https://github.com/apache/logging-log4j2/pull/2215#issuecomment-1902763617 @ppkarwasz, given [we decided to use `log4j-api-2.x` in `main`](https://lists.apache.org/thread/gvk0to32c13xsfz0ytczfs506svx3hxm), is this PR still relevant for me to review? --

Re: [PR] Add security threat model to docs (logging-log4j2)

2024-01-21 Thread via GitHub
vy commented on code in PR #2219: URL: https://github.com/apache/logging-log4j2/pull/2219#discussion_r1461110865 ## src/site/asciidoc/security.adoc: ## @@ -46,6 +46,89 @@ If you have encountered an unlisted security vulnerability or other unexpected b The threat model that

Re: [PR] Add security threat model to docs (logging-log4j2)

2024-01-21 Thread via GitHub
vy commented on code in PR #2219: URL: https://github.com/apache/logging-log4j2/pull/2219#discussion_r1461103299 ## src/site/asciidoc/security.adoc: ## @@ -46,6 +46,89 @@ If you have encountered an unlisted security vulnerability or other unexpected b The threat model that

Re: [PR] Clean up `log4j-spring-cloud-config-client` dependencies (logging-log4j2)

2024-01-21 Thread via GitHub
vy commented on PR #2166: URL: https://github.com/apache/logging-log4j2/pull/2166#issuecomment-1902746187 @ppkarwasz thank you so much for your effort and understanding in this PR. You also have done a great job by [introducing our agreement here as a general policy to the Log4j

Re: [I] Create an alternative async logger implementation using JCTools (logging-log4j2)

2024-01-21 Thread via GitHub
vy commented on issue #2220: URL: https://github.com/apache/logging-log4j2/issues/2220#issuecomment-1902745396 @jvz, the performance benefits of asynchronous loggers are extremely subjective to the deployment environment. Putting aside Log4j team itself is not able to reproduce [the (8