swebb2066 commented on PR #351:
URL: https://github.com/apache/logging-log4cxx/pull/351#issuecomment-1938092708
On Ubuntu (gcc 11), the `benchmark/tools/compare.py --no-color benchmarks
/tmp/old.json /tmp/new.json` results are:
| Benchmark | Time | CPU | Time Old | Time New | CPU Old
swebb2066 commented on PR #351:
URL: https://github.com/apache/logging-log4cxx/pull/351#issuecomment-1938079026
> What's the reasoning behind the lazy initialization of m_priv? It makes
the code harder to read IMO since you now have an extra check to see if it is
valid, instead of just know
rm5248 commented on PR #351:
URL: https://github.com/apache/logging-log4cxx/pull/351#issuecomment-1938068864
What's the reasoning behind the lazy initialization of `m_priv`? It makes
the code harder to read IMO since you now have an extra check to see if it is
valid, instead of just knowin
swebb2066 commented on PR #351:
URL: https://github.com/apache/logging-log4cxx/pull/351#issuecomment-1937974342
On Windows, the benchmark comparisons using a lock (old) and without locking
(new) in AppenderAttachableImpl::appendLoopOnAppenders are:
| Benchmark | Time | CPU | Time Old
swebb2066 opened a new pull request, #351:
URL: https://github.com/apache/logging-log4cxx/pull/351
AppenderAttachableImpl::appendLoopOnAppenders does not need to lock a mutex
for any Logger in the path to the root Logger which has no appenders attached
(This partly addressed #347).
--
Th
ppkarwasz commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1937852187
> @rocketraman, we (almost) always use `Squash and Commit` in Log4j. You
could have done the same for this PR. That is, your PR would appear as a single
commit in `main`. Does
vy commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1937845625
> My preference is generally to sacrifice the GitHub PR cleanliness in favor
of a clean commit history, as the former is transient and the latter is forever.
@rocketraman, we (
[
https://issues.apache.org/jira/browse/LOGCXX-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816443#comment-17816443
]
Robert Middleton commented on LOGCXX-576:
-
Line 26 has:
{code:java}
Apache log4c
[
https://issues.apache.org/jira/browse/LOGCXX-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816430#comment-17816430
]
Gary D. Gregory commented on LOGCXX-576:
Moving this issue to the LOGCXX Jira pro
[
https://issues.apache.org/jira/browse/LOGCXX-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory moved LOGGING-184 to LOGCXX-576:
Key: LOGCXX-576 (was: LOGGING-184)
Affects Versi
vopl commented on PR #350:
URL: https://github.com/apache/logging-log4cxx/pull/350#issuecomment-1937693885
https://github.com/apache/logging-log4cxx/issues/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
swebb2066 commented on issue #349:
URL:
https://github.com/apache/logging-log4cxx/issues/349#issuecomment-1937609722
This is a bug. The LOG4CXX_NS cmake variable is not available when
`src/cmake/boost-fallback/boost-std-configuration.h.cmake` is being processed
as it is not exported from `
vopl commented on issue #349:
URL:
https://github.com/apache/logging-log4cxx/issues/349#issuecomment-1937499893
LOG4CXX_NS is a cached variable with the default value "log4cxx", declared
here
https://github.com/apache/logging-log4cxx/blob/master/src/main/include/CMakeLists.txt#L82.
The pr
perhapsmaple opened a new issue, #349:
URL: https://github.com/apache/logging-log4cxx/issues/349
Hi, I am trying to build log4cxx with the MultiprocessRollingFileAppender
using CMake with the following command:
```
cmake -B build -S . -DLOG4CXX_MULTIPROCESS_ROLLING_FILE_APPENDER=ON
-
14 matches
Mail list logo
