[PR] Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.32 [logging-log4j-samples]

2024-02-15 Thread via GitHub
dependabot[bot] opened a new pull request, #116: URL: https://github.com/apache/logging-log4j-samples/pull/116 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.31 to 5.3.32. Release notes Sourced from https://github.com

Re: [PR] Remove unnessessary indirection in AsyncAppender [logging-log4cxx]

2024-02-15 Thread via GitHub
swebb2066 merged PR #353: URL: https://github.com/apache/logging-log4cxx/pull/353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Revamp `AbstractLogger` in `log4j-sdk` (logging-log4j2)

2024-02-15 Thread via GitHub
vy commented on PR #2291: URL: https://github.com/apache/logging-log4j2/pull/2291#issuecomment-1947379126 Please no enumerated naming, e.g., `log4j-spi3`. I am fine with `log4j-sdk`. Other alternatives I can think of: * `log4j-runtime` * `log4j-backend` * `log4j-kit` * `log

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory commented on PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#issuecomment-1947341986 > LGTM @ppkarwasz TY for your help; merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory merged PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

Re: [PR] Bump org.springframework:spring-framework-bom from 6.1.3 to 6.1.4 [logging-log4j-jakarta]

2024-02-15 Thread via GitHub
github-actions[bot] merged PR #18: URL: https://github.com/apache/logging-log4j-jakarta/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Revamp `AbstractLogger` in `log4j-sdk` (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz commented on PR #2291: URL: https://github.com/apache/logging-log4j2/pull/2291#issuecomment-1947149631 > "SDK" implies to me something big, not an API, while "SPI" implies something like a template to be implemented or classes to be extended. I don't like calling things SDK

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz commented on code in PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#discussion_r1491551371 ## log4j-jul/src/test/java/org/apache/logging/log4j/jul/test/CoreLoggerTest.java: ## @@ -100,6 +103,35 @@ public void testSetLevel() throws Exception {

Re: [PR] Revamp `AbstractLogger` in `log4j-sdk` (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory commented on PR #2291: URL: https://github.com/apache/logging-log4j2/pull/2291#issuecomment-1946829794 "SDK" implies to me something bigger, not an API, while "SPI" implies something like a template to be implemented or classes to be extended. -- This is an automated message

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory commented on code in PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#discussion_r1491423674 ## log4j-jul/src/test/java/org/apache/logging/log4j/jul/test/CoreLoggerTest.java: ## @@ -100,6 +103,35 @@ public void testSetLevel() throws Exception {

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory commented on code in PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#discussion_r1491337669 ## log4j-jul/src/test/java/org/apache/logging/log4j/jul/test/CoreLoggerTest.java: ## @@ -100,6 +103,35 @@ public void testSetLevel() throws Exception {

[I] Performance optimization in CloseableThreadContext.closeMap() (logging-log4j2)

2024-02-15 Thread via GitHub
jengebr opened a new issue, #2292: URL: https://github.com/apache/logging-log4j2/issues/2292 ## Description Excess work is performed in CloseableThreadContext.closeMap() that shows up as a production hotspot in our client-facing, latency-sensitive application. Specifically, the use

[PR] Revamp `AbstractLogger` in `log4j-sdk` (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz opened a new pull request, #2291: URL: https://github.com/apache/logging-log4j2/pull/2291 In order for Log4j Core 3.x not to depend on the utility classes in Log4j API 2.x, we provide a new `AbstractLogger` in `log4j-sdk`. The main improvements to this `AbstractLogger` are:

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz commented on code in PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#discussion_r1491229106 ## log4j-jul/src/test/java/org/apache/logging/log4j/jul/test/CoreLoggerTest.java: ## @@ -100,6 +103,35 @@ public void testSetLevel() throws Exception {

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory commented on PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#issuecomment-1946333944 Ah, good point on the tests, I update the tests to use `isLoggable()` and now they pass. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Move validation constraints to `log4j-plugins-api` (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz closed pull request #2172: Move validation constraints to `log4j-plugins-api` URL: https://github.com/apache/logging-log4j2/pull/2172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz commented on PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#issuecomment-1946285333 Are we testing the right thing? Unless I am mistaken JUL's [`Logger#getLevel`](https://docs.oracle.com/en/java/javase/17/docs/api/java.logging/java/util/logging/Logger.html#getLev

[I] [MS11] Log4j API generalization #2 (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz opened a new issue, #2290: URL: https://github.com/apache/logging-log4j2/issues/2290 Following the conclusion of #2273, we continue our goal of rebasing Log4j Core 3.x on top of Log4j API 2.x. In order to do so we need to: - [ ] Create a new `log4j-sdk` module to contain the

Re: [PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory commented on PR #2289: URL: https://github.com/apache/logging-log4j2/pull/2289#issuecomment-1946164972 Note that the new test fails... @ppkarwasz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] [Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() (logging-log4j2)

2024-02-15 Thread via GitHub
garydgregory opened a new pull request, #2289: URL: https://github.com/apache/logging-log4j2/pull/2289 Do for this module what we did for `log4j-1.2-api`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Fix 1799 and Spring 33450 (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz commented on code in PR #2062: URL: https://github.com/apache/logging-log4j2/pull/2062#discussion_r1491011916 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/internal/InternalLoggerContext.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Bump org.asciidoctor:asciidoctor-maven-plugin from 2.2.6 to 3.0.0 [logging-parent]

2024-02-15 Thread via GitHub
github-actions[bot] merged PR #119: URL: https://github.com/apache/logging-parent/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump org.asciidoctor:asciidoctor-maven-plugin from 2.2.6 to 3.0.0 [logging-parent]

2024-02-15 Thread via GitHub
dependabot[bot] opened a new pull request, #119: URL: https://github.com/apache/logging-parent/pull/119 Bumps [org.asciidoctor:asciidoctor-maven-plugin](https://github.com/asciidoctor/asciidoctor-maven-plugin) from 2.2.6 to 3.0.0. Release notes Sourced from https://github.com/asci

[I] Thread prints generic thread name instead of ID ".NET TP Worker" (logging-log4net)

2024-02-15 Thread via GitHub
Alhalwachi-BBK opened a new issue, #112: URL: https://github.com/apache/logging-log4net/issues/112 After upgrading to ASP.NET core 8, the logs using the property %thread print a generic thread name instead of the thread ID. The commit https://github.com/apache/logging-log4net/commit/

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.52.v20230823 to 9.4.54.v20240208 (logging-log4j2)

2024-02-15 Thread via GitHub
ppkarwasz commented on PR #2285: URL: https://github.com/apache/logging-log4j2/pull/2285#issuecomment-1945549858 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump io.netty:netty-bom from 4.1.106.Final to 4.1.107.Final (logging-log4j2)

2024-02-15 Thread via GitHub
github-actions[bot] closed pull request #2284: Bump io.netty:netty-bom from 4.1.106.Final to 4.1.107.Final URL: https://github.com/apache/logging-log4j2/pull/2284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab