Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1527118053 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/DefaultThreadContextMap.java: ## @@ -43,40 +43,30 @@ public class DefaultThreadContextMap implements T

Re: [I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on issue #125: URL: https://github.com/apache/logging-log4net/issues/125#issuecomment-2000480599 OK. I would propose releasing the first 3.0.0 preview with the obsolete classes, so that we could deploy this version in our company and to other "willing" users. Then we r

Re: [PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on PR #126: URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2000364779 Thanks. I will review on Monday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav commented on PR #126: URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2000343172 @FreeAndNil Important to closely review `ReadOnlyPropertiesDictionary` and `PropertiesDictionary`. I selected the most backward compatible option, which is to coerce the `this[]` ge

Re: [I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-15 Thread via GitHub
fluffynuts commented on issue #125: URL: https://github.com/apache/logging-log4net/issues/125#issuecomment-2000341731 I agree - something marked `[Obsolete]` can go, something that still works, even if it's only for a few users, can stay. And we should be very judicial about deprecations -

Re: [PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav commented on PR #126: URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2000331267 For #124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav opened a new pull request, #126: URL: https://github.com/apache/logging-log4net/pull/126 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2000228751 @JyotiSathe, The stack trace you deleted seems like a problem with Spring Boot's version of our lookup. Unlike our version it fails if there is no environment.

[I] SpringProfile arbiter fails without a Spring's environment (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz opened a new issue, #1783: URL: https://github.com/apache/logging-log4j2/issues/1783 ## Description In a Spring Boot application Log4j Core is initialized **at least** twice: - the first initialization is the static Log4j Core initialization (Spring's [`Environment`](ht

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil merged PR #123: URL: https://github.com/apache/logging-log4net/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-2000186414 Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
JyotiSathe commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2000110589 If I remove the dependency log4j-spring-boot then I get below exception. **ERROR StatusConsoleListener Resolver failed to lookup spring:spring.application.name j

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz closed issue #2384: log4j-spring-boot gives error URL: https://github.com/apache/logging-log4j2/issues/2384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-291619 @JyotiSathe, Which Spring Boot 3.x artifact depends on `org.apache.logging.log4j:log4j-spring-boot`? The functionality of `log4j-spring-boot` is embedded into

Re: [PR] Bump org.postgresql:postgresql from 42.7.2 to 42.7.3 [logging-log4j-audit]

2024-03-15 Thread via GitHub
github-actions[bot] merged PR #130: URL: https://github.com/apache/logging-log4j-audit/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump org.postgresql:postgresql from 42.7.2 to 42.7.3 [logging-log4j-audit]

2024-03-15 Thread via GitHub
dependabot[bot] opened a new pull request, #130: URL: https://github.com/apache/logging-log4j-audit/pull/130 Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.7.2 to 42.7.3. Release notes Sourced from https://github.com/pgjdbc/pgjdbc/releases";>org.postgre

[I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
JyotiSathe opened a new issue, #2384: URL: https://github.com/apache/logging-log4j2/issues/2384 ## Description I have spring boot project, recently upgraded to version 3.2.2 from 3.1.0. We are using dependency "org.apache.logging.log4j:log4j-spring-boot" in our project. After

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1999873939 Misunderstood the comment. Working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (LOG4J2-3681) NoClassDefFoundError for org.xml.sax.SAXException after jlink app with log4j 3 beta2

2024-03-15 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827484#comment-17827484 ] Piotr Karwasz commented on LOG4J2-3681: --- I moved this issue to Github: [https://g

[I] Split off XML configuration into its own module or internal package (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz opened a new issue, #2383: URL: https://github.com/apache/logging-log4j2/issues/2383 Since `java.xml` is an **optional** module in Log4j Core 3.x, we need to protect the users from linkage errors like the one reported in [LOG4J2-3681](https://issues.apache.org/jira/browse/LOG4J2-3

Re: [PR] Bump spring-framework.version from 6.1.4 to 6.1.5 (logging-log4j2)

2024-03-15 Thread via GitHub
github-actions[bot] merged PR #2382: URL: https://github.com/apache/logging-log4j2/pull/2382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on issue #125: URL: https://github.com/apache/logging-log4net/issues/125#issuecomment-1999398844 I agree with removing the obsolete classes and methods. I'm not sure about NDC. Looking at the code it seems to be explicitly un-deprecated and there are many uses

Re: [PR] Bump actions/setup-java from 4.2.0 to 4.2.1 [logging-parent]

2024-03-15 Thread via GitHub
github-actions[bot] merged PR #137: URL: https://github.com/apache/logging-parent/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump actions/setup-java from 4.2.0 to 4.2.1 [logging-parent]

2024-03-15 Thread via GitHub
dependabot[bot] opened a new pull request, #137: URL: https://github.com/apache/logging-parent/pull/137 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.2.0 to 4.2.1. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-j

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1999156517 @erikmav did you see my comment regarding the missing test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u