Re: [PR] Adjust GcpLayout JSON to latest format [logging-log4j2]

2025-04-12 Thread via GitHub
ppkarwasz commented on code in PR #3586: URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2041061619 ## log4j-layout-template-json/src/main/resources/GcpLayout.json: ## @@ -49,25 +55,15 @@ "key": "span_id" }, "logging.googleapis.com/trace_sampled":

Re: [I] Reintroduce the Scorecard workflow [logging-log4j2]

2025-04-12 Thread via GitHub
ppkarwasz commented on issue #3604: URL: https://github.com/apache/logging-log4j2/issues/3604#issuecomment-2799067324 @vy, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] Reintroduce the Scorecard workflow [logging-log4j2]

2025-04-12 Thread via GitHub
ppkarwasz opened a new issue, #3604: URL: https://github.com/apache/logging-log4j2/issues/3604 We should reconsider enabling the Scorecard action, considering especially that: - A Scorecard for Apache Log4j is computed anyway, since [Scorecards are computed for 1 million critical pr

Re: [PR] Lock Antora dependencies [logging-parent]

2025-04-12 Thread via GitHub
ppkarwasz commented on PR #367: URL: https://github.com/apache/logging-parent/pull/367#issuecomment-2799011452 > > transitive NPM dependencies will be upgraded only by Dependabot > > Does this mean Dependabot will try to upgrade hundreds of dependencies listed in `npm-shrinkwrap.json`

[PR] Use workflows on the same branch [logging-parent]

2025-04-12 Thread via GitHub
ppkarwasz opened a new pull request, #379: URL: https://github.com/apache/logging-parent/pull/379 Since most of the PRs to `logging-parent` modify the workflows, we should not run the reusable workflows from the `@main` branch, but from the same branch as the PR. This PR changes all

Re: [PR] Dummy change to test branch protection [logging-parent]

2025-04-12 Thread via GitHub
ppkarwasz closed pull request #378: Dummy change to test branch protection URL: https://github.com/apache/logging-parent/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Enforce RTC style on `logging-log4j2` [logging-log4j2]

2025-04-12 Thread via GitHub
grobmeier commented on PR #3582: URL: https://github.com/apache/logging-log4j2/pull/3582#issuecomment-2798794649 +1. Support for this, even when it is already merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the