ppkarwasz commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2844207560
@neboskreb,
Thanks a lot! Now the Android support is almost as good as the JVM support!
:100:
IIRC there is still one location-related feature that breaks on Android
ppkarwasz merged PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
neboskreb commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2843199988
This helped!
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ppkarwasz commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2843140329
I don't see the signatures, I even checked the raw data.
Try
```sh
git rebase -f -i -S 2.x
git push -f
```
--
This is an automated message from the Apache Git
neboskreb commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2843107311
> * Could you [add a changelog
file](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)
to `src/changelog/.2.x.x`? You can use one of the files alr
ppkarwasz commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2843030904
@neboskreb,
Thanks! In order to merge the PR:
- All the commits must be signed with a GPG recognized by Github. If you
didn't do it before, could you [add a GPG key
neboskreb commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2842991058
Re-formatted the code to make Spotless happy. Hopefully, this turns the
build green.
This is the most I can do, I'm sorry.
--
This is an automated message from the Apac
neboskreb commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2842071883
Apparently, we have different approaches. Feel free to close this PR if you
don't plan to merge it. After all, it proposes _one of many_ possible ways to
fix #3639; you can alway
ppkarwasz commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2841906192
> Okay, so checking the runtime platform appears ugly, because it requires
copying the code from `SystemUtils` (which is available in `core` but not here
in `api`) or referring t
neboskreb commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2841819684
Okay, so checking the runtime platform appears ugly, because it requires
copying the code from `SystemUtils` (which is available in `core` but not here
in `api`) or referring to
jbb01 commented on PR #3568:
URL: https://github.com/apache/logging-log4j2/pull/3568#issuecomment-2841700784
I am somewhat confused as to why the build fails. If I'm reading the logs
correctly the spotbugs plugin is complaining about some Java code, but this PR
does not change any Java code
neboskreb commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2841672144
Ah, I see your point. Let me quickly draft the solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ppkarwasz commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2841620874
> But I'm not quite sure I understand what is the blocker here, sorry. What
can I do to unblock the progress?
Currently you are proposing a new
`PrivateSecurityManagerStac
neboskreb commented on PR #3638:
URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2841585521
@ppkarwasz , as you mentioned in the other ticket, this PR seems to be on a
critical path.
But I'm not quite sure I understand what is the blocker here, sorry. What
can I
neboskreb commented on PR #3643:
URL: https://github.com/apache/logging-log4j2/pull/3643#issuecomment-2841579496
Glad to know we're on the same page, @ppkarwasz ! I shall draft the chapters
you mentioned and you will review/finalize it when time permits.
Regarding #3638, what exactly
ppkarwasz commented on issue #3622:
URL:
https://github.com/apache/logging-log4j2/issues/3622#issuecomment-2841540961
> While testing the Failover Appender, I tried with some approaches, like
>
> 1. Put wrong path in Primary Appender path variable
> 2. Throw an error at Primary Ap
ppkarwasz commented on PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#issuecomment-2841542060
@vy,
What do you think about two new templates instead of a single one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ppkarwasz commented on PR #3643:
URL: https://github.com/apache/logging-log4j2/pull/3643#issuecomment-2841529677
> Android-log4j is not something I actively promote. It was just something I
needed for my hobby project, and having been unable to find a working library
in the whole internet,
18 matches
Mail list logo
