Re: [PR] Reopen log file when rollover is unsuccessful (#3226) [logging-log4j2]

2025-07-30 Thread via GitHub
vy commented on code in PR #3859: URL: https://github.com/apache/logging-log4j2/pull/3859#discussion_r222071 ## src/changelog/.3.x.x/2592_fix_RollingFileManager_unsuccessful_rollover.xml: ## Review Comment: This changelog entry is not needed, please remove. -- This

Re: [PR] Support `FailoverAppender::requiresLocation` [logging-log4j2]

2025-07-30 Thread via GitHub
vy commented on code in PR #3861: URL: https://github.com/apache/logging-log4j2/pull/3861#discussion_r221321 ## src/changelog/.3.x.x/3257_fix_FailoverAppender_requiresLocation.xml: ## Review Comment: This changelog entry is not needed, please remove. -- This is an a

Re: [PR] Reopen log file when rollover is unsuccessful (#3226) [logging-log4j2]

2025-07-30 Thread via GitHub
vy commented on PR #3859: URL: https://github.com/apache/logging-log4j2/pull/3859#issuecomment-3138665359 @jvz, `RollingFileManagerTest` fails, see the CI report. Would you mind first verifying these changes locally, please? -- This is an automated message from the Apache Git Service. To

Re: [PR] ConsoleAppender: Fix missing default Target value [logging-log4j2]

2025-07-30 Thread via GitHub
rschmitt commented on PR #3852: URL: https://github.com/apache/logging-log4j2/pull/3852#issuecomment-3138487374 I'm actually releasing Log4j 2.25.1 right now. I've fixed all the known issues pretty much along the lines you've described, such as adding test dependencies on `jspecify` and dis

[PR] Put 1.5.0 release date onto web site [logging-log4cxx]

2025-07-30 Thread via GitHub
swebb2066 opened a new pull request, #516: URL: https://github.com/apache/logging-log4cxx/pull/516 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] Support `AsyncAppender::requiresLocation` [logging-log4j2]

2025-07-30 Thread via GitHub
jvz opened a new pull request, #3862: URL: https://github.com/apache/logging-log4j2/pull/3862 This is a port of https://github.com/apache/logging-log4j2/pull/3260 to 3.x. This addresses #3257. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Bump log4j-api.version from 2.24.3 to 2.25.1 [logging-log4j2]

2025-07-30 Thread via GitHub
jvz commented on PR #3825: URL: https://github.com/apache/logging-log4j2/pull/3825#issuecomment-3137882595 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Support `FailoverAppender::requiresLocation` [logging-log4j2]

2025-07-30 Thread via GitHub
jvz opened a new pull request, #3861: URL: https://github.com/apache/logging-log4j2/pull/3861 This is a port of https://github.com/apache/logging-log4j2/pull/3259 to the 3.x line. This addresses #3257. A direct cherry-pick was insufficient here due to how the `LocationAware` interfac