Re: [I] Uniformize TLS configuration [logging-log4j2]

2025-08-07 Thread via GitHub
jhl221123 commented on issue #2792: URL: https://github.com/apache/logging-log4j2/issues/2792#issuecomment-3166674556 Hi @ppkarwasz and @vy, Has a decision been made on how to handle `HTTP.verifyHostname` in `3.x`? If so, I'd be happy to start working on consolidating it into `SSL.ve

Re: [PR] Add trailing newlines and emit formatted JSON [logging-log4j-transform]

2025-08-07 Thread via GitHub
ppkarwasz commented on PR #216: URL: https://github.com/apache/logging-log4j-transform/pull/216#issuecomment-3165467448 Thanks again! :100: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] `appenderRefs` in v1 properties files not handled correctly [logging-log4j-transform]

2025-08-07 Thread via GitHub
rschmitt commented on issue #213: URL: https://github.com/apache/logging-log4j-transform/issues/213#issuecomment-3165719119 > I believe we already do emit warnings on unknown keys, but only for V1 configuration, where the list of properties is basically fixed. When converting from V2 confi

Re: [PR] Add trailing newlines and emit formatted JSON [logging-log4j-transform]

2025-08-07 Thread via GitHub
ppkarwasz commented on code in PR #216: URL: https://github.com/apache/logging-log4j-transform/pull/216#discussion_r2261230628 ## log4j-converter-config/src/main/java/org/apache/logging/converter/config/internal/v2/AbstractJacksonConfigurationMapper.java: ## @@ -73,6 +73,8 @@ p

Re: [I] Transformation to `v2:json` does not produce a pretty-printed file [logging-log4j-transform]

2025-08-07 Thread via GitHub
ppkarwasz closed issue #212: Transformation to `v2:json` does not produce a pretty-printed file URL: https://github.com/apache/logging-log4j-transform/issues/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add trailing newlines and emit formatted JSON [logging-log4j-transform]

2025-08-07 Thread via GitHub
ppkarwasz merged PR #216: URL: https://github.com/apache/logging-log4j-transform/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

Re: [PR] Bump org.assertj:assertj-core from 3.27.3 to 3.27.4 [logging-log4j-transform]

2025-08-07 Thread via GitHub
github-actions[bot] merged PR #217: URL: https://github.com/apache/logging-log4j-transform/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Add trailing newlines and emit formatted JSON [logging-log4j-transform]

2025-08-07 Thread via GitHub
rschmitt commented on PR #216: URL: https://github.com/apache/logging-log4j-transform/pull/216#issuecomment-3165242610 @ppkarwasz Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Add trailing newlines and emit formatted JSON [logging-log4j-transform]

2025-08-07 Thread via GitHub
rschmitt commented on code in PR #216: URL: https://github.com/apache/logging-log4j-transform/pull/216#discussion_r2261084319 ## log4j-converter-config/src/main/java/org/apache/logging/converter/config/internal/v2/AbstractJacksonConfigurationMapper.java: ## @@ -73,6 +73,8 @@ pu

[I] Add support for old-style exception rendering in Pattern Layout [logging-log4j2]

2025-08-07 Thread via GitHub
rschmitt opened a new issue, #3873: URL: https://github.com/apache/logging-log4j2/issues/3873 Due to https://github.com/apache/logging-log4j2/pull/3045, all exception messages are prefixed with a newline now: ```text [SIGTSTP] [1] ~/src/logging-log4j2 # rg -txml pattern src/main

Re: [PR] Add trailing newlines and emit formatted JSON [logging-log4j-transform]

2025-08-07 Thread via GitHub
ppkarwasz commented on PR #216: URL: https://github.com/apache/logging-log4j-transform/pull/216#issuecomment-3163735443 @rschmitt, in this repo your commits are not signed, which prevents merging. Could you sign the commits (e.g. by rebasing and force pushing)? -- This is an automated me

Re: [PR] Add trailing newlines and emit formatted JSON [logging-log4j-transform]

2025-08-07 Thread via GitHub
ppkarwasz commented on code in PR #216: URL: https://github.com/apache/logging-log4j-transform/pull/216#discussion_r2259768741 ## log4j-converter-config/src/main/java/org/apache/logging/converter/config/internal/v2/AbstractJacksonConfigurationMapper.java: ## @@ -73,6 +73,8 @@ p