andrei-ivanov commented on a change in pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#discussion_r820284822
##########
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java
##########
@@ -39,14 +39,15 @@
public class SmtpManagerTest {
@Test
- void testCreateManagerName() {
- String managerName = SmtpManager.createManagerName("to", "cc", null,
"from", null, "LOG4J2-3107",
- "proto", "smtp.log4j.com", 4711, "username", false, "filter");
+ public void testCreateManagerName() {
Review comment:
JUnit Jupiter doesn't need tests to be public, I think it's actually
recommended to use the default visibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
