[GitHub] [logging-log4j2] carterkozak commented on pull request #434: LOG4J2-2954 Retain strong reference to shutdown callbacks

2020-11-03 Thread GitBox
carterkozak commented on pull request #434: URL: https://github.com/apache/logging-log4j2/pull/434#issuecomment-721158932 I think the approach in the first commit is less risky, so I'm going to merge that after I verify tests pass locally to ensure this makes the 2.14.0 release.

[GitHub] [logging-log4j2] carterkozak commented on pull request #434: LOG4J2-2954 Retain strong reference to shutdown callbacks

2020-11-03 Thread GitBox
carterkozak commented on pull request #434: URL: https://github.com/apache/logging-log4j2/pull/434#issuecomment-720538814 I think the difference between the first and second commit on this PR is whether or not the JeroMqManager class (and related context classes) should be allowed to be