garydgregory commented on a change in pull request #797:
URL: https://github.com/apache/logging-log4j2/pull/797#discussion_r826897532
##########
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/MessageResolver.java
##########
@@ -134,7 +134,10 @@ private static void resolveString(
jsonWriter.writeObjectStart();
jsonWriter.writeObjectKey(fallbackKey);
}
- if (message instanceof StringBuilderFormattable) {
+ if (message instanceof CharSequence) {
+ final CharSequence sequence = (CharSequence) message;
+ jsonWriter.writeString(sequence);
Review comment:
I agree with @ppkarwasz, this just makes the code more verbose than it
has to be IMO.
Type casting is not an "operation", it does not do anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
