[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852942181 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java: ## @@ -179,6 +180,16 @@ default StrSubstitutor getConfigurationStrSubstitu

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852936220 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/DefaultAsyncWaitStrategyFactory.java: ## @@ -0,0 +1,79 @@ +package org.apache.logging.log4j.cor

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852906491 ## log4j-core/src/test/resources/AsyncWaitStrategyFactoryConfigGlobalLoggerTest.xml: ## @@ -0,0 +1,17 @@ + + + + + + + + + + + + + +

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852906099 ## log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncWaitStrategyFactoryIncorrectConfigGlobalLoggersTest.java: ## @@ -0,0 +1,80 @@ +/* + * Lice

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852905776 ## log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncWaitStrategyFactoryIncorrectConfigGlobalLoggersTest.java: ## @@ -0,0 +1,80 @@ +/* + * Lice

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852904366 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/Configuration.java: ## @@ -179,6 +180,16 @@ default StrSubstitutor getConfigurationStrSubstitu

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852902866 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/DefaultAsyncWaitStrategyFactory.java: ## @@ -0,0 +1,79 @@ +package org.apache.logging.log4j.cor

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852901506 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncWaitStrategyFactory.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852900544 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerDisruptor.java: ## @@ -51,14 +53,17 @@ class AsyncLoggerDisruptor extends AbstractLi

[GitHub] [logging-log4j2] garydgregory commented on a diff in pull request #824: LOG4J2-3472 support custom WaitStrategy configuration

2022-04-19 Thread GitBox
garydgregory commented on code in PR #824: URL: https://github.com/apache/logging-log4j2/pull/824#discussion_r852898785 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigDisruptor.java: ## @@ -166,10 +166,13 @@ private void notifyIntermediateProgre