[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-29 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-700817139 OK, I see. I've been wondering why you didn't commit any codes these days. :rofl: This is an automate

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-29 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-700624599 @jvz Hi Matt, it has been two weeks. When will this PR be merged? This is an automated message from th

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-21 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695798876 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-20 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695801712 @jvz In addition, I would like to know why your commit step is a success but mine is a failure for step `Maven/Build (Ubuntu-latest)` -

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-20 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695798876 @jvz All of the changes have been handled for branch `release-2.x` with https://github.com/apache/logging-log4j2/pull/423.

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-19 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695747057 > By the way, if you'd like this feature in 2.x and not just 3.x, can you file a PR to the `release-2.x` branch? Hi, I'm trying to apply these changes to `release

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-15 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-692845402 @rgoers @jvz Documentation is updated, and fix a timezone bug of DatePatternConverterTest. Please review and merge. ---

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-13 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-691847601 @jvz Please help review and merge this pr. Solve [LOG4J2-2889](https://issues.apache.org/jira/browse/LOG4J2-2889) and [LOG4J2-2714](https://issues.apache.org/jira/brows