[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-22 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r831830675 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +135,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-22 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r831826513 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/ServiceLoaderUtilTest.java ## @@ -86,42 +85,4 @@ public void

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-21 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r831575308 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +78,73 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-19 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830463798 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-18 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830290065 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +135,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-18 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830288798 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -60,43 +80,48 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-18 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830193883 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -47,10 +57,20 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

2022-03-18 Thread GitBox
ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830102145 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/LoaderUtil.java ## @@ -120,6 +120,22 @@ public ClassLoader run() {