[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2023-02-18 Thread via GitHub
ruhulmus commented on PR #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1435733877 > README.adoc @ppkarwasz, Many thanks for the update. I have already Make the PR to that repo. Please check it. Thanks again for your worthwhile effort for the community

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2023-02-15 Thread via GitHub
ruhulmus commented on PR #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1432473392 > @ruhulmus, > > The samples from this repo will end up in [apache/logging-log4j-samples](https://github.com/apache/logging-log4j-samples) in the near future. I'll notify you

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2023-02-15 Thread via GitHub
ruhulmus commented on PR #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1431038707 > Sorry for taking so long to notice this PR. We already have a log4j-samples module that has a sub-module for each sample. It seems to me this belongs under that. Sorry for

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-04-08 Thread GitBox
ruhulmus commented on PR #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1093708523 > logging-log4j-examples > @ruhulmus Thank you for your patience and persistence. > > What you are proposing (if I understand correctly) is quite different from

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-04-07 Thread GitBox
ruhulmus commented on PR #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1092256016 > @ruhulmus, I also agree with Gary and Remko: I fail to see the point of this new Maven artifact. What does it have that is missing in the [official documentation](http

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-04-07 Thread GitBox
ruhulmus commented on PR #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1092154845 Hi @remkop, Did you review the latest one? may I ask What is the additional process for the merge :)? or any additional thing needed? Looking for your feedback :). -- Thi

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-02-22 Thread GitBox
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1047809689 @remkop, Could you please review the changes? I have made updates based on the last discussion. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-02-21 Thread GitBox
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046775984 > @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the doc

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-02-20 Thread GitBox
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046521980 > @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the doc

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-02-20 Thread GitBox
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046311284 > Hello @ruhulmus This looks like an example app and configuration. I do not see why it belongs in the Log4j runtime. What am I missing? Here, logs are running Asyn

[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger

2022-02-20 Thread GitBox
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046217637 > @ruhulmus Please describe what is the goal of this PR. It does not seem to fit in the project. Why a new module and so on? None of the files have the proper Apache lice