[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-10-09 Thread GitBox
vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-706217689 Thanks for the feedback @diepet, keep 'em coming! This is an automated message from the Apache Git Service. To r

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-10-09 Thread GitBox
vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-705785985 _[Sorry for the late reply, I am pretty much swamped with my day job nowadays.]_ @diepet, I have deliberately left out _blank value elimination_ in `JsonTemplateLayout` (

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-10-08 Thread GitBox
vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-705785985 _[Sorry for the late reply, I am pretty much swamped with my day job nowadays.]_ @diepet, I have deliberately left out _blank value elimination_ in `JsonTemplateLayout` (

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-09-28 Thread GitBox
vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-699891074 Let me try to answer your questions @diepet: > 1. When will be the `JsonTemplateLayout` released? Next Log4j 2.x release (2.14.0?) will contain the `JsonTemplateLayo

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-09-02 Thread GitBox
vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-685462219 1. Unless there is a reason to do so, I would avoid custom classes to represent the logging structure. In your case a simple `logger.info(new MapMessage(Map.of("message", messag

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-09-01 Thread GitBox
vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-684510122 @ramazanpolat, yes, `JsonTemplateLayout` can do that. You just need to set `stringified` to `false` (the default) as follows: ```json { "$resolver": "message",

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-08-26 Thread GitBox
vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-680820895 @ramazanpolat, you can access [the latest version of the manual here](https://github.com/apache/logging-log4j2/blob/master/src/site/asciidoc/manual/json-template-layout.adoc.vm).