[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-13 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691710323 > > > the more we do this, the better we get, right? At least, that's the plan (: This is the way... If it turns sideways we change plan (: -

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-12 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-12 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-12 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273 @fluffynuts thanks! I'll test it in live environment and come back with a feedback. btw, this release is a bit messed up ([1](https://github.com/apache/loggin

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-12 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273 @fluffynuts thanks! I'll test it in live environment and come back with a feedback. btw, this release is a bit messed up ([1](https://github.com/apache/loggin

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-06 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687859915 > > > @NicholasNoise btw, I'd just like to update the build system in master to produce the sha512 sigs at build time, sign artifacts from appveyer, update the

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-04 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687048905 > > > @NicholasNoise please have a look over the changes I've made to see that you're happy with them. > > Also, since I know building for the older targ

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-03 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-686364191 > > Yes, it's a PITA to get the environment required to build all targets (I've not only done it more than once, but struggled to find off-premise CI to do so!) --

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-02 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685726181 > > > I'd be very careful about dropping target frameworks. This is a breaking change. All projects using that framework will no longer be able to use the newe

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-02 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685695290 @fluffynuts Thank you for quick response! I made this PR from non-personal fork, but already requested branch setting change to an admin of organization (should be g

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-01 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685327198 @rgoers @fluffynuts This is an automated message from the Apache Git Service. To respond to the messa