Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on issue #1365: URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1757095162 @garydgregory, I see the points you raise. We already expect users to implement `RolloverStrategy`s, which is a public interface. In *all* of our own implementations of

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-10-11 Thread via GitHub
vy closed issue #1365: Request to expose certain protected APIs as public URL: https://github.com/apache/logging-log4j2/issues/1365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-08-09 Thread via GitHub
Karthi1711 commented on issue #1365: URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1671070784 PR created: https://github.com/apache/logging-log4j2/pull/1683. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-03-13 Thread via GitHub
ppkarwasz commented on issue #1365: URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1466986286 @garydgregory, I would just prefer to see this request in the form of a PR, that we can discuss on the code. -- This is an automated message from the Apache Git

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-03-13 Thread via GitHub
garydgregory commented on issue #1365: URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1466908995 I think we want to be careful here @ppkarwasz: Do we really want to lock down an API as public for such low level classes and be bound to binary compatibility? Or are

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-03-13 Thread via GitHub
ppkarwasz commented on issue #1365: URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1466706309 Hello @Karthi1711, Can You submit a PR with the changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] Request to expose certain protected APIs as public (logging-log4j2)

2023-03-13 Thread via GitHub
Karthi1711 opened a new issue, #1365: URL: https://github.com/apache/logging-log4j2/issues/1365 Hello, I would like to request that certain APIs which are currently protected be exposed as public for broader access. Specifically, I am interested in accessing