Re: [I] Zstd compression support (logging-log4j2)

2023-10-11 Thread via GitHub
vy closed issue #1508: Zstd compression support URL: https://github.com/apache/logging-log4j2/issues/1508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Zstd compression support (logging-log4j2)

2023-06-20 Thread via GitHub
rgoers commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1599544900 @ppkarwasz Yes, that sounds like a good approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Zstd compression support (logging-log4j2)

2023-06-19 Thread via GitHub
ppkarwasz commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1596706953 I would model this feature after

Re: [I] Zstd compression support (logging-log4j2)

2023-06-19 Thread via GitHub
rgoers commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1596597848 I will note that the choice of what compression to use is driven by the FileExtension enum. This could easily be replaced by Plugins where each plugin specifies the file

Re: [I] Zstd compression support (logging-log4j2)

2023-06-18 Thread via GitHub
anuragagarwal561994 commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1596244789 @vy I would have loved to but because of time constraints at work, I am not able to give time to contribute to open source at present. I do understand that this

Re: [I] Zstd compression support (logging-log4j2)

2023-06-18 Thread via GitHub
vy commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1596237813 Thanks for the contribution @anuragagarwal561994. As I indicated in my response earlier, I was in the hope of a contribution to *first* make the compression extensible *and then*

Re: [I] Zstd compression support (logging-log4j2)

2023-06-14 Thread via GitHub
anuragagarwal561994 commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1590910188 @vy the MR is actually ready I have integrated it using commons compress itself and the tests were passing in the first go. -- This is an automated message

Re: [I] Zstd compression support (logging-log4j2)

2023-06-13 Thread via GitHub
anuragagarwal561994 commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1590194152 So it is mostly built like Gzip only, just that instead of using GzipOurstream we are using ZstdOutputStream We are using zstd-jni as a dependency here.

Re: [I] Zstd compression support (logging-log4j2)

2023-06-13 Thread via GitHub
vy commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1589141535 @anuragagarwal561994, could you at least share the outline of what you have at work? Is it a custom appender? A layout? -- This is an automated message from the Apache Git

Re: [I] Zstd compression support (logging-log4j2)

2023-06-12 Thread via GitHub
anuragagarwal561994 commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1588254390 @vy I am not sure if I will be able to contribute to in near term. I can share the code we have been using for this purpose in our organisation. May be one

Re: [I] Zstd compression support (logging-log4j2)

2023-06-12 Thread via GitHub
vy commented on issue #1508: URL: https://github.com/apache/logging-log4j2/issues/1508#issuecomment-1587915070 I really liked *both* ideas! 1. Making compression extensible (I actually have created [LOG4J2-3023](https://issues.apache.org/jira/browse/LOG4J2-3023) for something

[I] Zstd compression support (logging-log4j2)

2023-06-09 Thread via GitHub
anuragagarwal561994 opened a new issue, #1508: URL: https://github.com/apache/logging-log4j2/issues/1508 At present log4j2 provides certain compression algorithms like Gzip Lz4 Etc. Zstd in recent times have become popular and we have tried compressing our logs in