ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1823210104
I am converting this PR into an issue: #1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ppkarwasz closed pull request #1586: Bump
com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5
URL: https://github.com/apache/logging-log4j2/pull/1586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1752544784
I have added versions to all our packages in #1843 and configured
`bnd-baseline-maven-plugin` to check for breaking changes. This should warn us
about breaking changes in package
HannesWell commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1751461830
> * we add an explicit OSGi version to all the packages in `log4j-api`.
Since until now the version was inferred from the version of the bundle, the
initial version must be `2.2
ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1751200126
@vy,
It's a question of discipline. If we adhere to very strict rules on how our
API can evolve and have tools to check and enforce those rules, all the users
will profit
vy commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1750765006
@ppkarwasz, how does this help to users that don't use OSGi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1750755195
Yes, it is a bit funny: `3.x` is **not** a major release for `log4j-api`, we
often argued that we don't want to break compatibility, but effectively we do.
So I'd propose t
vy commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1750343752
Binary backward compatibility of `Constants` is broken in `3.x`. [I have
raised this
issue](https://lists.apache.org/thread/fbkc24gp3sfzssqp6mvq62pb3qny1p1y), but
no reactions so far.
