ppkarwasz commented on PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2059218518
@sdavids,
Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ppkarwasz merged PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vy commented on PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2054169637
> There are currently no tests for the JMX support.
> ...
> 1. keep the status quo, i.e. no tests
I'd be in favor of this approach. I doubt if this feature has any
vy commented on code in PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#discussion_r1564897732
##
src/site/antora/modules/ROOT/pages/log4j-jmx-gui.adoc:
##
@@ -18,3 +18,10 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
vy commented on code in PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#discussion_r1564897732
##
src/site/antora/modules/ROOT/pages/log4j-jmx-gui.adoc:
##
@@ -18,3 +18,10 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
sdavids commented on PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2052243202
The double negative `log4j2.disableJmx=false` is unfortunate, but we would
have to deprecate an existing system property and introduce a new one
`log4j2.enableJmx` otherwise.
--
sdavids commented on PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2052182025
There are currently no tests for the JMX support.
`org.apache.logging.log4j.core.jmx.Server#isJmxDisabled` is `private` and
`PropertiesUtil.getProperties()` lazily caches
sdavids opened a new pull request, #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468
https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045821938
## Checklist
* Base your changes on `2.x` branch if you are targeting Log4j 2; use `main`
otherwise
