Re: [PR] Fix Spotbugs alerts up to rank 9 (logging-log4j2)

2023-10-20 Thread via GitHub
ppkarwasz commented on PR #1855: URL: https://github.com/apache/logging-log4j2/pull/1855#issuecomment-1772641647 #1849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix Spotbugs alerts up to rank 9 (logging-log4j2)

2023-10-11 Thread via GitHub
ppkarwasz merged PR #1855: URL: https://github.com/apache/logging-log4j2/pull/1855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix Spotbugs alerts up to rank 9 (logging-log4j2)

2023-10-10 Thread via GitHub
ppkarwasz commented on code in PR #1855: URL: https://github.com/apache/logging-log4j2/pull/1855#discussion_r1352305514 ## log4j-1.2-api/src/main/java/org/apache/log4j/WriterAppender.java: ## @@ -242,12 +243,8 @@ protected OutputStreamWriter createWriter(final OutputStream os)

[PR] Fix Spotbugs alerts up to rank 9 (logging-log4j2)

2023-10-10 Thread via GitHub
ppkarwasz opened a new pull request, #1855: URL: https://github.com/apache/logging-log4j2/pull/1855 This fixes Spotbugs alerts up to rank 9 (the "scary" category). Most are false positives or problems in the tests. The `LocationInfo` fix in `log4j-1.2-api` prevents an NPE though.