vy merged PR #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vy commented on PR #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753#issuecomment-1757399973
@lukaszspyra, you know what, nevermind. I will implement the requested
changes myself. We are on a roll with `2.21.0` release and I want to get your
changes in before we seal it.
--
lukaszspyra commented on code in PR #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753#discussion_r1349398326
##
pom.xml:
##
@@ -1674,6 +1675,13 @@
pre-site
+
+verify-generate-javadoc
+
+
lukaszspyra commented on code in PR #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753#discussion_r1349398078
##
pom.xml:
##
@@ -1867,7 +1875,7 @@
[1.8,)
--Xdoclint:none
+${javadoc.doclint}
Review Comment:
Here javadoc
lukaszspyra commented on PR #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753#issuecomment-1751507277
Hi @vy ,
Thanks for the review.
1. Fixed most remaining errors (removed links which could not be fixed due
to withdrawn `sun.reflect` API, but are meaningful), except 2
vy commented on PR #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753#issuecomment-1749010754
@lukaszspyra, thanks so much for all these fixes! Much appreciated! :bow: I
have two remarks:
1. `./mvnw javadoc:javadoc` is still failing for `-api` and `-core` modules
on a
vy commented on code in PR #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753#discussion_r1347482279
##
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java:
##
@@ -152,14 +152,14 @@ public boolean requiresLocation() {
/**
*
lukaszspyra opened a new pull request, #1753:
URL: https://github.com/apache/logging-log4j2/pull/1753
Ref. #1275
Partly fixes failures of javadoc:javadoc goal. Changes to api and core
modules:
1. added captions for tables
2. added descriptions for param names
3. replaced ``
