tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1820588317
@vy just to let you know that our application initial heap footprint went
down from ~31MB to 25MB (we also disabled initialization of JMX) thanks to
this. Thanks again.
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791244184
Even better: less code is my favourite code :)
We can close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
tristantarrant closed pull request #1848: LOG4J2-3672 Avoid invoking
`DateFormatSymbols.getZoneStrings()` in `FastDateParser`
URL: https://github.com/apache/logging-log4j2/pull/1848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791241536
f9766bb3b7cf7a914c3ae36358aa053ee088b097 should have fixed the issue.
@tristantarrant, would you mind confirming the fix, please? (You can either try
building the sources yourself or
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791258399
@tristantarrant, there were forgotten tests. Pushed one more commit. The new
CI run: https://github.com/apache/logging-log4j2/actions/runs/6736362709
--
This is an automated message
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791067565
I apologize: I included the wrong layout. This one triggers the call:
```xml
```
Removing the `Z` will "fix" it, but then the timestamp will not have the
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791091954
It will generate a `tz.hprof` heap dump which you can open with VisualVM or
Eclipse MAT.
--
This is an automated message from the Apache Git Service.
To respond to the
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791181506
Okay, apparently `FastDateFormat` eagerly creates a `FastDateParser`
instance. I have checked this with other PMC members and decided to remove the
`FastDateParser` from the code base.
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791091177
I've created the reproducer:
https://github.com/tristantarrant/log4j-tzdb-issue
--
This is an automated message from the Apache Git Service.
To respond to the message,
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791030855
`getZoneStrings()` is only used in `FastDateParser`, and when I delete that
class (and some more other code), the code still compiles fine. Anyway,
apparently I am missing something. I
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791008692
Log4j does not parse dates: it parses a date formatter which is then used to
print timestamps in the logs. We use the following layout:
```xml
```
and that
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1791010143
I'll create a small verifier and attach it to the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1790910167
@tristantarrant, the more I digged this the more I felt like you are pulling
my leg. :sweat_smile: Log4j uses date parsing nowhere in the code. I can mark
all data parsing related
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1788742460
Figured the most recent `FastDateParser` from Apache Commons Lang also still
uses `getZoneStrings()`:
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1774755148
> @tristantarrant, I haven't forgotten about this issue and your PR, but
swamped with other priorities right now. Please allow me some time.
I wasn't expecting you to
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1774708370
@tristantarrant, I haven't forgotten about this issue and your PR, but
swamped with other priorities right now. Please allow me some time.
--
This is an automated message from the
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1759346762
I have reworked the PR to lazily initialize the TZ names only if a the date
pattern uses a non-GMT/RFC822-style name. A WARNing will be logged once in this
case.
My
tristantarrant closed pull request #1848: LOG4J2-3672 Avoid invoking
`DateFormatSymbols.getZoneStrings()` in `FastDateParser`
URL: https://github.com/apache/logging-log4j2/pull/1848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1757250950
Hi @vy, I agree we need a better solution.
- avoid constructing that ridiculous regex with all the timezone names
anyway. A simple `[A-Za-z0-9\+\-/\s]+` should be
vy commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1756169179
@tristantarrant, thanks so much for taking time to not only report the
problem, but also provide a fix. :bow: I have some concerns regarding this
change. For one, it is backward
20 matches
Mail list logo
