Re: [PR] Remove instance of checks for async components (logging-log4j2)

2024-01-25 Thread via GitHub
ppkarwasz merged PR #2242: URL: https://github.com/apache/logging-log4j2/pull/2242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Remove instance of checks for async components (logging-log4j2)

2024-01-25 Thread via GitHub
ppkarwasz commented on code in PR #2242: URL: https://github.com/apache/logging-log4j2/pull/2242#discussion_r1466576459 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java: ## @@ -649,7 +649,7 @@ public boolean requiresLocation() { return

Re: [PR] Remove instance of checks for async components (logging-log4j2)

2024-01-25 Thread via GitHub
ppkarwasz commented on code in PR #2242: URL: https://github.com/apache/logging-log4j2/pull/2242#discussion_r1466575669 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java: ## @@ -614,15 +611,18 @@ public ReliabilityStrategy getReliabilityStrategy(

Re: [PR] Remove instance of checks for async components (logging-log4j2)

2024-01-25 Thread via GitHub
vy commented on code in PR #2242: URL: https://github.com/apache/logging-log4j2/pull/2242#discussion_r1466422551 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java: ## @@ -614,15 +611,18 @@ public ReliabilityStrategy getReliabilityStrategy() {

[PR] Remove instance of checks for async components (logging-log4j2)

2024-01-24 Thread via GitHub
ppkarwasz opened a new pull request, #2242: URL: https://github.com/apache/logging-log4j2/pull/2242 This PR removes all occurences of `instanceof Async*` that might prevent the separation of the async support. The removal requires a couple of new API methods and binary incompatible c