jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208098208
##
File path: openide.awt/src/org/openide/awt/Actions.java
##
@@ -80,6 +81,15 @@
*/
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208098445
##
File path: openide.util.ui/apichanges.xml
##
@@ -27,6 +27,22 @@
Actions API
+
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208096985
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208098526
##
File path: openide.awt/src/org/openide/awt/Actions.java
##
@@ -192,12 +207,28 @@ public st
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208097188
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208098877
##
File path:
openide.awt/test/unit/src/org/netbeans/modules/openide/awt/StatefulActionProcessorTest.j
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208099556
##
File path:
openide.awt/test/unit/src/org/netbeans/modules/openide/awt/StatefulActionProcessorTest.j
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208094799
##
File path: openide.awt/apichanges.xml
##
@@ -26,6 +26,21 @@
AWT API
+
+
+
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208099987
##
File path:
openide.awt/test/unit/src/org/netbeans/modules/openide/awt/StatefulActionProcessorTest.j
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208097533
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208100217
##
File path: openide.awt/src/org/openide/awt/ActionRegistration.java
##
@@ -127,4 +127,18 @@
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208095991
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208095451
##
File path:
openide.awt/src/org/netbeans/modules/openide/awt/ActionProcessor.java
##
@@ -3
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208097302
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208096197
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208095117
##
File path: openide.awt/apichanges.xml
##
@@ -26,6 +26,21 @@
AWT API
+
+
+
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208097274
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208100563
##
File path: openide.awt/src/org/openide/awt/GeneralAction.java
##
@@ -74,24 +80,77 @@ publi
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208096064
##
File path: openide.awt/src/org/openide/awt/ActionState.java
##
@@ -0,0 +1,271 @@
+/*
+ * L
jtulach commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r208095703
##
File path:
openide.awt/src/org/netbeans/modules/openide/awt/DefaultAWTBridge.java
##
@@ -
geertjanw commented on issue #651: [NETBEANS-1074] Relicensing form files in
enterprise and ergonomics clusters
URL:
https://github.com/apache/incubator-netbeans/pull/651#issuecomment-41081
Same problem as before?
This i
matthiasblaesing closed pull request #648: [NETBEANS-369] Code-complete outputs
unwanted newline characters
URL: https://github.com/apache/incubator-netbeans/pull/648
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sa
junichi11 commented on issue #651: [NETBEANS-1074] Relicensing form files in
enterprise and ergonomics clusters
URL:
https://github.com/apache/incubator-netbeans/pull/651#issuecomment-410797516
```
The job exceeded the maximum time limit for jobs, and has been terminated.
```
Rest
geertjanw commented on issue #651: [NETBEANS-1074] Relicensing form files in
enterprise and ergonomics clusters
URL:
https://github.com/apache/incubator-netbeans/pull/651#issuecomment-410795918
Somehow Travis failed, does someone know why?
-
junichi11 commented on a change in pull request #652: Initial implementation of
@ActionState support
URL: https://github.com/apache/incubator-netbeans/pull/652#discussion_r207975325
##
File path: openide.awt/test/unit/src/org/openide/awt/StatefulActionTest.java
##
@@ -0,0
sdedic opened a new pull request #652: Initial implementation of @ActionState
support
URL: https://github.com/apache/incubator-netbeans/pull/652
Hi all !
I've decided to modernize implementation of actions in a project I am
working on and found out that action support in OpenIDE lac
geertjanw opened a new pull request #651: [NETBEANS-1074] Relicensing form
files in enterprise cluster
URL: https://github.com/apache/incubator-netbeans/pull/651
This is an automated message from the Apache Git Service.
To r
geertjanw commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410717938
Closing, will send a new one with only the form files in the newly added
modules relicensed.
-
geertjanw commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410713908
This needs to be tweaked to only be run if no Apache license is already in
the file:
https://github.com/apache/inc
geertjanw commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410713209
That sucks. How do we add licenses only to the files that don't already have
them?
---
junichi11 commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410703664
@geertjanw There are duplicate license headers. Probably, the license header
was added to files of other than the 2
sarveshkesharwani commented on a change in pull request #650:
[NETBEANS-1075]-Adding var hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r207878963
##
File path:
java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertVarToExplici
geertjanw commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410693569
Anyone have a reason not to merge this, or does anyone have comments of any
kind?
rtaneja1 commented on a change in pull request #650: [NETBEANS-1075]-Adding var
hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r207851736
##
File path:
java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertVarToExplicitType.jav
rtaneja1 commented on a change in pull request #650: [NETBEANS-1075]-Adding var
hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r207851120
##
File path:
java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java
#
geertjanw commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410633744
Rat report will be cut in half from about 1200 to around 600 unknown files.
---
thilina01 commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410631501
Like to know how the rat-report looks like afer this commit.
-
sarveshkesharwani opened a new pull request #650: [NETBEANS-1075]-Adding var
hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650
In cases of enhanced for loops :
`for (String s : stringArray) {
// Nothing
}`
Hint to change "String" s t
geertjanw commented on issue #649: [NETBEANS-1074] AddFormLicense tool used to
add licenses
URL:
https://github.com/apache/incubator-netbeans/pull/649#issuecomment-410613234
Seems to me that the PR also relicenses form files to Apache that had
already been relicensed to Apache. Not sure i
39 matches
Mail list logo