[GitHub] vikasprabhakar opened a new pull request #698: [NETBEANS-860] Hints: Update test cases

vikasprabhakar opened a new pull request #698: [NETBEANS-860] Hints: Update test cases URL: https://github.com/apache/incubator-netbeans/pull/698 Update the test cases for var parameter list in lambda expression. Verified with nb-javac of JDK11.

[GitHub] thilina01 commented on issue #689: [NETBEANS-1074] Module Review j2ee.ant

thilina01 commented on issue #689: [NETBEANS-1074] Module Review j2ee.ant URL: https://github.com/apache/incubator-netbeans/pull/689#issuecomment-413422741 would love to be ;) :+1: This is an automated message from the

[GitHub] thilina01 commented on issue #691: [NETBEANS-1074] Module Review j2ee.clientproject

thilina01 commented on issue #691: [NETBEANS-1074] Module Review j2ee.clientproject URL: https://github.com/apache/incubator-netbeans/pull/691#issuecomment-413422263 Thank you @junichi11 Just realized how to identify template files. :+1:

[GitHub] thilina01 opened a new pull request #697: [NETBEANS-1074] Module Review j2ee.clientproject - fix pr691

thilina01 opened a new pull request #697: [NETBEANS-1074] Module Review j2ee.clientproject - fix pr691 URL: https://github.com/apache/incubator-netbeans/pull/697 As adviced by @junichi11 https://github.com/apache/incubator-netbeans/pull/691#issuecomment-413210522 Removed License

[GitHub] junichi11 commented on a change in pull request #679: [NETBEANS-1074] Module Review php.twig

junichi11 commented on a change in pull request #679: [NETBEANS-1074] Module Review php.twig URL: https://github.com/apache/incubator-netbeans/pull/679#discussion_r210471215 ## File path: php.twig/licenseinfo.xml ## @@ -0,0 +1,32 @@ + + + + +

[GitHub] junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210470911 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210470221 ## File path: web.beans/src/org/netbeans/modules/web/beans/impl/model/Bundle.properties ## @@

[GitHub] junichi11 commented on issue #687: [NETBEANS-1074] Module Review libs.javacup

junichi11 commented on issue #687: [NETBEANS-1074] Module Review libs.javacup URL: https://github.com/apache/incubator-netbeans/pull/687#issuecomment-413410348 I've submitted about that license to legal-discuss: https://issues.apache.org/jira/browse/LEGAL-400

[GitHub] ocafebabe commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

ocafebabe commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version URL: https://github.com/apache/incubator-netbeans/pull/535#issuecomment-413402099 @matthiasblaesing some tests in libs.git are failing because they're trying to connect to an external remote

[GitHub] gilbertoca commented on a change in pull request #695: [NETBEANS-1074] Module Review web.client.rest

gilbertoca commented on a change in pull request #695: [NETBEANS-1074] Module Review web.client.rest URL: https://github.com/apache/incubator-netbeans/pull/695#discussion_r210457255 ## File path: web.client.rest/src/org/netbeans/modules/web/client/rest/Bundle.properties

[GitHub] gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210456372 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] eirikbakke commented on issue #598: [NETBEANS-977] Improve text layout in word wrap mode.

eirikbakke commented on issue #598: [NETBEANS-977] Improve text layout in word wrap mode. URL: https://github.com/apache/incubator-netbeans/pull/598#issuecomment-413326226 I've added a few more commits to this pull request, to improve the editor's horizontal scrolling behavior to work

[GitHub] matthiasblaesing commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

matthiasblaesing commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210397321 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] matthiasblaesing commented on issue #696: [NETBEANS-1074] Module Review web.client.samples

matthiasblaesing commented on issue #696: [NETBEANS-1074] Module Review web.client.samples URL: https://github.com/apache/incubator-netbeans/pull/696#issuecomment-413322809 Thank you - could you please also add the images from the EaselDemo file? `EaselDemo/public_html/css/images` and

[GitHub] gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210391764 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] matthiasblaesing commented on issue #687: [NETBEANS-1074] Module Review libs.javacup

matthiasblaesing commented on issue #687: [NETBEANS-1074] Module Review libs.javacup URL: https://github.com/apache/incubator-netbeans/pull/687#issuecomment-413319645 From my POV the license reads a lot like the MIT license. But I would raise this with legal, because there are

[GitHub] gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210391764 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] gilbertoca opened a new pull request #696: [NETBEANS-1074] Module Review web.client.samples

gilbertoca opened a new pull request #696: [NETBEANS-1074] Module Review web.client.samples URL: https://github.com/apache/incubator-netbeans/pull/696 Add licenseinfo.xml This is an automated message from the Apache Git

[GitHub] matthiasblaesing commented on issue #686: WIP [NETBEANS-1074] Module Review php.phpdoc.documentation

matthiasblaesing commented on issue #686: WIP [NETBEANS-1074] Module Review php.phpdoc.documentation URL: https://github.com/apache/incubator-netbeans/pull/686#issuecomment-413315886 For the module discussed here (php.phpdoc.documentation): phpdocdesc does not seem to be used (I grepped

[GitHub] matthiasblaesing commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

matthiasblaesing commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210379600 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] matthiasblaesing commented on issue #683: No need to show Apache license on first startup

matthiasblaesing commented on issue #683: No need to show Apache license on first startup URL: https://github.com/apache/incubator-netbeans/pull/683#issuecomment-413270567 Just one question: Does this have consequences for Platform applications? Could they have used the facility to show

[GitHub] matthiasblaesing commented on issue #689: [NETBEANS-1074] Module Review j2ee.ant

matthiasblaesing commented on issue #689: [NETBEANS-1074] Module Review j2ee.ant URL: https://github.com/apache/incubator-netbeans/pull/689#issuecomment-413270045 Merged, as PR is approved, change is good, @thilina01 is not a committer. Thank you!

[GitHub] matthiasblaesing closed pull request #689: [NETBEANS-1074] Module Review j2ee.ant

matthiasblaesing closed pull request #689: [NETBEANS-1074] Module Review j2ee.ant URL: https://github.com/apache/incubator-netbeans/pull/689 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] matthiasblaesing commented on issue #672: JavaFX for NetBeans GUI

matthiasblaesing commented on issue #672: JavaFX for NetBeans GUI URL: https://github.com/apache/incubator-netbeans/pull/672#issuecomment-413269193 The apache projects depend on Java, not the GPLv2-CPE licensed OpenJDK. To make this clear: No I don't like that and I don't like, that the

[GitHub] matthiasblaesing commented on a change in pull request #679: [NETBEANS-1074] Module Review php.twig

matthiasblaesing commented on a change in pull request #679: [NETBEANS-1074] Module Review php.twig URL: https://github.com/apache/incubator-netbeans/pull/679#discussion_r210339082 ## File path: php.twig/licenseinfo.xml ## @@ -0,0 +1,32 @@ + + + + +

[GitHub] junichi11 commented on a change in pull request #695: [NETBEANS-1074] Module Review web.client.rest

junichi11 commented on a change in pull request #695: [NETBEANS-1074] Module Review web.client.rest URL: https://github.com/apache/incubator-netbeans/pull/695#discussion_r210307950 ## File path: web.client.rest/src/org/netbeans/modules/web/client/rest/Bundle.properties ##

[GitHub] junichi11 commented on a change in pull request #695: [NETBEANS-1074] Module Review web.client.rest

junichi11 commented on a change in pull request #695: [NETBEANS-1074] Module Review web.client.rest URL: https://github.com/apache/incubator-netbeans/pull/695#discussion_r210307537 ## File path: web.client.rest/nbproject/project.properties ## @@ -14,6 +14,7 @@ # KIND,

[GitHub] junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210299837 ## File path: web.beans/src/org/netbeans/modules/web/beans/resources/Bundle.properties ## @@

[GitHub] gilbertoca opened a new pull request #695: [NETBEANS-1074] Module Review web.client.rest

gilbertoca opened a new pull request #695: [NETBEANS-1074] Module Review web.client.rest URL: https://github.com/apache/incubator-netbeans/pull/695 Checked the rat-report.txt file Change the license header of Bundle.properties Add the licenseinfo.xml Change the license header of

[GitHub] gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

gilbertoca commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210297345 ## File path: web.beans/src/org/netbeans/modules/web/beans/resources/Bundle.properties ## @@

[GitHub] jtulach commented on issue #690: [NETBEANS-1074] Review of the ergonomics cluster

jtulach commented on issue #690: [NETBEANS-1074] Review of the ergonomics cluster URL: https://github.com/apache/incubator-netbeans/pull/690#issuecomment-413223427 Assuming the travis check is OK, I'd propose to integrate... then we can start using ergonomics for our benefits.

[GitHub] junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210290204 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210287987 ## File path: web.beans/licenseinfo.xml ## @@ -0,0 +1,48 @@ + + + + +

[GitHub] junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210288284 ## File path: web.beans/src/org/netbeans/modules/web/beans/impl/model/Bundle.properties ## @@

[GitHub] junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans

junichi11 commented on a change in pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694#discussion_r210288388 ## File path: web.beans/src/org/netbeans/modules/web/beans/resources/Bundle.properties ## @@

[GitHub] junichi11 commented on a change in pull request #693: [NETBEANS-1074] Module Review j2ee.common

junichi11 commented on a change in pull request #693: [NETBEANS-1074] Module Review j2ee.common URL: https://github.com/apache/incubator-netbeans/pull/693#discussion_r210283573 ## File path: j2ee.common/src/org/netbeans/modules/j2ee/common/dd/resources/beans-1.0.xml ##

[GitHub] junichi11 commented on issue #691: [NETBEANS-1074] Module Review j2ee.clientproject

junichi11 commented on issue #691: [NETBEANS-1074] Module Review j2ee.clientproject URL: https://github.com/apache/incubator-netbeans/pull/691#issuecomment-413210522 @thilina01 It seems that application-client-1.4.xml e.t.c. are template files. So please remove thier license heders, then

[GitHub] jtulach edited a comment on issue #573: [NETBEANS-417] Updating Windows launchers binaries.

jtulach edited a comment on issue #573: [NETBEANS-417] Updating Windows launchers binaries. URL: https://github.com/apache/incubator-netbeans/pull/573#issuecomment-413209526 Please rebuild with changes from #683. Feel free to remove the `AcceptLicense` class then - it should be no longer

[GitHub] jtulach commented on issue #573: [NETBEANS-417] Updating Windows launchers binaries.

jtulach commented on issue #573: [NETBEANS-417] Updating Windows launchers binaries. URL: https://github.com/apache/incubator-netbeans/pull/573#issuecomment-413209526 Please rebuild with changes from PR-#683. Feel free to remove the `AcceptLicense` class then - it should be no longer

[GitHub] gilbertoca opened a new pull request #694: [NETBEANS-1074] Module Review web.beans

gilbertoca opened a new pull request #694: [NETBEANS-1074] Module Review web.beans URL: https://github.com/apache/incubator-netbeans/pull/694 Checked the rat-report.txt file Change the license header of Bundle.properties Add the licenseinfo.xml (little afraid what to put here)

[GitHub] thilina01 opened a new pull request #693: [NETBEANS-1074] Module Review j2ee.common

thilina01 opened a new pull request #693: [NETBEANS-1074] Module Review j2ee.common URL: https://github.com/apache/incubator-netbeans/pull/693 no external library checked Rat report: changed license headers of 16 file added two test template files to licenseinfo.xml

[GitHub] thilina01 closed pull request #692: [NETBEANS-1074] Module Review j2ee.common

thilina01 closed pull request #692: [NETBEANS-1074] Module Review j2ee.common URL: https://github.com/apache/incubator-netbeans/pull/692 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] junichi11 commented on issue #686: WIP [NETBEANS-1074] Module Review php.phpdoc.documentation

junichi11 commented on issue #686: WIP [NETBEANS-1074] Module Review php.phpdoc.documentation URL: https://github.com/apache/incubator-netbeans/pull/686#issuecomment-413170123 @tmysik Thanks for your reply. I'll try to investigate where they are used later.

[GitHub] junichi11 commented on a change in pull request #692: [NETBEANS-1074] Module Review j2ee.common

junichi11 commented on a change in pull request #692: [NETBEANS-1074] Module Review j2ee.common URL: https://github.com/apache/incubator-netbeans/pull/692#discussion_r210236675 ## File path: j2ee.common/licenseinfo.xml ## @@ -0,0 +1,25 @@ + + Review comment: Did you

[GitHub] thilina01 opened a new pull request #692: [NETBEANS-1074] Module Review j2ee.common

thilina01 opened a new pull request #692: [NETBEANS-1074] Module Review j2ee.common URL: https://github.com/apache/incubator-netbeans/pull/692 no external library checked Rat report: changed license headers of 16 file added two test template files to licenseinfo.xml

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r210187332 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r210187094 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertVarToExplicitType.java

[GitHub] geertjanw closed pull request #683: No need to show Apache license on first startup

geertjanw closed pull request #683: No need to show Apache license on first startup URL: https://github.com/apache/incubator-netbeans/pull/683 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] geertjanw commented on issue #683: No need to show Apache license on first startup

geertjanw commented on issue #683: No need to show Apache license on first startup URL: https://github.com/apache/incubator-netbeans/pull/683#issuecomment-413112354 Agreed, and thanks, that will make the startup smoother.

[GitHub] geertjanw closed pull request #688: [NETBEANS-1074] Module Review hibernateweb

geertjanw closed pull request #688: [NETBEANS-1074] Module Review hibernateweb URL: https://github.com/apache/incubator-netbeans/pull/688 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] geertjanw commented on issue #688: [NETBEANS-1074] Module Review hibernateweb

geertjanw commented on issue #688: [NETBEANS-1074] Module Review hibernateweb URL: https://github.com/apache/incubator-netbeans/pull/688#issuecomment-413112070 Thanks, merging. This is an automated message from the Apache

[GitHub] geertjanw closed pull request #691: [NETBEANS-1074] Module Review j2ee.clientproject

geertjanw closed pull request #691: [NETBEANS-1074] Module Review j2ee.clientproject URL: https://github.com/apache/incubator-netbeans/pull/691 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] geertjanw commented on issue #691: [NETBEANS-1074] Module Review j2ee.clientproject

geertjanw commented on issue #691: [NETBEANS-1074] Module Review j2ee.clientproject URL: https://github.com/apache/incubator-netbeans/pull/691#issuecomment-413111666 Thanks. This is an automated message from the Apache Git

[GitHub] tmysik commented on issue #686: WIP [NETBEANS-1074] Module Review php.phpdoc.documentation

tmysik commented on issue #686: WIP [NETBEANS-1074] Module Review php.phpdoc.documentation URL: https://github.com/apache/incubator-netbeans/pull/686#issuecomment-41322 @junichi11 Unfortunately, no idea. I would not be surprised if they were not used at all.

[GitHub] sdedic closed pull request #660: Left/Right arrows are too generic for switching tabs.

sdedic closed pull request #660: Left/Right arrows are too generic for switching tabs. URL: https://github.com/apache/incubator-netbeans/pull/660 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] thilina01 opened a new pull request #691: [NETBEANS-1074] Module Review j2ee.clientproject

thilina01 opened a new pull request #691: [NETBEANS-1074] Module Review j2ee.clientproject URL: https://github.com/apache/incubator-netbeans/pull/691 no external library checked Rat report: changed license headers of five file skimmed through the module, did not notice additional