[jira] [Commented] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere

2018-09-20 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623104#comment-16623104 ] Deepak Dixit commented on OFBIZ-10574: -- Also need to add SecurityPermission data for

[jira] [Commented] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files

2018-09-20 Thread Deepak Nigam (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623042#comment-16623042 ] Deepak Nigam commented on OFBIZ-10575: -- Thanks for your inputs [~jacques.le.roux] and Gil

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2018-09-20 Thread Vikas Mayur (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622872#comment-16622872 ] Vikas Mayur commented on OFBIZ-7147: Hi Jacques, thanks for looking into it. I am not sure of the

[jira] [Commented] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622152#comment-16622152 ] Gil Portenseigne commented on OFBIZ-10575: -- Those two exemple were in my todo list :), i agree

[jira] [Commented] (OFBIZ-10570) Requirement is created for wrong facility

2018-09-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622147#comment-16622147 ] Jacques Le Roux commented on OFBIZ-10570: - The code makes sense to me, +1 > Requirement is

[jira] [Updated] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10576: - Labels: deprecation (was: ) > Deprecate shoppingCart.makeItemShipGroupAndAssoc with

[jira] [Commented] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files

2018-09-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622142#comment-16622142 ] Jacques Le Roux commented on OFBIZ-10575: - Hi Deepak, All, Should not all security data be demo

[jira] [Commented] (OFBIZ-10555) User should not be able to place order with zero item quantity

2018-09-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622125#comment-16622125 ] Jacques Le Roux commented on OFBIZ-10555: - +1 after review > User should not be able to place

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622116#comment-16622116 ] Jacques Le Roux commented on OFBIZ-10515: - Did not get it right 1s time too ;) > Impersonation

[jira] [Closed] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10576. > Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean > parameter >

[jira] [Created] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
Gil Portenseigne created OFBIZ-10576: Summary: Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter Key: OFBIZ-10576 URL: https://issues.apache.org/jira/browse/OFBIZ-10576

[jira] [Updated] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10576: - Attachment: OFBIZ-10576.patch > Deprecate shoppingCart.makeItemShipGroupAndAssoc with

[jira] [Updated] (OFBIZ-10555) User should not be able to place order with zero item quantity

2018-09-20 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-10555: -- Attachment: OFBIZ-10555.patch > User should not be able to place order with zero item

[jira] [Updated] (OFBIZ-10570) Requirement is created for wrong facility

2018-09-20 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-10570: -- Attachment: OFBIZ-10570.patch > Requirement is created for wrong facility >

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621907#comment-16621907 ] Gil Portenseigne commented on OFBIZ-10515: -- Hey Jacques, no it was just a mistake from me,

[jira] [Created] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files

2018-09-20 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-10575: Summary: Move 'SecurityPermission' data to seed data files Key: OFBIZ-10575 URL: https://issues.apache.org/jira/browse/OFBIZ-10575 Project: OFBiz Issue

[jira] [Commented] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere

2018-09-20 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621848#comment-16621848 ] Pierre Smits commented on OFBIZ-10574: -- These are related to customer requirement functions, but it

[jira] [Commented] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere

2018-09-20 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621845#comment-16621845 ] Suraj Khurana commented on OFBIZ-10574: --- Nice catch Deepak. IMO, relation type should also be

[jira] [Created] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' persmission is not defined anywhere

2018-09-20 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-10574: Summary: 'ORDERMGR_CRQ_ADMIN' persmission is not defined anywhere Key: OFBIZ-10574 URL: https://issues.apache.org/jira/browse/OFBIZ-10574 Project: OFBiz

[jira] [Updated] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere

2018-09-20 Thread Deepak Nigam (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Nigam updated OFBIZ-10574: - Description: We have following references for the permissionId 'ORDERMGR_CRQ_ADMIN' in the

[jira] [Updated] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere

2018-09-20 Thread Deepak Nigam (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Nigam updated OFBIZ-10574: - Summary: 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere (was: 'ORDERMGR_CRQ_ADMIN'

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621755#comment-16621755 ] Jacques Le Roux commented on OFBIZ-10515: - Thanks Gil, Just a last remark about the

[jira] [Commented] (OFBIZ-10569) Wrong handling of response type "cross-redirect"

2018-09-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621726#comment-16621726 ] Jacques Le Roux commented on OFBIZ-10569: - Hi Dennis, bq. Yes, the documentation said that, but

[jira] [Commented] (OFBIZ-10569) Wrong handling of response type "cross-redirect"

2018-09-20 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621717#comment-16621717 ] Dennis Balkir commented on OFBIZ-10569: --- Hi Jacques, {quote}You can with "url", but, as it's

[jira] [Commented] (OFBIZ-10569) Wrong handling of response type "cross-redirect"

2018-09-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621714#comment-16621714 ] Jacques Le Roux commented on OFBIZ-10569: - Hi Dennis, bq. But on the other hand, this means,

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621696#comment-16621696 ] Gil Portenseigne commented on OFBIZ-10515: -- Hi Jacques, thanks for the remarks. - "no external

[jira] [Commented] (OFBIZ-10569) Wrong handling of response type "cross-redirect"

2018-09-20 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621626#comment-16621626 ] Dennis Balkir commented on OFBIZ-10569: --- Hi Jacques, yes this makes sense to me. But on the