[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128415#comment-17128415 ] Jacques Le Roux commented on OFBIZ-11745: - Thanks OLivier, Works for me, +1 for

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128394#comment-17128394 ] Jacques Le Roux commented on OFBIZ-11304: - Hi Aditya, Works for me! Sounds like

[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

[ https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128391#comment-17128391 ] Jacques Le Roux commented on OFBIZ-11752: - Thanks Aditya, At 1st glance all is

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128384#comment-17128384 ] Olivier Heintz commented on OFBIZ-11745: Thanks Jacques, corrections done in my

[jira] [Comment Edited] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128086#comment-17128086 ] Olivier Heintz edited comment on OFBIZ-11745 at 6/8/20, 3:25 PM: -

[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

[ https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128325#comment-17128325 ] Aditya Sharma commented on OFBIZ-11752: --- Thanks Jacques for the review and reminde

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128304#comment-17128304 ] Jacques Le Roux commented on OFBIZ-11745: - Thanks Olivier, Still wondering, /pl

[jira] [Comment Edited] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128304#comment-17128304 ] Jacques Le Roux edited comment on OFBIZ-11745 at 6/8/20, 1:37 PM:

[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

[ https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128275#comment-17128275 ] Jacques Le Roux commented on OFBIZ-11752: - Hi Aditya, The PR is OK with me. Did

[jira] [Closed] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11796. - Fix Version/s: 17.12.04 18.12.01 Resolution: Fixed Thanks everyone for

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128255#comment-17128255 ] ASF subversion and git services commented on OFBIZ-11796: - Commi

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128256#comment-17128256 ] ASF subversion and git services commented on OFBIZ-11796: - Commi

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128252#comment-17128252 ] ASF subversion and git services commented on OFBIZ-11796: - Commi

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128210#comment-17128210 ] Arun Patidar commented on OFBIZ-11796: -- Good catch Suraj !!! > Unnecessary itera

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128205#comment-17128205 ] ASF subversion and git services commented on OFBIZ-11762: - Commi

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128206#comment-17128206 ] ASF subversion and git services commented on OFBIZ-11762: - Commi

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128204#comment-17128204 ] ASF subversion and git services commented on OFBIZ-11762: - Commi

[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128202#comment-17128202 ] Priya Sharma commented on OFBIZ-10791: -- Hello Pierre and All, As per my exploratio

[jira] [Updated] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10791: - Attachment: asset-addtocart.png > Unable to add product (of ASSET_USAGE type) in order > ---

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128200#comment-17128200 ] Jacques Le Roux commented on OFBIZ-11762: - Thanks Priya > Use GroovyBaseScript'

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128199#comment-17128199 ] ASF subversion and git services commented on OFBIZ-11762: - Commi

[jira] [Updated] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10791: - Attachment: OFBIZ-10791.patch > Unable to add product (of ASSET_USAGE type) in order > -

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128187#comment-17128187 ] Priya Sharma commented on OFBIZ-11762: -- Hi [~jleroux] I have updated the PR for pl

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #117: Improved: Update Data Sets (OFBIZ-6976)

JacquesLeRoux commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-640248142 Hi Pierre, Maybe because they improved the rules This is an automated message from the Apache

[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

[ https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128142#comment-17128142 ] Aditya Sharma commented on OFBIZ-11752: --- Hi [~jleroux], Should I proceed with mer

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #194: [Improved]: Overload groovy utility method to handle error logging with only throwable object as parameter. (OFBIZ-11762)

priyasharma1 opened a new pull request #194: URL: https://github.com/apache/ofbiz-framework/pull/194 (OFBIZ-11762) This will help us log errors even without passing a custom error message. Please refer PR https://github.com/apache/ofbiz-plugins/pull/24 Thanks: Jacques

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128133#comment-17128133 ] Aditya Sharma commented on OFBIZ-11304: --- Thanks [~jleroux] for trying out the solu

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #24: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] removed a comment on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-637986063 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=24&resolved=false&types=BUG) [](https:

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #24: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] commented on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-640490624 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=24&resolved=false&types=BUG) [](https://sonarc

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128086#comment-17128086 ] Olivier Heintz commented on OFBIZ-11745: hi Jacques, I mean /plugin/ after pre

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128075#comment-17128075 ] Pawan Verma commented on OFBIZ-11796: - +1 Suraj, looks good. > Unnecessary iteratio

[jira] [Commented] (OFBIZ-11806) Create Jira components for web apps in components

[ https://issues.apache.org/jira/browse/OFBIZ-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128065#comment-17128065 ] Pierre Smits commented on OFBIZ-11806: -- Hey Jacques,, Works for me. IMO such place

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128060#comment-17128060 ] Pierre Smits commented on OFBIZ-11796: -- Wel done, Suraj, I guess there may a lot m

[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element

[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128035#comment-17128035 ] Nicolas Malin commented on OFBIZ-11809: --- This patch [^OFBIZ-11808-OFBIZ-11809.patc

[jira] [Updated] (OFBIZ-11809) Access to the current screen from any widget element

[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-11809: -- Attachment: OFBIZ-11808-OFBIZ-11809.patch > Access to the current screen from any widget eleme

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #150: OFBIZ-11468 Improved: Convert ShipmentReceiptServices.xml mini lang to groovy

JacquesLeRoux commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-640464452 Hi Wiebke, After a break, I'll continue to review, sorry for the delay. I agree with Pierre. It does not make sense to have directories with a single file name

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127992#comment-17127992 ] Jacques Le Roux commented on OFBIZ-11762: - Yes please Priya, for logError too.

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128006#comment-17128006 ] Jacques Le Roux commented on OFBIZ-11745: - Hi Olivier, You say: bq. the correc

[jira] [Closed] (OFBIZ-11806) Create Jira components for web apps in components

[ https://issues.apache.org/jira/browse/OFBIZ-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11806. --- Resolution: Done Hi Pierre, I did not create contentimage. It's mainly a placeholder, like

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127955#comment-17127955 ] Priya Sharma commented on OFBIZ-11762: -- Sure, Jacques. Please confirm, do we want t

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

[ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127952#comment-17127952 ] Jacques Le Roux commented on OFBIZ-11796: - Hi Suraj, Weird that nobody thought

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127942#comment-17127942 ] Jacques Le Roux commented on OFBIZ-11762: - Hi Priya, Yes indeed forgot the plug