[jira] [Commented] (OFBIZ-11530) Convert assertInvoiceTotal test from XML to Groovy

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135056#comment-17135056 ] Jacques Le Roux commented on OFBIZ-11530: - Hi Rohit, I also tried that: git am

[jira] [Commented] (OFBIZ-11821) Use Compound Widget on rest of the project

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135047#comment-17135047 ] ASF subversion and git services commented on OFBIZ-11821: - Commi

[jira] [Commented] (OFBIZ-11821) Use Compound Widget on rest of the project

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135013#comment-17135013 ] ASF subversion and git services commented on OFBIZ-11821: - Commi

[jira] [Created] (OFBIZ-11821) Use Compound Widget on rest of the project

2020-06-13 Thread James Yong (Jira)
James Yong created OFBIZ-11821: -- Summary: Use Compound Widget on rest of the project Key: OFBIZ-11821 URL: https://issues.apache.org/jira/browse/OFBIZ-11821 Project: OFBiz Issue Type: Improvemen

[jira] [Comment Edited] (OFBIZ-11530) Convert assertInvoiceTotal test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134787#comment-17134787 ] Rohit Hukkeri edited comment on OFBIZ-11530 at 6/13/20, 9:00 PM: -

[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134914#comment-17134914 ] Jacques Le Roux commented on OFBIZ-11752: - Hi Aditya, Should we not close? > C

[jira] [Commented] (OFBIZ-11530) Convert assertInvoiceTotal test from XML to Groovy

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134908#comment-17134908 ] Jacques Le Roux commented on OFBIZ-11530: - Same issue than in OFBIZ-11557 and OF

[jira] [Assigned] (OFBIZ-11559) Convert testToPayment test from XML to Groovy

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11559: --- Assignee: Rohit Hukkeri (was: Jacques Le Roux) > Convert testToPayment test from X

[jira] [Commented] (OFBIZ-11559) Convert testToPayment test from XML to Groovy

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134904#comment-17134904 ] Jacques Le Roux commented on OFBIZ-11559: - Hi Rohit, Not sure how you created y

[jira] [Commented] (OFBIZ-11557) Convert testInvoiceAppl test from XML to Groovy

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134905#comment-17134905 ] Jacques Le Roux commented on OFBIZ-11557: - I guess I'd got the same issue than i

[jira] [Assigned] (OFBIZ-11559) Convert testToPayment test from XML to Groovy

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11559: --- Assignee: Jacques Le Roux (was: Rohit Hukkeri) > Convert testToPayment test from X

[jira] [Commented] (OFBIZ-11530) Convert assertInvoiceTotal test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134787#comment-17134787 ] Rohit Hukkeri commented on OFBIZ-11530: --- Provided the patch for 'testToPayment' te

[jira] [Updated] (OFBIZ-11530) Convert assertInvoiceTotal test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11530: -- Attachment: OFBIZ-11530.patch > Convert assertInvoiceTotal test from XML to Groovy > -

[jira] [Commented] (OFBIZ-11529) Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134786#comment-17134786 ] Rohit Hukkeri commented on OFBIZ-11529: --- This is part of the issue OFBIZ-11530 >

[jira] [Commented] (OFBIZ-11529) Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134785#comment-17134785 ] Rohit Hukkeri commented on OFBIZ-11529: --- Hello, This test case contains only inpu

[jira] [Commented] (OFBIZ-11558) Convert testBillingAppl test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134769#comment-17134769 ] Rohit Hukkeri commented on OFBIZ-11558: --- Provided the patch for 'testBillingAppl'

[jira] [Updated] (OFBIZ-11558) Convert testBillingAppl test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11558: -- Attachment: OFBIZ-11558.patch > Convert testBillingAppl test from XML to Groovy >

[jira] [Updated] (OFBIZ-11557) Convert testInvoiceAppl test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11557: -- Attachment: OFBIZ-11557.patch > Convert testInvoiceAppl test from XML to Groovy >

[jira] [Commented] (OFBIZ-11557) Convert testInvoiceAppl test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134729#comment-17134729 ] Rohit Hukkeri commented on OFBIZ-11557: --- Provided the patch for 'testInvoiceAppl'

[jira] [Assigned] (OFBIZ-11557) Convert testInvoiceAppl test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reassigned OFBIZ-11557: - Assignee: Rohit Hukkeri > Convert testInvoiceAppl test from XML to Groovy > ---

[jira] [Assigned] (OFBIZ-11558) Convert testBillingAppl test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reassigned OFBIZ-11558: - Assignee: Rohit Hukkeri > Convert testBillingAppl test from XML to Groovy > ---

[jira] [Assigned] (OFBIZ-11560) Convert testTaxGeoId test from XML to Groovy

2020-06-13 Thread Anushi Gupta (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-11560: Assignee: Anushi Gupta > Convert testTaxGeoId test from XML to Groovy > -

[jira] [Commented] (OFBIZ-11559) Convert testToPayment test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134721#comment-17134721 ] Rohit Hukkeri commented on OFBIZ-11559: --- Provided the patch for testToPayment test

[jira] [Comment Edited] (OFBIZ-11559) Convert testToPayment test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134721#comment-17134721 ] Rohit Hukkeri edited comment on OFBIZ-11559 at 6/13/20, 10:04 AM:

[jira] [Updated] (OFBIZ-11559) Convert testToPayment test from XML to Groovy

2020-06-13 Thread Rohit Hukkeri (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11559: -- Attachment: OFBIZ-11559.patch > Convert testToPayment test from XML to Groovy > --

[jira] [Closed] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

2020-06-13 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11804. - Fix Version/s: Upcoming Branch Resolution: Implemented All 6 PR's for separate components

[jira] [Commented] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134710#comment-17134710 ] ASF subversion and git services commented on OFBIZ-11804: - Commi

[GitHub] [ofbiz-framework] surajkhurana merged pull request #202: Improved: Changed decimals, rounding, zero static variables names as per best practices in accounting component.

2020-06-13 Thread GitBox
surajkhurana merged pull request #202: URL: https://github.com/apache/ofbiz-framework/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134709#comment-17134709 ] ASF subversion and git services commented on OFBIZ-11804: - Commi

[GitHub] [ofbiz-framework] surajkhurana merged pull request #201: Improved: Changed decimals, rounding, zero static variables names

2020-06-13 Thread GitBox
surajkhurana merged pull request #201: URL: https://github.com/apache/ofbiz-framework/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
sonarcloud[bot] removed a comment on pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28#issuecomment-643595664 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=28&resolved=false&types=BUG) [](https:

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
sonarcloud[bot] commented on pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28#issuecomment-643595978 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=28&resolved=false&types=BUG) [](https://sonarc

[GitHub] [ofbiz-plugins] surajkhurana merged pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
surajkhurana merged pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134705#comment-17134705 ] ASF subversion and git services commented on OFBIZ-11804: - Commi

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
sonarcloud[bot] commented on pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28#issuecomment-643595664 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=28&resolved=false&types=BUG) [](https://sonarc

[GitHub] [ofbiz-plugins] surajkhurana opened a new pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
surajkhurana opened a new pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28 Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component. (OFBIZ-11804) --

[jira] [Commented] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134697#comment-17134697 ] ASF subversion and git services commented on OFBIZ-11804: - Commi

[GitHub] [ofbiz-framework] surajkhurana merged pull request #196: Improved: Changed decimals, rounding, zero static variables names as per best practices in order component.

2020-06-13 Thread GitBox
surajkhurana merged pull request #196: URL: https://github.com/apache/ofbiz-framework/pull/196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134696#comment-17134696 ] ASF subversion and git services commented on OFBIZ-11804: - Commi

[GitHub] [ofbiz-framework] surajkhurana merged pull request #195: Improved: Changed decimals, rounding, zero static variables names as per best practices.

2020-06-13 Thread GitBox
surajkhurana merged pull request #195: URL: https://github.com/apache/ofbiz-framework/pull/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Assigned] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11304: --- Assignee: Jacques Le Roux > Install a Checkstyle pre-push (on every committer machi

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

2020-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134674#comment-17134674 ] ASF subversion and git services commented on OFBIZ-11304: - Commi

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

2020-06-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134673#comment-17134673 ] Jacques Le Roux commented on OFBIZ-11304: - Hi Aditya, I have pushed a pre-push

[jira] [Commented] (OFBIZ-11808) Improve screen engine with decrease technology dependence

2020-06-13 Thread James Yong (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134669#comment-17134669 ] James Yong commented on OFBIZ-11808: My understanding of this issue: Chapter 1: All